6 Commits

Author SHA1 Message Date
Ian Wienand
9d8cdfaaad
Fix ansible-lint name[template]
ansible-lint's name[template] check looks for templates and says they
should only be at the end of the string.  This is because in many
circumstances, including errors, the name can't be templated in -- so
the message has a chance of not making sense.  Honestly I can never
remember when it's safe to use templates in names and not; this seems
reasonable enough compromise.

Change-Id: I3a415c7706494f393b126b36d7eec7193638a3f1
2022-11-07 10:37:53 +11:00
Sorin Sbarnea
59dad009e9 Bits to keep ansible-lint happy
- moved vars file under vars to avoid failure to load file (newer
  version raise error if you try to put vars outside vars/defaults as
  it will assume they are broken playbooks.
- added missing file-modes on few tasks

Change-Id: I7217469d089b655ee16cd038391cffa4197c8c83
Part-Of: https://review.opendev.org/c/zuul/zuul-jobs/+/773245
2021-03-10 18:04:08 +00:00
Tristan Cacqueray
bd93b3d424 ensure-openshift: remove unused role var
This change removes an ununsed role var as a follow-up for
https://review.opendev.org/c/zuul/zuul-jobs/+/775511

Change-Id: I2d966d744caae744c76d5c8c6b2693eb07e444d1
2021-02-16 18:32:16 +00:00
Tristan Cacqueray
55ca357e39 ensure-openshift: workaround missing ansible26 repository
This change shortcirtcuits openshift repository installation to avoid
pulling the ansible26 repository.

Change-Id: I912a03e6502627340d002b419514f1ebdffb61e5
2021-02-16 15:43:00 +00:00
Albin Vass
9062289151 Check for loop_control in with_ type loops
Change-Id: I191265df7709a6262b44a428d78fe28ffaeb4b75
2020-05-01 13:45:34 +02:00
vass
276a5e919a Rename install-openshift to ensure-openshift for consistency
The old role will be kept and include ensure-openshift for backwards-compatability.

Change-Id: I6ff81fbd04f25207c87834b36e4d636eb9d44a93
2020-04-04 15:41:29 -04:00