3 Commits

Author SHA1 Message Date
Clark Boylan
1f78388328 Improve stage-output functional test
This adds extra . separators to the file we check is renamed. This came
up as a real world issue with devstack when testing the follow on update
to stage-output. We put this in a separate change to ensure the old and
new behavior is consistent.

Change-Id: I3b7504cfd90a4e7523ce88c50e90b2e9004e05ee
2022-09-06 16:16:12 -07:00
Clark Boylan
fbdd81f789 Exercise stage-output extensions_to_txt in testing
This updates our stage-output test to exercise the extensions_to_txt
behavior. Do this as we've seen the performance of these tasks is quite
poor. Testing will help us improve this without breaking things.

Change-Id: I35844fa438773b4789e7f1e4d223bd59d5df7ba7
2022-08-31 13:38:24 -07:00
James E. Blair
f0d7c980b5 Handle no-sudo in stage-output
The stage-output role had two assumptions:

1) The zuul_copy_output variable would always be defined
2) The role would be able to sudo on the remote node

To make it easier for users who want to use this in a base job,
remove both of those assumptions.

1) We now supply a default empty dict if the variable is not defined
so that the role does not fail with an error.

2) We check to see if we can sudo on the remote node, and if we can,
we do when copying files; otherwise we don't, and assume that the
user will only specify files they have access to (if they don't then
the copy will fail).

Change-Id: I5428c44adfafac4872342b59a92de311f41687b6
2021-05-31 15:47:57 -07:00