Fixes several rules with test-playbooks and remove path exclusions.
Since we introduced the progressive mode, exclusions are no longer
needed and not haivng them will assure newly added code follows
the same guidelines.
Change-Id: I0a72d34aff8cf23172e26c7f44e0f61571ec74b6
On Centos8, during the docker-ce installation, the docker.socket service
is start with a bogus state:
docker.socket: Socket unit configuration has changed while unit has been running, no open socket file descriptor left. The socket unit is not functional until restarted.
Later, when the `Assure docker service is running` task tries to start
the service, it fails with the following error:
dockerd[29743]: failed to load listeners: no sockets found via socket activation: make sure the service was started by systemd
Example:
https://0c7366f2ce9149f2de0c-399b55a396b5093070500a70ecbf09b9.ssl.cf1.rackcdn.com/410/c233496b96c70cfc6204e75d10116a96b08d4663/check/ansible-test-sanity-docker/787388f/ara-report/index.html
Another example: https://github.com/kata-containers/tests/issues/3103
Also: Remove use of kubectl --generator=run-pod/v1
This has been deprecated since 1.17 and removed since 1.20. run-pod wound
up being the only generator that did anything, so this parameter became a
no-op. This has to be squashed into this commit to unbreak the gate.
Change-Id: I666046fe2a3aa079643092c71573803851a67be2
ARM64 nodes are currently unavailable, so temporarily remove these
jobs. Unfortunately due to the auto-generated job listings, we need
to completely remove them, not just comment them out.
To be clear, we should add these back (but possibly in a dedicated
secondary pipeline) when we're able.
Change-Id: I462596dfb47ed88e2ba19e314c075227f6f912ac
Reading the installation guide for podman, they reference opensuse.org
as the official package repos for ubuntu:
https://podman.io/getting-started/installation
Using this repo allows us to pull in much newer version of podman on
ubuntu. The current PPA package repo hasn't been updated since late
2019.
Change-Id: Ie34419184925a4bcf30422a782e6a238c11f2319
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
A recent hotfix added a fallback zuul_ssh_key_algorithm value for
the remove-build-sshkey role, reflect it in the role documentation.
Also remove some redundancies with default values specified in prose
for the add-build-sshkey role, when they were also indicated by the
:default: parameter.
Change-Id: If3f74256788283dedb17ad780da3ca4df4503cb4
This change enables using the ensure-zookeeper role in environments
where mounting a filesystem is not allowed.
Change-Id: I1a05a895a45896eca91dccfcfc85aeb1a58689ff
It looks like we never got around to cleaning this up after the npm
5.6.0 over 3 years ago. Now it seems to be causing the error
described in https://github.com/nodejs/help/issues/2874 so let's go
back to using the (presumed working) version of npm which the
node/nvm installation provides.
This reverts commit 0cd5075466ac77565f41074c28b05b0ad1459d86.
Change-Id: I0be3e8fd39845e82790b29d9f2c1e1179cb69e23
- bumps ansible-lint to 5.0
- updates our custom rules to make them compatible with 5.0
- replace custom module mocking with native ansible-lint ones
- remove custom call of ansible-playbook --syntax-check as now this
is done by ansible-lint
- assured molecule vars are hosted under a vars/ folder in order to
avoid confusing linter detection.
- replaced custom rule for loop var names in role as now this this an
optional core feature of the linter (see config)
- replaced custom rule no-same-owner with opt-in one (see config)
Change-Id: I233fae8c9036d295968a97ee80e07fde8846c633
- moved vars file under vars to avoid failure to load file (newer
version raise error if you try to put vars outside vars/defaults as
it will assume they are broken playbooks.
- added missing file-modes on few tasks
Change-Id: I7217469d089b655ee16cd038391cffa4197c8c83
Part-Of: https://review.opendev.org/c/zuul/zuul-jobs/+/773245
The init command was removed from helm with v3, no initialization is
needed anymore. So only run the init task if the version is <= 2.
Change-Id: I59b0c6efa0a2e6b94267fd3bb7a9701bc4c51048
This prepared for ansible-lint v5 which no longer has exceptions
for task naming, requiring all to be named.
Change-Id: I5e761d1e3836fa270d7afdcf01780320001f820d
Part-Of: #773245
Google keeps changing the with_scopes method signature. We need to
override that method in order to keep our path attribute around when
it re-instantiates the object. As long as we always call refresh
after the object is created, we can drop our custom constructor and
then change with_scopes to use generic arguments. This should keep
up with any further minor API changes without needing further local
changes.
Also, a minor inconsistency in command line arguments (used only for
local manual testing) is corrected.
Change-Id: Id41dfc464eb86429771a78c1fefae006e0915cb9
This reverts commit 862ae3f5d6b1c0e94bb24cfebf0b6b71e680e878.
We did not consider the effoct on the quick-download link that
is generated in opendev:
http://paste.openstack.org/show/802839/
Change-Id: I9702f8f1c0155ee3b13c74baaf2c09db72e690fd
Add zuul_log_storage_proxy_address variable attempting to replace
storage endpoint address with.
The usecase is when the storage proxy is positioned infront of storage
endpoint.
Change-Id: I353cd50b76683212b0319a1e28f34901267c08e4
Added default variables to customize the repo name to download
the chart testing helm chart and config files
Change-Id: I37f8db66bdfef7d64e59a89ca8d99b12f95c1be2
This change adds a new attribute to setup zookeeper TLS.
It also adds support for Debian-derived distros.
Change-Id: Ifb5fc51f3b66be0b2dd1b8003507e21d8afe16fc
This change shortcirtcuits openshift repository installation to avoid
pulling the ansible26 repository.
Change-Id: I912a03e6502627340d002b419514f1ebdffb61e5
It is perfectly valid to want to add a value to a file that
does not exist yet, even the path may be missing.
This fixes last night regression when installing docker no longer
creates the /etc/docker folder, causing our MTU update to fail.
Change-Id: I0f037d1d6664de3c3b777aaf6da9cd7c3e8bb15f
Reference: https://review.rdoproject.org/zuul/builds?job_name=tox-py36-ci-config&project=rdo-infra/ci-config
Change Iba195e7c5cec372c6ba4daf7059da5b6fb6740ec implemented
collection of output for `df -i` (inode counts) and `df -m`
(megabytes data) in validate-host, but did not add them to the
report file template. Correct this oversight so that the collected
information will be included in that file.
Change-Id: I8c2c4a90f18394a04fde84355a89a15bf5aa66b4
Include calls to `df -i` (inode counts) and `df -m` (megabytes data)
in validate-host, to aid in troubleshooting build failures where the
builds start out with too little free space. This way the initial
capacity and utilization of all available filesystems will be
recorded with other basic node diagnostic data.
Change-Id: Iba195e7c5cec372c6ba4daf7059da5b6fb6740ec
This can cause problems where set_fact isn't able to override the
variable when bindep is used with include_role and bindep_file is set as
a variable in the include_role task.
Change-Id: I3099f1802f2d30df1265a9abc11a53c923ed4832