zuul
/
zuul
Code Issues Proposed changes

Pin node to version 8: LTS stable 

The 10.0.0 release is incompatible with upath 1.0.4:

  error upath@1.0.4: The engine "node" is incompatible with this module. Expected version ">=4 <=9".

Version 8 is the LTS stable series, 8.11.1 is the latest in that series.

Change-Id: I8251d1e6d815763ac291097d9f4f0ef90195b88b
This commit is contained in:
James E. Blair 2018-04-24 15:43:46 -07:00
parent 623533ab85
commit 1e2ec9ad57
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/pip.sh
View File

@ -22,7 +22,8 @@ if [[ ! $(command -v yarn) ]]
then
pip install nodeenv
# Initialize nodeenv and tell it to re-use the currently active virtualenv
nodeenv --python-virtualenv
# TODO(jeblair): remove node version pin. upath 1.0.4 objects to node >9.
nodeenv --python-virtualenv -n 8.11.1
# Use -g because inside of the virtualenv '-g' means 'install into the'
# virtualenv - as opposed to installing into the local node_modules.
# Avoid writing a package-lock.json file since we don't use it.