Correct comments in requirement test cases
The comments were misleading which led to a lot of head scratching. This corrects the comments to reflect the realities of the test. Change-Id: Id83243140558fb76e91f83843da8285fd17f384b
This commit is contained in:
parent
7f238a2991
commit
2dfc651202
|
@ -248,7 +248,7 @@ class TestRequirementsVote2(ZuulTestCase):
|
||||||
self.assertEqual(len(self.history), 1)
|
self.assertEqual(len(self.history), 1)
|
||||||
self.assertEqual(self.history[0].name, job)
|
self.assertEqual(self.history[0].name, job)
|
||||||
|
|
||||||
# A +2 should allow it to be enqueued
|
# A +2 from nobody should not cause it to be enqueued
|
||||||
B = self.fake_gerrit.addFakeChange(project, 'master', 'B')
|
B = self.fake_gerrit.addFakeChange(project, 'master', 'B')
|
||||||
# A comment event that we will keep submitting to trigger
|
# A comment event that we will keep submitting to trigger
|
||||||
comment = B.addApproval('code-review', 2, username='nobody')
|
comment = B.addApproval('code-review', 2, username='nobody')
|
||||||
|
@ -256,6 +256,7 @@ class TestRequirementsVote2(ZuulTestCase):
|
||||||
self.waitUntilSettled()
|
self.waitUntilSettled()
|
||||||
self.assertEqual(len(self.history), 1)
|
self.assertEqual(len(self.history), 1)
|
||||||
|
|
||||||
|
# A +2 from jenkins should allow it to be enqueued
|
||||||
B.addApproval('verified', 2, username='jenkins')
|
B.addApproval('verified', 2, username='jenkins')
|
||||||
self.fake_gerrit.addEvent(comment)
|
self.fake_gerrit.addEvent(comment)
|
||||||
self.waitUntilSettled()
|
self.waitUntilSettled()
|
||||||
|
|
Loading…
Reference in New Issue