zuul/zuul
Code Issues Proposed changes

Fix instance check when refreshing dependencies

Browse Source 
2022-09-23 10:01:32,395 ERROR zuul.Scheduler: Exception processing pipeline post in tenant foobar
Traceback (most recent call last):
  File "/opt/zuul/lib/python3.10/site-packages/zuul/scheduler.py", line 2089, in process_pipelines
    refreshed = self._process_pipeline(
  File "/opt/zuul/lib/python3.10/site-packages/zuul/scheduler.py", line 2157, in _process_pipeline
    self.process_pipeline_trigger_queue(tenant, pipeline)
  File "/opt/zuul/lib/python3.10/site-packages/zuul/scheduler.py", line 2350, in process_pipeline_trigger_queue
    self._process_trigger_event(tenant, pipeline, event)
  File "/opt/zuul/lib/python3.10/site-packages/zuul/scheduler.py", line 2380, in _process_trigger_event
    pipeline.manager.refreshDeps(change, event)
  File "/opt/zuul/lib/python3.10/site-packages/zuul/manager/__init__.py", line 296, in refreshDeps
    for dep_change_ref in item.change.commit_needs_changes:
AttributeError: 'Branch' object has no attribute 'commit_needs_changes'

Change-Id: I740d277c59764acfe982a24e3c5e972e8d3179d6
This commit is contained in:
Simon Westphahl
2022-09-26 09:59:40 +02:00
parent 2f1e7f2cf5
commit 48ffeb30b3
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zuul/manager/__init__.py
View File

@@ -287,7 +287,7 @@ class PipelineManager(metaclass=ABCMeta):
change_in_pipeline = False
for item in self.pipeline.getAllItems():
if not isinstance(change, model.Change):
if not isinstance(item.change, model.Change):
continue
for dep_change_ref in item.change.commit_needs_changes:
if item.change.equals(change):