zuul
/
zuul
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review+2

(2 comments)

Patch-set: 5
Label: Code-Review=+2, 7aae1c368e7eab09f14d2a6847fcd6bbfa35bf4a
This commit is contained in:
Gerrit User 9311 2024-05-02 19:33:37 +00:00 committed by Gerrit Code Review
parent 977ce4c3f6
commit 5a85bb05fd
1 changed files with 41 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
5ac02b0f2bc80df6f530a4ccb9e6b56254867f8f
View File

@ -17,6 +17,23 @@
"revId": "5ac02b0f2bc80df6f530a4ccb9e6b56254867f8f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c77ded00_7a67904d",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 9311
},
"writtenOn": "2024-05-02T19:33:37Z",
"side": 1,
"message": "Removing my -1 since we can view that stack as all-or-nothing.",
"revId": "5ac02b0f2bc80df6f530a4ccb9e6b56254867f8f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -40,6 +57,30 @@
"revId": "5ac02b0f2bc80df6f530a4ccb9e6b56254867f8f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5e2ac16a_ba6677b6",
"filename": "web/src/containers/status/PipelineSummary.jsx",
"patchSetId": 5
},
"lineNbr": 56,
"author": {
"id": 9311
},
"writtenOn": "2024-05-02T19:33:37Z",
"side": 1,
"message": "I meant, I think it would help if this check was implemented as a `isPipelineDependent` predicate function.",
"parentUuid": "6acaad4f_d5369488",
"range": {
"startLine": 56,
"startChar": 44,
"endLine": 56,
"endChar": 46
},
"revId": "5ac02b0f2bc80df6f530a4ccb9e6b56254867f8f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {