zuul/zuul
Code Issues Proposed changes

Support merged as requirement in github driver

Browse Source 
Currently when creating a post pipeline with the github driver we can
only use the push event. This has the drawback that it ignores
protected branches and thus also works speculatively on any branch if
you want to have a generic post pipeline. This imposes problems with
secrets.

So instead using the push event we want to trigger on pull_request
closed events. However this currently doesn't work as we cannot
distinguish between merged and abandoned pull requests. Adding a
merged requirement nicely solves that problem.

Change-Id: I46670c6aa036976c430a6034a6b1da0e23fa9f92
This commit is contained in:
Tobias Henkel
2018-05-15 09:33:46 +02:00
parent 1b747ca65f
commit 735190f2ec
6 changed files with 72 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
releasenotes/notes/require-merged-70784e1e45cac08e.yaml Normal file
View File

@@ -0,0 +1,5 @@
---
features:
- |
The GitHub driver now supports the :attr:`pipeline.require.<github source>.merged`
requirement.