Merge "github: Optimize getPullReviews() a bit"

zuul/driver/github/githubconnection.py

@@ -998,7 +998,9 @@ class GithubConnection(BaseConnection):
 
         revs = self._getPullReviews(owner, proj, number)
 
+        permissions = {}
         reviews = {}
+
         for rev in revs:
             user = rev.get('user').get('login')
             review = {
@@ -1015,7 +1017,13 @@ class GithubConnection(BaseConnection):
 
             # Get user's rights. A user always has read to leave a review
             review['permission'] = 'read'
-            permission = self.getRepoPermission(project.name, user)
+
+            if user in permissions:
+                permission = permissions[user]
+            else:
+                permission = self.getRepoPermission(project.name, user)
+                permissions[user] = permission
+
             if permission == 'write':
                 review['permission'] = 'write'
             if permission == 'admin':