* This commit will remove unused constant.
* According to issue, we have one unused constant:
pkg/document/constants.go
Change-Id: Ib93fa01dbd60bb48cf6b8b77298bd0ab4d5b82a4
TestPull unit test should not perform functional verification. The purpose of
cmd unit tests should be testing proper cmd object creation, not actually run
the command. Moreover, we don't have possibility to mock and track all the
objects that created inside of called functions. We can only verify golden output
with help or when command performs basic stuff just inside of RunE interface. Actual
test of called methods performed in pkg module.
Change-Id: I2ad6b76f67cbf59d798c0f2b93752b3e3b3b053d
Signed-off-by: Ruslan Aliev <raliev@mirantis.com>
In 21_systemwide_executable.sh and 22_test_configs.sh the HTTP_PROXY
variable is not being set while the HTTPS_PROXY variable is being set
twice.
Closes: #318
Change-Id: I84de84b79b76cef3967248f730f022f1b8f34987
Move code from environment module to util and document
modules to prevent circular dependencies.
Relates-To: #264
Change-Id: Ifec9ab3f1ada01cc662e655ff4a6f2cfebe4150a
1) modifications to exported functions/variables documentation
2) moved some methods into a different folder
Change-Id: I212442516424bde3284f75b326d152c290d20c80
This patch refactors some code and adds useful debug/info log output.
Change-Id: I590f6e5c300e5c91443af0a8fdb1073229602a67
Signed-off-by: Ruslan Aliev <raliev@mirantis.com>
Relates-To: #278
As mentioned in the issue there is only one duplicate key:
cmd/cluster/testdata/statusmap/legacy-crd.yaml:metadata
Change-Id: I2c82595c44645f3a104b45db52c2a3943877d9f1
Relates-To: #311
This commit adds generating CRD into different files for each phase
Change-Id: I574b27d737f946415e64eaf5b1d5bf962d6c2cc1
Signed-off-by: Sreejith Punnapuzha <sreejith.punnapuzha@outlook.com>
This sets the validation gate to be voting again; it had been turned
off while some work was in flight. However, the check is passing again
and re-enabling it will help ensure document goodness.
A couple of tweaks were made based on issues seen during multi-cluster
testing:
1. The kind cluster is now torn down between each cluster (eph and target).
We'd been reusing the cluster for the sake of speed, but deleting
everything out of it still left some unexplained cruft behind,
which broke validation of the second (target) cluster.
2. This reverts back to a simple approach to phase selection and sequencing,
away from a fancier technique which was failing the only phase
was "initinfra".
Note: once `airshipctl phase validate` and a queryable phase map are
in place, the gate should be reworked to leverage them instead.
Change-Id: I37c51e859e2df880981e2e138a67c23e17eabd93
There are 2 ways to define variables for substitution:
1) Define them as Environment variables and set EnvVars: true
in clusterctl object
2) Define them in additional-vars map in clusterctl object
Also adds possibility not to substitute variables if they are not defined in
in additional-vars or in environment for specific provider. But be aware,
if these variables are defined they will be substituted even if
variable-substitution: true
Change-Id: I0c92b3c37ac7b2e7c48c1033c074baef48f752a7
Relates-To: #284
* capi, capbk, cacpk, cacpm. all have cert-manager functionality included,
so the standalone function can be removed.
Closes: #301
Change-Id: I8628a113a66e1b74af3356dfa95e979e9fc987f7
Due to incorrect processing IP:port pairs using 'regex_replace' filter,
roles-test gate job fails. This patches fixes all the related errors and
CI gate check itself.
Change-Id: Ifd7f890166195df0af9b34e1ccff59b7abd2d9ab
Relates-To: #305
Closes: #305
Signed-off-by: Ruslan Aliev <raliev@mirantis.com>
This PS has a function which constructs a collection of Metal3 BareMetalHost
resources, along with associated configuration Secrets.
It solves for a couple of things:
1. pulling the nitty gritty details for generating BMH into one reusable place,
2. allowing the site-specific details to be filled in via catalogues of values
This function leverages a couple of different plugins in sequence:
The airshipctl Replacement plugin, which pulls the site-specific data from
the catalogue documents into a Templater plugin configuration; and then
the airshipctl Templater plugin, which generates a variable number of
BMHs in a data-driven fashion.
More details can be found in the README.md in this patchset.
Closes: #245
Change-Id: I3ddbd36dc53ea6afbd633098c985f4b28bcbb793
With this commit executors will not rely on hardcoded path to build
bundle with phase information
Change-Id: I6b8826929cb5a4b95a5c4d30f23fad3a3af52555
Relates-To: #259
In this fix, we make sure that targetPath is taken into the account
when forming path to metadata file
Change-Id: Ie94c3508161b8c3b9254db08f4bf809348ff54f0
Relates-To: #295
Closes: #295
This will also enable us to wait for kubernetes resources to reach
required state
Relates-To: #238
Change-Id: Ia2c9cebd94ca2ef5bfd9ed5830ae469e6aa6b167
Phases should be ordered when rendering to prevent error like:
'... no matches for kind "Cluster" ...'
Change-Id: I830c36b5959ae3970b261f96ff6d23bf467f5ff6
airshipctl config init command currently fails with "no such file or directory"
error, this patch fixes it.
Change-Id: I78cff26ed71bdb400ce897630102350e72dc495d
Signed-off-by: Ruslan Aliev <raliev@mirantis.com>
The commit adds applier object from cli-utils which would allow us
to wait for kubernetes objects to reach required states and support
pruning.
Integration is very similar to the one with kubectl, because backend
mechanism for reading manifests is the same. We need to write them to
temporary directory in $HOME/.airship directory, and point cli-utils
to it. It will then take care of storing what was applied to k8s cluster
for prunning and also will be capable of waiting for core resources to
reach required state by constantly polling them.
To integrate we need to create a namespace in which we will store
configmap that keeps track of what objects were applied before and enable
prunning
Relates-To: #238
Change-Id: I4c0123cc57b78bd13dbe320e0ab9f28bbed2301d
This implementation would allow to use bundle as source of manifests
for cli-utils applier, and will also eliminate the need to dump manifests
to the filesystem
Change-Id: I37f21beaaf4cb2800b50d4ccb18596a4c09ea19b
*) Most the errors.go has 0% coverage due to usage of
Fatal.
*) so ignoring errors from coverage till we cleanup the references to Fatal
and use custom errors/warnings.
Change-Id: I56f838ec33336ccca3c14226e791842d159a95fb
