Commit Graph

300 Commits (36f0b89766f08790579f809eef848657a81ebc41)

Author SHA1 Message Date
Kazuhiro Suzuki 36f0b89766 Blacklist stestr 3.0.0 and drop pypy
stestr 3.0.0 does not support python 2.7 but has been released without
the proper metadata to reflect that. As a result, there is a python2 wheel
stestr-3.0.0-py2-none-any.whl which get picked up.

Blacklist stestr 3.0.0 to fix '--list': no such option error

Drop pypy testing since pypy jobs are always failling.

Signed-off-by: Antoine Musso <>
Signed-off-by: Andreas Jaeger <>
Change-Id: Ia2f7c814f21c78f29ec9024997469625f92bc401
2020-04-17 14:46:18 +02:00
Zuul 9e66e45f0a Merge "Include placeholder tasks in get_running_builds" 2020-03-04 02:58:33 +00:00
Pascal Hofmann 19e7f7395a Include placeholder tasks in get_running_builds
Pipeline jobs in in Jenkins 2.x appear as placeholder tasks for their
entire lifetime when queried via the API. The fix for #1659787
introduced completly ignoring placeholder tasks. Thus pipeline jobs are
never included in the list returned by get_running_builds.

This commit will change the behaviour of get_running_builds as follows:
  - Placeholder tasks will be included: So running pipeline jobs
    will be included.
  - Builds which do not have a build number yet will be ignored:
    This prevents the exception described in #1659787.

Change-Id: I30351ec78d6186b0674e3c08be00076b0ce2333e
Closes-Bug: #1750372
Related-Bug: #1659787
2019-12-25 08:43:46 +01:00
Jeff Schroeder 9bf7f81509
Fix reconfig_credential() to send the xml data
Previously, reconfig_credential() passed empty `data` with
`Content-Length: 0` to the credentials configuration rather
than the credentials data.

This patch fixes the issue by passing the config_xml data to
the configuration API to properly update the credential.

Change-Id: Idef50f5a31d55991698b6217f55f15a9308b8526
2019-12-16 09:32:50 -05:00
Zuul 36c99d3436 Merge "new method: create_folder (with tests)" 2019-12-16 14:08:18 +00:00
Marcos Diez d6d510b59d new method: create_folder (with tests)
Change-Id: Ib21398c98d853aed4f4eea50270164e501fd18ce
2019-12-15 23:57:11 -03:00
Marcos Diez f222797332 new method: check_jenkinsfile_syntax (with tests)
Change-Id: I77a04c95ee3e4d9184bb418853ae414957bf0280
2019-12-15 23:41:38 -03:00
Zuul 306a40b3b4 Merge "upsert_job" 2019-12-09 15:07:01 +00:00
Andreas Jaeger 1749d4d2f5 Update docs building job
Replace the readthedocs template that warns about a broken setup
with a template that just builds the documents
(build-openstack-docs-pti) so that we can remove the obsolete template.

If the repo wants to use publish later to readthedocs, the template
can be changed to docs-on-readthedocs as explained in

Change-Id: I343d16e6ec8180f4fd9ac058eaab06378ccee6bc
2019-09-29 18:05:55 +02:00
Marcos Diez 722a303f9a upsert_job
Change-Id: I1f389baf1c530b6e04860569deb5aca51bf781c2
2019-09-17 10:12:27 -03:00
Zuul 35f660a8b9 Merge "When updating jobs the response body may be empty" 2019-07-23 15:12:05 +00:00
Zuul ac7fc35b1b Merge "Make get_job_info fetch_all_builds work with jobs in folders" 2019-05-23 14:11:46 +00:00
K Jonathan Harker 0ab91c7a7c Remove pin on mock module
This was pinned for python26, which we no longer support.

Change-Id: I7dfd92c011b223d171ffd4be9c3f8c59fe87c6cf
2019-05-23 11:38:13 +00:00
Andreas Jaeger 748aa2068b Update jobs
The repo uses docs-on-read-the-docs, remove extra
build-openstack-sphinx gate job.

Without this change, two docs jobs would be building in gate, tox-docs
and build-sphinx. One is enough.

Also, use templates instead of individual jobs.

Import other templates from project-config, use the failing docs
template since readthedocs is not setup yet.

Remove publish-to-pypi, this should stay in project-config.

Fix sphinx requirements for python 3.

Fix decoding in failing test.

Change-Id: Ic4f715b45c1284ea49339e96c2aa87b2e81fcbea
2019-05-21 21:35:07 +02:00
Frank Lichtenheld 190fbbb5ad Make get_job_info fetch_all_builds work with jobs in folders
Make sure to use fullName from the API results to correctly
compute the URL for the additional API request.

Change-Id: I7ca1f2e15a6c40883ba376b182c2c991ca76e8b2
2019-05-07 17:23:14 +02:00
OpenDev Sysadmins a5615d04f8 OpenDev Migration Patch
This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at with any
questions you may have.
2019-04-19 19:49:46 +00:00
Jan Zerebecki a2c6f6a8ff
When updating jobs the response body may be empty
Other specific requests may need a body. Thus remove the general check
for an empty body and add a more specific one where needed.

I noticed this because when updating a Jenkins job with Jenkins Job
Builder I got an EmptyResponseException even though updating worked

Change-Id: Ie144e6fb0b922a681e6c65ffbe5120da72a495f0
2019-01-07 21:52:19 +01:00
Zuul 5c287258eb Merge "add python 3.6 unit test job" 2018-12-27 11:31:41 +00:00
qingszhao 4a7c4ff539 Add Python 3.6 classifier to setup.cfg
Change-Id: Idca52cc5f2038db9a528bc5297b65e60a170ccb0
2018-11-29 09:40:08 +00:00
Vieri 9f77e68ef6 add python 3.6 unit test job
This is a mechanically generated patch to add a unit test job running
under Python 3.6 as part of the python3-first goal.

See the python3-first goal document for details:

Change-Id: I80117242630a1aa6df39b33b0ab66616ab8923a9
Story: #2002586
2018-11-28 07:04:07 +00:00
Zuul 7166f872f5 Merge "Merge jobs_in_folder_named_job into jobs_in_folder" 2018-10-26 19:52:28 +00:00
huang.zhiping 81dd80922c Update min tox version to 2.0
The commands used by constraints need at least tox 2.0.  Update to
reflect reality, which should help with local running of constraints

Change-Id: I8146e56453c518f8d8ae822157c1e4931708959a
2018-10-21 02:20:04 +00:00
Zuul 5d1bb50bc3 Merge "Request multiple folder levels at once in get_all_jobs" 2018-10-19 15:36:37 +00:00
Zuul 2aef1bb5fb Merge "Make jjb-tox-cross-jenkins-job-builder voting" 2018-10-19 14:52:02 +00:00
Tomas Janousek c02b0b61c5 Merge jobs_in_folder_named_job into jobs_in_folder
Now that jobs_in_folder isn't reused in all other get_(all_)jobs tests
there's no more any reason to keep jobs_in_folder_named_job a separate

Change-Id: Ic51a4b2cac3105cf9406d2a7864943a7df1248be
2018-10-17 18:06:56 +02:00
Tomas Janousek b5a8b7035e Request multiple folder levels at once in get_all_jobs
On our Jenkins instance with almost a hundred folders, JJB update
stalls for quite a while because it calls get_all_jobs. When invoked
locally at the Jenkins master, it's a matter of seconds, on a fast
broadband link and VPN, it's 2 minutes, and on a train it's easily 10

But there's trick!

    curl \
        --show-error --silent --fail \
        --user : --negotiate \
        --get \
        --data-urlencode \

This returns almost instantly.

And it gets better: if we fail to correctly guess the nesting level
necessary, Jenkins returns

    …, "jobs": [{}, {}, …], …

so we can easily detect that we need to recurse deeper.

Change-Id: I7268259149e4bc8939c512a112c7e6ec1908224f
2018-10-17 18:06:56 +02:00
Tomas Janousek 05986a64d7 Replace build_jobs_list_responses with actual Jenkins responses
This abstraction did more harm than good -- pretended to create correct
JSON responses from a simpler structure, but created responses that were
very far from what Jenkins would return:

* "url" fields didn't contain folders, but nobody noticed as these
  weren't used anyway

* "jobs" fields contained the string "null" (not JSON null, an actual
  JSON string!), whereas real Jenkins returns a list of almost empty
  objects (just a "class" field, if Jenkins is new enough, otherwise

* "color" field is absent from folders

The usage of deepcopy, insert and append totally obstructed the real
contents of those responses from most readers. Let's just be a bit
verbose here, please.

Change-Id: Ida2cfa3662e491e4178228096dc622cdd859202f
2018-10-17 18:06:56 +02:00
Tomas Janousek 49d6c92d0c Clean up job/folder path handling
Avoid repeatedly serializing and splitting the root path component of
jobs being added to the list to be processed and returned.

Attempting to split a string path using 'job' introduces a bug if a job
ever happens to also use the name 'job' as part of its name. This could
be fixed by using root.split('/job/') but it still seems hackish.

Maintain the root path to the folder in the hierarchy as a list of path
components, add to it when descending and store the result of joining
it with '/job/' as a separate variable to avoid needing to re-parse.

Change-Id: I074ad74ad935c50716141a79822ca84999734c3f
2018-10-17 18:06:56 +02:00
Tomas Janousek b1564e94b5 Test requested URLs in test_getall
This would've caught that the info parameter is ignored in get_info and
I'm going to refactor/improve get_all_jobs so I need stricter tests

Also, this makes test_unsafe_chars useful. Before it was a totally
meaningless test that didn't test anything at all. :-(

(Actually the get_info problem was caught by this test, but I'm
committing the fix first to not break git bisect.)

Change-Id: Ifd06bbbd9969a2739322e36ae83f521490a6eaa0
2018-10-17 18:06:56 +02:00
Sorin Sbarnea 8cdf785514 Make jjb-tox-cross-jenkins-job-builder voting
Avoid accidents where python-jenkins change may break jjb. Job
run succesfully for months.

Change-Id: Icd0d49ab2876af16fbc45afe2e554744f42bc649
2018-10-05 18:35:04 +01:00
Zuul afa1e05e74 Merge "Check for 'Location' header in the response" 2018-09-21 14:11:48 +00:00
Zuul ede93173e3 Merge "Add folder credential support" 2018-09-21 13:46:39 +00:00
Aigars Mahinovs 811a6cffc8 Allow adding extra HTTP headers to Jenkins requests
In some network setups Jenkins may be hidden behind complex reverse
proxy setups that require additional custom headers to be set on
each request in order to pass them trough

Allow providing such headers using JENKINS_API_EXTRA_HEADERS environment

Change-Id: If071c5c707f916ba5f4f2c371ec600b7476bf723
2018-09-12 13:42:23 +02:00
Thanh Ha 93515ae07d
Revert "detect and respect http redirects"
This reverts commit 4150a83d45.

Change-Id: I972404ff936cbd3c0fe164dcbaa186d5e530736c
2018-08-24 13:12:38 -04:00
Thanh Ha f68b2fb9d6
Revert "Avoid empty body failure on HEAD requests"
This reverts commit 5e8dfb9065.

Change-Id: Ia82e11b65c0d175f2d3b517e43176213eb1a4ae0
2018-08-24 13:12:37 -04:00
Zuul 437d5de4e9 Merge "Fix item being ignored in get_info" 2018-08-13 14:10:04 +00:00
Sorin Sbarnea 5e8dfb9065 Avoid empty body failure on HEAD requests
HTTP specification states clearly that HEAD requests
should have no body, so we should not fail on these.

Change-Id: I9d2418f26c26b2a40f6bafaf86ed6640fbf83b0c
2018-08-07 17:53:14 +01:00
Tomas Janousek fc953ee505 Fix item being ignored in get_info
This, I think, would've caused get_all_jobs to loop indefinitely if the
Jenkins instance has folders. Am I really the first to have caught this?

Change-Id: I4158b0d068135de08a3337486d8a4b41d8b7cda6
2018-08-04 19:05:15 +02:00
joelee 857235b7fa Add folder credential support
implement functions to manage credential in Jenkins Folder
job with rest api provided by :

Change-Id: I9bcc3943e4ec705fe8705ad1d457b6fd4ad1024a
2018-08-03 06:39:13 +03:00
Sorin Sbarnea 4150a83d45
detect and respect http redirects
Detects if API url is redirected and corrects it in order
to avoid doubling number of requests and even failing
POST ones because of having them silently converted by
requests from POST to GET.

Displays a warning to the user when redirection occurs
because almost always this means that they are using an
old endpoint, like a non secured one.

Change-Id: I7387bf150dad307342f9a6a91afbae32859bc82e
Signed-off-by: Sorin Sbarnea <>
2018-07-16 17:56:19 +01:00
Richard Felkl 4e64f0f880 Fix run_script method.
Existing code assumes the script sent by the user is terminated with a newline.
Appending magic string without '\n' before print() command results in a syntactically
incorrect Groovy code.
This patch ensures that '\n' is added between user's provided script and appended
magic string.

Change-Id: I39021f1058e7434d487efb4bc7aca18416b2c08e
2018-07-10 15:40:07 +02:00
Dennis Dmitriev f420d6de01 Check for 'Location' header in the response
If the keep_alive is not available because of using reverse
proxy, the header 'Content-Lenght' may not be available,
causing the exception:

 Error communicating with server[...]: empty response

However, if 'Location' header is present, the response is valid.

Add unit tests:
- build_job must pass even if no 'content-lenght'
  in response header
- build_job must fail if no 'location' in response header

Change-Id: I4da6dd19f9d8302a76652a3686a9377f9a2503a6
2018-06-25 12:59:38 +03:00
Sorin Sbarnea e5e7a097b1
Adopt use of pre-commit hooks
- rename pep8 target to more generic linters
- migrates flake8 execution to pre-commit
- adds yaml linting
- hardening flake8 rules
- setting max-line-lengh to 120 instead of ignoring it.
- bumped minimal sphinx version
- configured sphinx with warnings as errors

Change-Id: I4c598c07297ae6a2160ba6754cec860adbfeb6f2
Signed-off-by: Sorin Sbarnea <>
2018-06-22 13:37:30 +01:00
Nickolas Pohilets f7fa4ce059
Adds support for executing Groovy scripts on jenkins nodes
Change-Id: I4c9d266073c3ba2a85f2c58a44afc2f041bf37f1
Signed-off-by: Sorin Sbarnea <>
2018-06-17 19:15:13 +01:00
Jan Priessnitz 44d211b90f
Allow use of unicode job names
Closes bug: #1713481
Signed-off-by: Jan Priessnitz <>

Change-Id: I8a1ff4bf0f7711ab9c9b76f538411a854244283c
2018-06-17 15:28:46 +01:00
Zuul 2df5f638d1 Merge "fix tox python3 overrides" 2018-06-17 10:35:10 +00:00
Zuul 1c4870c20b Merge "Update URLS that require depth or tree filters" 2018-06-16 21:29:43 +00:00
Zuul fdfbdedc0a Merge "Added pypy-dev to bindep.txt" 2018-06-16 21:02:58 +00:00
Sorin Sbarnea 20fd8c40cf
Added pypy-dev to bindep.txt
Fixes failure to install some packages on pypy
due to missing python headers.

Change-Id: I4d693e3119bfcf5db4999b640c030f9389e53d27
2018-06-16 21:17:34 +01:00
Thanh Ha 7ffb27c7d5
Fix run_scripts() API
Resolve regression caused by I5369a0d35be4bf8b3b197a51e60aba21b5742cc7
preventing run_scripts() from successfully running against the remote
Jenkins instance.

Switching data to a dictionary and passing the script string without
quote() appears to allow the script to successfully run.

Add a magic string ')]}.' as an indicator of if the groovy script
successfully passed or failed. In theory if the groovy script failed
perhaps due to syntax error or some other reason the magic string
will not be printed and we can assume failure.

Change-Id: Ibaffb768ea82c76b44ec5a6cccde8563afe1783f
Signed-off-by: Thanh Ha <>
2018-06-15 11:37:46 -04:00