opendev/gerrit
Code Issues Proposed changes

Plugins#ListRequest: Remove parameter from all() method

Browse Source 
The default value of all is false. Change the method so that
calling it sets it to true, so instead of:

  api.list().all(true).get()

the call is:

  api.list().all().get()

Change-Id: I8ea0a81c5ef3f7074566ef916b3a843277749e7f
This commit is contained in:
David Pursehouse
2017-07-27 15:08:24 +01:00
parent 4b0eeb1e3e
commit 03eb9d06e5
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/api/plugin/PluginIT.java
View File

@@ -23,7 +23,8 @@ import org.junit.Test;
@NoHttpd
public class PluginIT extends AbstractDaemonTest {
@Test
public void noPlugins() throws Exception {
public void list() throws Exception {
assertThat(gApi.plugins().list().get()).isEmpty();
assertThat(gApi.plugins().list().all().get()).isEmpty();
}
}

4
gerrit-extension-api/src/main/java/com/google/gerrit/extensions/api/plugins/Plugins.java
View File

@@ -40,8 +40,8 @@ public interface Plugins {
public abstract SortedMap<String, PluginInfo> getAsMap() throws RestApiException;
public ListRequest all(boolean all) {
this.all = all;
public ListRequest all() {
this.all = true;
return this;
}