opendev/gerrit
Code Issues Proposed changes

Merge "Fix manual transpilation error"

Browse Source
This commit is contained in:
Wyatt Allen
2017-05-26 22:04:29 +00:00
committed by Gerrit Code Review
parent 180a8f5795 caa93d2e16
commit 1cf01b0744
2 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.js
View File

@@ -481,7 +481,7 @@
document.documentElement.scrollTop =
document.body.scrollTop = this.viewState.scrollTop;
} else {
this._maybeScrollToMessage();
this._maybeScrollToMessage(window.location.hash);
}
}, 1);
});
@@ -513,10 +513,9 @@
this.viewState.numFilesShown = numFilesShown;
},
_maybeScrollToMessage() {
_maybeScrollToMessage(hash) {
const msgPrefix = '#message-';
const hash = window.location.hash;
if (hash.startsWith(msgPrefix) === 0) {
if (hash.startsWith(msgPrefix)) {
this.$.messageList.scrollToMessage(hash.substr(msgPrefix.length));
}
},

14
polygerrit-ui/app/elements/change/gr-change-view/gr-change-view_test.html
View File

@@ -1320,5 +1320,19 @@ limitations under the License.
'header wip');
});
});
test('_maybeScrollToMessage', () => {
const scrollStub = sandbox.stub(element.$.messageList, 'scrollToMessage');
element._maybeScrollToMessage('');
assert.isFalse(scrollStub.called);
element._maybeScrollToMessage('message');
assert.isFalse(scrollStub.called);
element._maybeScrollToMessage('#message-TEST');
assert.isTrue(scrollStub.called);
assert.equal(scrollStub.lastCall.args[0], 'TEST');
});
});
</script>