opendev/gerrit
Code Issues Proposed changes

Exclude WIP changes from changes needing review

Browse Source 
Since change I16b303e6e, WIP changes appear in 'Assigned reviews'
dashboard categories and may appear as needing review.

WIP changes should not appear as needing review.

Bug: Issue 10155
Change-Id: I93f613ede8a4dd5f38b09c1cb6d7a931c165e629
This commit is contained in:
Réda Housni Alaoui
2019-02-09 19:53:05 +01:00
committed by Réda Housni Alaoui
parent 5c4bea21ef
commit 3d7531d22f
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list.js
View File

@@ -226,6 +226,7 @@
_computeItemNeedsReview(account, change, showReviewedState) {
return showReviewedState && !change.reviewed &&
!change.work_in_progress &&
this.changeIsOpen(change.status) &&
(!account || account._account_id != change.owner._account_id);
},

14
polygerrit-ui/app/elements/change-list/gr-change-list/gr-change-list_test.html
View File

@@ -231,11 +231,17 @@ limitations under the License.
status: 'ABANDONED',
owner: {_account_id: 0},
},
{
_number: 4,
status: 'NEW',
work_in_progress: true,
owner: {_account_id: 0},
},
];
flushAsynchronousOperations();
let elementItems = Polymer.dom(element.root).querySelectorAll(
'gr-change-list-item');
assert.equal(elementItems.length, 4);
assert.equal(elementItems.length, 5);
for (let i = 0; i < elementItems.length; i++) {
assert.isFalse(elementItems[i].hasAttribute('needs-review'));
}
@@ -243,20 +249,22 @@ limitations under the License.
element.showReviewedState = true;
elementItems = Polymer.dom(element.root).querySelectorAll(
'gr-change-list-item');
assert.equal(elementItems.length, 4);
assert.equal(elementItems.length, 5);
assert.isFalse(elementItems[0].hasAttribute('needs-review'));
assert.isTrue(elementItems[1].hasAttribute('needs-review'));
assert.isFalse(elementItems[2].hasAttribute('needs-review'));
assert.isFalse(elementItems[3].hasAttribute('needs-review'));
assert.isFalse(elementItems[4].hasAttribute('needs-review'));
element.account = {_account_id: 42};
elementItems = Polymer.dom(element.root).querySelectorAll(
'gr-change-list-item');
assert.equal(elementItems.length, 4);
assert.equal(elementItems.length, 5);
assert.isFalse(elementItems[0].hasAttribute('needs-review'));
assert.isTrue(elementItems[1].hasAttribute('needs-review'));
assert.isFalse(elementItems[2].hasAttribute('needs-review'));
assert.isFalse(elementItems[3].hasAttribute('needs-review'));
assert.isFalse(elementItems[4].hasAttribute('needs-review'));
});
test('no changes', () => {