opendev/gerrit
Code Issues Proposed changes

Buck: Simplify build rules

Browse Source 
Since [1] dependencies to targets used in $(location //path/to:target)
macro are added implicitly.

This can be verified by using Bucks audit and targets commands:

  $ buck targets --json api
  [...]
  "buck.type" : "genrule",
  "name" : "api",
  "deps" : [ ],
  [...]

So explicit dependencies are empty, but implicit dependencies are still
present:

  $ buck audit dependencies api
  //gerrit-extension-api:extension-api
  //gerrit-extension-api:extension-api-javadoc
  //gerrit-extension-api:extension-api-src
  //gerrit-plugin-api:plugin-api
  //gerrit-plugin-api:plugin-api-javadoc
  //gerrit-plugin-api:plugin-api-src
  //gerrit-plugin-gwtui:gwtui-api
  //gerrit-plugin-gwtui:gwtui-api-javadoc
  //gerrit-plugin-gwtui:gwtui-api-src

[1] https://github.com/facebook/buck/issues/128

Change-Id: I6c8ddb40ef95ee45f6b6605e74381d55524229af
This commit is contained in:
David Ostrovsky 2015-06-17 21:40:08 +02:00
parent 44c7e61601
commit ce76802d5c
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
BUCK
View File

@ -26,7 +26,6 @@ genrule(
['cd $TMP'] +
['ln -s $(location %s) .' % n for n in API_DEPS] +
['zip -q0 $OUT *']),
deps = API_DEPS,
out = 'api.zip',
)