opendev/gerrit
Code Issues Proposed changes

SshCommandsIT: Use immutable type for constant field declarations

Browse Source 
ErrorProne warns [1] that constant field declarations should use the
immutable type (such as ImmutableList) instead of the general collection
interface type (such as List).

[1] http://errorprone.info/bugpattern/MutableConstantField

Change-Id: If42c500891ea0eb90e753620b6c1e251336217e1
This commit is contained in:
David Pursehouse
2018-08-28 16:42:08 +09:00
parent 2ce1515917
commit d0bdeca698
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gerrit-acceptance-tests/src/test/java/com/google/gerrit/acceptance/ssh/SshCommandsIT.java
View File

@@ -26,7 +26,6 @@ import com.google.gerrit.acceptance.UseSsh;
import com.google.gerrit.common.data.GlobalCapability;
import com.google.gerrit.sshd.Commands;
import java.util.List;
import java.util.Map;
import org.junit.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -37,7 +36,7 @@ public class SshCommandsIT extends AbstractDaemonTest {
private static final Logger log = LoggerFactory.getLogger(SshCommandsIT.class);
// TODO: It would be better to dynamically generate this list
private static final Map<String, List<String>> COMMANDS =
private static final ImmutableMap<String, List<String>> COMMANDS =
ImmutableMap.of(
Commands.ROOT,
ImmutableList.of(