Introduce the CUSTOM_PLUGINS_TEST_DEPS in tools/bzl/plugins.bzl
that allow plugin with external test dependencies to be listed.
That way Eclipse classpath generation process can consider these
dependencies.
Because the plugin's own test rule need these dependencies, it
should expose java_library rule called: <plugin>__plugin_test_deps:
java_library(
name = "high-availability__plugin_test_deps",
visibility = ["//visibility:public"],
exports = [
"@byte-buddy//jar",
"@mockito//jar",
"@objenesis//jar",
"@wiremock//jar",
],
)
and re-use this rule in junit_tests rule, e.g.:
junit_tests(
name = "high_availability_tests",
[...]
deps = [
[...]
":high-availability__plugin_test_deps",
]
)
Bug: Issue 6351
Change-Id: I55b402fa6edb9f2506a91451d70e68d44d1a7762
Set the DefaultPermissionBackend as default binding and leave
the door opened to rebinding it.
Allow alternative backend implementations provided via libModules.
Change-Id: Ifebc666cb9309e34ced0c653a1646d279923d18d
As an attempt to handle scrolling, gr-fixed-panel detaches when floating
on page scrolling.
It appeared that this was causing page to relayout and cause more visual
issues than when "floating" during resize.
Change-Id: Ibdd840e8d3ee588f0ce78f1149b893f6d81c1b69
This change adds support for a new change identifier in the /changes
REST API endpoint. It follows the discussion on
Idac92e61ee1471b074034eef39901b1b8e961706 and the two recent Gerrit
Hackathons.
The new change identifier serves multiple purposes:
1) Since it contains the project name, we can directly construct the
ChangeApi without a secondary index lookup. This means that we can
still serve requests to some endpoints, even in case of a complete
index failure.
When the project is added in the UI, we will still be able to serve
change pages in case of an index failure. While the triplet also
contains the project, it is unfeasible for the UI since it requires a
branch name (which we don't want to have in the UI URLs) and has the
changeId instead of the change number.
2) Reducing the number of secondary index lookups is a performance gain.
3) The project name being contained in the URL enables load balancers
to shard requests based on the project without a need for an index
lookup (which most load balancers do not support). The sharding
configuration can then be as easy as a regular expression and a
static project-to-machine mapping.
4) This change is also a first step in deprecating the other three
change identifiers and unifying our API access pattern. This will
happen gradually in upcoming changes. Also the UI will be adapted.
This change also adds extensive testing to both the new parsing logic as
well as all change identifiers in both the Java and the REST API.
Change-Id: I7a904fdd001c065af9897d9c08edce1cfbd43a14
Instead of:
assertThat(a.isPresent()).isTrue();
assertThat(b.isPresent()).isFalse();
with Truth8 we can do:
assertThat(a).isPresent();
assertThat(b).isEmpty();
Change-Id: Id8578ea1a0b67378dd2761e4181f276c4a0146c0
This change adds a test to delete one comment multiple times,
which ensures that the same comment and the same commit can be
rewritten multiple times correctly.
This change also refines the DeleteCommentRewriter.
Change-Id: I8ab171d0f0e8ca5b07692b9a662280bf01ef8d68
Reference types that declare an equals() method, or that
inherit equals() from a type other than Object, should
always compare for value equality with .equals().
Change-Id: I8dd924603d84eb930b6dab3fc5d0b3afbf102dce
This change includes tests for the new API which increases the test
coverage for GetCommit from 25% to 94%.
Change-Id: I19457b47bc92f846446a2fc7d3a9127aeaae476d
Signed-off-by: Edwin Kempin <ekempin@google.com>
When you create an account with no name it is very hard to go to
settings to change the name as the dropdown will be hidden. Lets do
what gwtui does and provide a fake name so that dropdown works.
Change-Id: I7a6cb6fadff6e12f02611af4020781eb7191e0f6
* stable-2.14:
PolyGerrit: Update docs on install nodejs 6
Don't fail in loadJARs when there are no jar files to load
Fix build failure with Bazel 0.5rc3.
Change-Id: I466935303024a33ea3d1ac4084b2b75f55450bea
The loadJARs method throws an exception if the class loader which
needs to be extended is not an URLClassLoader. However, there is
no reason to fail when there are not jars to load.
Change-Id: I263384af81e7af1e2e8d8e0a3aee428f029c9d35
(cherry picked from commit 027764a06cd2fd386909a5cd7b4b9d3c135fa94e)
This allow every other link appart from gitiles and gitweb to work.
This fixes it so gerrit-review should now work with links on the project
list.
Change-Id: I451aa352c80c59298f7373f7a6e9d04d53a5c398
Diff header scrolls with content and sticks to the top, too.
Doesn't scroll the footer horizontally with the header.
Bug: Issue 4491
Change-Id: I5d76aad38a7ae76c15528abcb572cf993f7f595e
On Latin American keyboards, the square bracket cannot be typed without
a modifier. An added check to exit if modifiers are pressed meant that
the shortcut could thus not be used on these keyboards.
Instead, check only for the meta key to avoid overriding native Chrome
shortcuts in OSX.
Bug: Issue 6217
Change-Id: Ia737c4c411b73b2ba42fe5f33fff5082c488a5fb
2px of padding in iron-autogrow-textarea on the native textarea added an
unwanted scroll bar when content was taller than the original textarea.
Add 2px of padding on the iron-autogrow textarea in gr-textearea so that
the scrollbar does not appear.
http://imgur.com/a/5hMz9
Change-Id: I3a112af1859a4a9c0f8dc7febf6d11e418cd92a2
Previously, the logic assumed that the API request would fetch all
projects, not just the current page. In order to properly display the
next button, modify the API request to ask for one result than wanted,
but only display the original number desired. If the full amount + 1 is
returned, there should be a next button.
Change-Id: I67c6fb9cd6009220a1d9ac24fe4506bd6383428e
both method assertThat(Iterable<?>) in Truth and method <T>assertThat(T) in Truth match
where T is a type-variable:
T extends Comparable<?> declared in method <T>assertThat(T)
Change-Id: I8a938ace1917d867efd59c6e43ecaf8a7998dafc
(cherry picked from commit cb074f917f1d614681f92fcf26456c17c8da864e)
