As an attempt to handle scrolling, gr-fixed-panel detaches when floating
on page scrolling.
It appeared that this was causing page to relayout and cause more visual
issues than when "floating" during resize.
Change-Id: Ibdd840e8d3ee588f0ce78f1149b893f6d81c1b69
This allow every other link appart from gitiles and gitweb to work.
This fixes it so gerrit-review should now work with links on the project
list.
Change-Id: I451aa352c80c59298f7373f7a6e9d04d53a5c398
Diff header scrolls with content and sticks to the top, too.
Doesn't scroll the footer horizontally with the header.
Bug: Issue 4491
Change-Id: I5d76aad38a7ae76c15528abcb572cf993f7f595e
On Latin American keyboards, the square bracket cannot be typed without
a modifier. An added check to exit if modifiers are pressed meant that
the shortcut could thus not be used on these keyboards.
Instead, check only for the meta key to avoid overriding native Chrome
shortcuts in OSX.
Bug: Issue 6217
Change-Id: Ia737c4c411b73b2ba42fe5f33fff5082c488a5fb
2px of padding in iron-autogrow-textarea on the native textarea added an
unwanted scroll bar when content was taller than the original textarea.
Add 2px of padding on the iron-autogrow textarea in gr-textearea so that
the scrollbar does not appear.
http://imgur.com/a/5hMz9
Change-Id: I3a112af1859a4a9c0f8dc7febf6d11e418cd92a2
Previously, the logic assumed that the API request would fetch all
projects, not just the current page. In order to properly display the
next button, modify the API request to ask for one result than wanted,
but only display the original number desired. If the full amount + 1 is
returned, there should be a next button.
Change-Id: I67c6fb9cd6009220a1d9ac24fe4506bd6383428e
Previously, polylint_test.sh used the local copies of bower components
that the PolyGerrit project has in its repo to do local development for
testing. This was causing an issue, as these were not found on the CI
system.
This makes the test take longer, but makes it standalone enough to
function on CI.
Change-Id: I21f3ed67ade1af352b2ccf21db6644b2bd1d2fee
1) Escape key for non moveToRoot elements did not close it (ex search
bar). This was fixed. (Yeah, still using hidden.... need to figure
out what to do there more wholistically)
2) Sometimes the dom node tried to be removed twice. Add a check so that
doesn't happen.
Change-Id: Ia88d2a72fa69b10cbfd70658e57e1f96a11c53fc
gr-textarea did not take into account scroll position when positioning
the emoji dropdown. This fixes it by adding scrollTop to non-fixed
position textareas.
Change-Id: I490d03443b4ca910602ab0636f3dfc19957fdd89
This change consists of some minor refactoring of
keyboard-shortcut-behavior.html to allow for its use in elements that
have the behavior. Also fixes some incorrect bower paths that resulted
in flaky and/or failing tests.
Bug: Issue 5109, Issue 6217
Change-Id: I3a73036b2e34372fe1bf4de836e11bb88b1d0e5f
When going to /admin/projects/test for example it will take you back
to the old ui to view the project configs.
Bug: Issue 5966
Change-Id: I7d6fb8f17a235602bba0c535cfe4b43030f515a3
Because the admin section has a lot of form elements, let's generalize
gr-settings-styles to be used for all forms.
Feature: Issue 6275
Change-Id: I3b94e220c5a1413ce702f0bc272d0db307406222
To install the linter:
npm install -g polylint
To run the linter:
bazel test //polygerrit-ui/app:polylint_test
Change-Id: I552f6eedce0e4e90d394acfc516940a8c26e948f
The previous change that set selectionStart in for the Safari fix broke
Firefox. selectionEnd needs to be set too.
Change-Id: I758be746c1b434da268f20440415698f4c62ee28
Adding a separator helps users trace file names across to the file
stats, and helps indicate that the file list has similar behaviors to
the change-list-view.
Bug: Issue 6065
Change-Id: Id8934867e2133daae3385493267c271c84e23a9a
Users of the CC entry in the reply dialog expect a GMail-like workflow
in which a text entry that had not been submitted via the autocomplete
would still be added as a CC entry.
With this change, text values in the CC field are submitted as entries
when 'Send' or 'Save' is pressed. If the entry is an invalid email, the
standard toast is shown and the action is blocked.
Also adds an integration test suite for the reply-dialog with all
relevant test boilerplate copied from the standard reply-dialog_test
suite.
Bug: Issue 6194
Change-Id: I1e7aa97b1847ea2409136dfdc7e9f760e22cdbf5
In Safari, when 'text' was set, the textarea's selectionStart property
was not updated. This mimicks where the cursor would be after typing
text. In this change, selectionStart is updated every time 'text' is set
to be at the spot it should be if the user were simply typing.
Change-Id: I840c1818d2123890c419ac2dd37441a40472081e
