opendev/gerrit
Code Issues Proposed changes
25,156 Commits 1 Branch 360 Tags
7580853b58
Commit Graph

2068 Commits

Author SHA1 Message Date
Becky Siegel
f19de33fa3 Add gr-autocomplete-dropdown element 
gr-autocomplete-dropdown is a special element.
- It has a fixed position, which can be set by its parent element.
- When it is opened, the element is moved inside the body tag, because
  in cases like gr-diff-comments, fixed position was not based on the
  entire viewport, so it could not be positioned correctly, and got cut
  off when at the bottom of the page.
- The reference to the element remains intact, so the parent can control
  it even after it has been moved to the body.

The next change will introduce an element that utilizes this dropdown.

Change-Id: I433f1c1c14f1472bf2567207a4cb60fa796da760
 2017-05-15 12:06:17 -07:00
Kasper Nilsson
f1a02e9d02 Merge "ES6ify /gr-main-header/*" 2017-05-15 18:48:40 +00:00
Kasper Nilsson
c80414fd86 ES6ify /base-url-behavior/* 
Bug: Issue 6179
Change-Id: I07b643f04531673a04f62f138782dc4b7b9cb8c1
 2017-05-15 18:47:11 +00:00
Kasper Nilsson
adff87e06e Give gr-account-list a max height and overflow in reply-dialog 
Bug: Issue 6217
Change-Id: I889f198cfefd3064092bd41546c21e972f63c957
 2017-05-15 11:44:53 -07:00
Logan Hanks
75f7ec5467 Ignore right click on selection action box 
Ignore any mousedown that doesn't indicate the main button was applied.

Bug: Issue 6207
Change-Id: I8ed2a1c314f9ef161fe31b29a6481dba1fb4390a
 2017-05-15 11:42:55 -07:00
Kasper Nilsson
9be2dfcb03 ES6ify /gr-change-list/* 
Bug: Issue 6179
Change-Id: I64a60c6363786eed7ffae23ccc60bf4e6ed0a0d5
 2017-05-15 11:01:03 -07:00
Wyatt Allen
803ede79be Merge "gr-download-dialog.js: Use strict equality comparison" 2017-05-15 17:50:49 +00:00
Kasper Nilsson
178d4f8eb1 ES6ify /gr-change-list-item/* 
Bug: Issue 6179
Change-Id: I6b45fbd503409d2019ea624d258891e670e11bc3
 2017-05-15 17:43:12 +00:00
Kasper Nilsson
0e70c7cbc9 ES6ify /gr-main-header/* 
Bug: Issue 6179
Change-Id: Ibe71d6e56af6c222b0c19b79344397dfc287593f
 2017-05-15 10:41:39 -07:00
Wyatt Allen
43f09aeb5c Merge "ES6ify /scripts/util.js" 2017-05-15 17:40:52 +00:00
Wyatt Allen
fa2f6bfffe Merge "ES6ify /gr-account-list/*" 2017-05-15 17:39:21 +00:00
Becky Siegel
7662a2b17c Merge "es6ify gr-review-list" 2017-05-15 17:35:54 +00:00
Logan Hanks
7fefcd5d73 Merge "Set metadata's gr-external-style element to display: block" 2017-05-15 17:35:43 +00:00
Wyatt Allen
50ea9c552d Merge "ES6ify /gr-change-list-view/*" 2017-05-15 17:30:06 +00:00
Wyatt Allen
5646448e28 Merge "ES6ify /gr-dashboard-view/*" 2017-05-15 17:24:17 +00:00
Wyatt Allen
eb10b35170 Merge "ES6ify gr-app" 2017-05-15 17:16:17 +00:00
Wyatt Allen
f34c5c864d Merge "ES6ify /gr-keyboard-shortcuts-dialog/*" 2017-05-15 17:12:24 +00:00
Wyatt Allen
ad11689c5e Merge "ES6ify /gr-account-dropdown/*" 2017-05-15 17:11:38 +00:00
Wyatt Allen
122fec2448 Set metadata's gr-external-style element to display: block 
The external style element defaulted to `inline`. In cases where the
linked glitch occurs, forcing it to use `block` fixes the layout.
However, resetting the element to inline does not reproduce the glitch.

Since the external style contains table-row elements, `display: inline`
is certainly inappropriate, so hopefully this will prevent the layout
glitch overall.

Bug: Issue 6180
Change-Id: Ieb44b50f2b026a80e074eaf157023a263d452bca
 2017-05-15 10:00:46 -07:00
Kasper Nilsson
264f2f422b ES6ify /scripts/util.js 
Bug: Issue 6179
Change-Id: Icc3a146dd50a9444b386212ff994203b2012e27b
 2017-05-15 16:53:33 +00:00
Becky Siegel
7442a115d9 es6ify gr-review-list 
Change-Id: If5016ffcacf823af7f58acaabb705f6e3ef5d329
 2017-05-15 09:53:08 -07:00
Wyatt Allen
b5e44d8cd2 Fix custom event to recompute diff cursor stops on context show 
Bug: Issue 6188
Change-Id: If038b2e7dc9c070e69eb5264a94ea707f4847c46
 2017-05-15 09:12:45 -07:00
Kasper Nilsson
f6e4603689 ES6ify /test/* 
Bug: Issue 6179
Change-Id: Ie52532cd0687cda8f2641c3ca8fb4d0c4149ad16
 2017-05-14 18:14:32 -07:00
Kasper Nilsson
50e9023658 ES6ify /gr-url-encoding-behavior/* 
Bug: Issue 6179
Change-Id: I52761e224602ccd53da781de7633f0447ff8b2b3
 2017-05-14 18:11:29 -07:00
Kasper Nilsson
8ab1f50252 ES6ify /rest-client-behavior/* 
Bug: Issue 6179
Change-Id: I24a9b069c2653e130cecc23edea16d67d7fbcb7f
 2017-05-14 18:10:42 -07:00
Kasper Nilsson
3a40171bc1 ES6ify /keyboard-shortcut-behavior/* 
Bug: Issue 6179
Change-Id: I17c4281ed269fe5d812c13e2db59645217e42bb9
 2017-05-14 18:08:47 -07:00
Kasper Nilsson
04a74c1ea7 ES6ify /gr-tooltip-behavior/* 
Bug: Issue 6179
Change-Id: I6fcdab8736e92d3921bcb61070e1bb56d4b04322
 2017-05-14 18:08:07 -07:00
Kasper Nilsson
0ed5b0de14 ES6ify /gr-path-list-behavior/* 
Bug: Issue 6179
Change-Id: Ia910baa88ab5776bc0f00be51c2ed7a316c84b61
 2017-05-14 18:07:11 -07:00
Kasper Nilsson
59fe9d6515 ES6ify /gr-patch-set-behavior/* 
Bug: Issue 6179
Change-Id: Id6fc906bbc7445123ef99707fd1c6892b627e842
 2017-05-14 18:04:12 -07:00
Kasper Nilsson
8215e498a3 ES6ify /gr-change-table-behavior/* 
Bug: Issue 6179
Change-Id: Ib3ea20a7450afd1752caeffe408e00b0699edf40
 2017-05-14 17:58:48 -07:00
Kasper Nilsson
816d1884c4 ES6ify /gr-dashboard-view/* 
Bug: Issue 6179
Change-Id: I698c3fb6bbd24008686210d3e6ddfd7a522d82b1
 2017-05-14 17:48:58 -07:00
Kasper Nilsson
36c5bf8cc6 ES6ify /gr-change-list-view/* 
Bug: Issue 6179
Change-Id: I9d9d50a53020638e40e77dc94b62031fed0598cb
 2017-05-14 17:48:18 -07:00
Kasper Nilsson
46637bcc4b ES6ify gr-app 
Bug: Issue 6179
Change-Id: I51601a12071f83ac042957510c3ba871344f3a98
 2017-05-14 17:40:46 -07:00
Kasper Nilsson
026d126a0c ES6ify /gr-keyboard-shortcuts-dialog/* 
Bug: Issue 6179
Change-Id: I03053789d900150379523f1b7818c5580c8f4309
 2017-05-14 17:37:56 -07:00
Kasper Nilsson
969311b936 ES6ify /gr-router/* 
Bug: Issue 6179
Change-Id: I7bc9300d46b7294f258689f17dac6b68c74ede8c
 2017-05-14 17:36:30 -07:00
Kasper Nilsson
1720d47442 ES6ify /gr-account-dropdown/* 
Bug: Issue 6179
Change-Id: Ibe19aabeb6cdfe750a01ca2b31beca84f41f265d
 2017-05-14 17:34:34 -07:00
Logan Hanks
d18bf04340 Merge "Fix faulty reviewer removal behavior" 2017-05-13 00:04:29 +00:00
Kasper Nilsson
7591ceb1ec Fix faulty reviewer removal behavior 
WIP mode introduced an issue in which _purgeReviewersPendingRemove was
being called as a callback to send. This is expected, but the order of
the parameters being supplied to the function was incorrect. The return
value of send() is always a truthy value, which was then supplied as the
isCancel param of _purgeReviewersPendingRemove.

Bug: Issue 6048
Change-Id: Ic2d2b825c6a83298095aa8c7f3c458c2eed9d195
 2017-05-12 16:32:21 -07:00
Kasper Nilsson
f7be510b13 ES6ify /gr-account-entry/* 
Bug: Issue 6179
Change-Id: I10bf2e0b7ec2df0b7478cbbc5ef65081b26d845b
 2017-05-12 15:41:33 -07:00
Kasper Nilsson
894031f22d ES6ify /gr-account-list/* 
Bug: Issue 6179
Change-Id: I099fa87f162a09a6eef60dbc64c4dc65c0c334dd
 2017-05-12 15:40:21 -07:00
Becky Siegel
47027bf0a0 Only display first 10 items in gr-reviewer-list 
Once there are more than 10 reviewers/ccs, add link for 'and n more'.
Clicking the link displays all reviewers and hides the link.

Bug: Issue 6196
Change-Id: I398110cc6fba3251af9b52d72d3eff9f3596c63e
 2017-05-12 15:39:50 -07:00
Kasper Nilsson
b4058957f0 ES6ify /gr-autocomplete/* 
Bug: Issue 6179
Change-Id: I02b02272f6abe74c0667edda318fe9030d228c65
 2017-05-12 15:36:18 -07:00
Viktar Donich
ffba657598 Merge "Remove duplicate HTML in change-metadata" 2017-05-12 20:30:50 +00:00
Wyatt Allen
05040d8f1e Merge "Highlight gr-change-list-item on hover" 2017-05-12 20:05:00 +00:00
Becky Siegel
ff30880f1b Merge "Add some useful commands to Polygerrit's readme" 2017-05-12 19:43:35 +00:00
Wyatt Allen
131384a3c3 Merge "Expand (not open) if user prefers inline diffs" 2017-05-12 18:40:20 +00:00
Logan Hanks
dcb8f04012 Highlight gr-change-list-item on hover 
Give the item a light yellow background when hovered, to help line up
label statuses with change descriptions.

Bug: Issue 6130
Change-Id: Ifc2c1693fe627225d1e340bb188af0a7fec8c815
 2017-05-12 11:38:26 -07:00
Kasper Nilsson
b0c8724b0c Remove duplicate HTML in change-metadata 
Change-Id: I1f6b3328bde537aa958352fc8f896ad99a743648
 2017-05-12 18:36:38 +00:00
Kasper Nilsson
2515a1e24f Add some useful commands to Polygerrit's readme 
Change-Id: I5d3a3ff295e329fe818e974f6b72cd84a1877c61
 2017-05-12 11:31:44 -07:00
Viktar Donich
1057e0505f Add padding to diff when scrollbar is inline 
Inline scrollbars are invisible until scrolling starts, or, for
ChromeOS, scrollbar area is hovered.
When scrollbar appears, it overlaps last line of diff.
This change adds a padding to prevent scrollbar overlapping last line of
diff.

Bug: Issue 5964
Change-Id: I072f8e8a4d4d2750f122bc6177b8db492b258f5f
 2017-05-12 11:24:31 -07:00