Allow plugins to contribute messages to the UI during initial page
load. Gerrit displays the messages in a butter bar at the top of
the page and allows users to hide them with the "Dismiss" button.
Messages are hidden per-browser using a cookie named after the
message id, set to expire at a date supplied by the server. After
this date the same message could redisplay if the server sends the
same message again.
Change-Id: I0bcca845f501cbeb8c31356fff398c3adb43099a
It is often convenient to be able to see the files in the same
tree as the file being reviewed. Update the gitweb linker to
support linking to a specific revision and file. Link the base
of the filename to the tree and link the project name to the root
tree.
Change-Id: I11a969e9b1d14ea4180699ae9c02a6a62147d3de
We currently support two styles of parsing, Label-Value and
Label=Value. Consolidate these into a single LabelVote class.
(Unfortunately for backwards-compatibility reasons we can't just
eliminate Label=Value in ReviewCommand.)
Change-Id: I9e5255b184d786226e6b11fe059001608c00673d
The title text shown on the link to the bug tracker can be configured
in the gerrit.config file. If not set, it defaults to "Report Bug".
Bug: Issue 2318
Change-Id: I38c6057b96bf97fc96341621c9d8bbb49060dc40
These warnings are spurious in that the member types are correctly
qualified within the appropriate scope, but Eclipse reports them
to be consistent with javadoc[1], which has a long-standing bug.
Unfortunately, they also cannot be turned off.
For references to common Gerrit key/id types (e.g. Account.Id), just
use @code, as the @link isn't providing much value. For references
where the link might be more useful, use the fully-qualified type.
[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=371420
Change-Id: I0baca75c20e69c51d3bf251aa818460d30e3d631
Convert the new RPC data into the old data, just enough to keep the
old UI alive against a newer server. This will allow us to build a
final version of the old UI code and run it for quite some time
against a modern REST API.
Users who refuse to upgrade to ChangeScreen2 can run this frozen old
UI build until it no longer works.
Change-Id: Ieef15c39e97673f6bcdeb03567fc48ddbd289a6e
Some user groups are intolerant of any sort of new feature or
funcationalty being added to the web interface. Add a server
variable that disables or hides most new functionality.
Change-Id: Ide3a6a5e66cbba9c58575345a4a9ad1da209bb16
These constants moved into the server package, which depends on this
package, so we can no longer import the necessary class for a @link.
Change-Id: I0695a991835a8d83db5b8f40def1e106babdc091
Internal group names are automatically hyperlinked in the access
control editor. This makes it easy to view the members of the group
and determine if access is correctly assigned.
Plugins supplying group systems may include a url to a group
information page. If present use these URLs as hyperlinks in the
access editor, providing the same functionality.
Change-Id: I9605fdc1d43d6705a01ec2b68b083e8678dbc88a
GWT only needs the rebind code for CSS and ServerLinker to be
precompiled as bytecode. Save build time by passing no source
files to the java_library() used by gwt_module().
For a full draft build of ui_safari this cuts the refresh time
down from 32.015s to 26.158s on my MacBook. Saving 6s on each
UI reload adds up during development.
The common annotations need to be provided as bytecode, avoiding
spurious warnings from GWT when there is a Java syntax error.
Change-Id: I37826498650c65c05303e7d4d1177d05781c56f6
Require the secondary index to be enabled in Gerrit 2.9. Unless
configured differently, Lucene is used for the secondary index.
Change-Id: I3d2d804170835d69ffbfef586ddc3873ea3cd1c8
Since:
d4765db81686cb00ee80952201d40ae5ceb4f863
Add REST API to toggle starred change state
ToggleStarRequest is not used anymore.
Change-Id: I1d798541e6a7f9377d4a1b8ad9c2d93d5b4a4f82
If 'changeMerge.test' is set to true Gerrit checks if a change is
mergeable and shows this on the ChangeScreen. If a change is not
mergeable the submit button is hidden. There are two problems with
hiding the submit button:
1. Users get confused why the change cannot be submitted. They are
searching for the submit button and do not understand that they have
to rebase the change. Gerrit administrators are annoyed to answer
questions about this. If trying to submit the change fails there is a
good error message that tells the user that he needs to rebase the
change. This is mostly a problem with the old change screen. On the
new change screen the red "Cannot Merge" and the "Merge Conflict"
status can hardly be overlooked.
2. If a change has a conflict it is possible to resolve the conflict
in a merge commit which is a successor of the conflicting change. If
this merge commit is submitted it is in state 'Submitted, Merge
Pending'. If now the conflicting change is submitted the merge
succeeds. This way of resolving conflicts is not possible if the
submit button is not available on conflicting changes.
Since we are now always showing the submit button (if the approvals
allow submit and the user has the permission to submit) and we are
also always computing the mergeability flag for each open change,
there is no need for the 'changeMerge.test' configuration parameter
anymore. This feature is now enabled by default and the
'changeMerge.test' configuration parameter is removed.
Change-Id: I37e69e67992b3aea153e134a5f21fe76ba7e2b91
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
{@code foo} is shorter and easier to read and write than
<code>foo</code>, which is why it was introduced years ago in the
javadoc processor. Make consistent use of it throughout the
documentation comments.
Change-Id: I59d428cb6c5015453629398b0697891b83c8e91d
2d2a3c405e5472f27b96484b068f51c34ee5e6cb added diff against to the change
screen2. However base revision is lost when side by side view is closed.
This change fixes that.
Change-Id: I7f74760fde96469a60556f657923a3936d6516c7
Add a new column to change tables and user dashboards in which the
size of a change is visualized by a colored bar. For small changes a
short green bar is shown, for medium sized changes a middle sized
yellow bar is shown and large changes have a full red bar.
Visualizing the change sizes gives a hint to the reviewers about how
complex a change is and how long it will take to review it.
For contributors the visualization of the change size may be a
motivation to split large changes into smaller pieces which will speed
up the review process.
How many changed lines are considered as a large change is
configurable.
Change-Id: I88497b8aea00047d93ad7d079eecc5e1052187d2
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This tab makes use of the 'conflicts' operator which is only supported
if a secondary index is enabled.
Change-Id: I25cc023e10f10a80efce12c1a3e62a65cb8940f3
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Topic names may contain whitespace. This is why
we need to quote the topic name in the query.
Change-Id: I0ce6a8ca57cec987ddeeaeed71cee757dcb9d17b
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This method is not invoked by any UI code. Drop the method.
/accounts/self/preferences.diff provides the same data on
a supported REST API.
Change-Id: If88d8449f48e898fc84fdabad19341bd8063a737
At the moment log4j configuration is a bit inconsistent: it is
possible to configure error_log and gc_log using file provided
with log4j.configuration system property, however httpd_log and
sshd_log configuration is hard-coded in corresponding classes
(HttpLog and SshLog).
Make logs configuration more consistent by using log4j for all
logs. If log4j.configuration variable is not set, log behavior
remains intact and code-level log configuration will be used.
In case of log4.configuration points to log4j.properties file the
hard-coded configuration will be ommited and log4j.properties will
be used instead.
In addition shouldConfigureLogSystem() call moved from ErrorLogFile
to LogUtil in com.google.gerrit.util package and removed deprecated
reference to log4j LogManager.DEFAULT_CONFIGURATION_KEY so that
gerrit common does not require log4j.
Two inner MyLayout classes (one from SshLog and one from HttpLog)
have been extracted to separate files and renamed accordingly to
enable to use them from log4j.properties file if required. At the
moment those are extracted as is - refactoring will follow.
Change-Id: Icb1a3787b98392a9df9bb2afa4dc857f8cfada3a
Signed-off-by: Eryk Szymanski <eryksz@gmail.com>
Project owners can now change HEAD from the ProjectBranchesScreen.
Change-Id: I1394312bd9bdead3c71772ba35fd2e0798c04d44
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
This change adds support for updating the parent project of a child
project from the WebUI. This functionality is offered in the
ProjectAccessScreen. When the access rights are changed the user is
also able to change the parent project (if the user has the needed
privileges, means if he is administrator). When the user saves the
new settings only one RPC to the server is done that updates both the
access rights and the parent project property. Technically both
updates are modifications of the 'project.config' file in the
'refs/meta/config' branch. There will be only one commit for this
file that does both updates.
In the UI only valid parent projects are suggested as new parent
project (all projects that would cause a cycle in the line of parent
projects are not suggested).
Bug: issue 1298
Change-Id: Ic63bdb039ea5057a0551138f8fef9ede280b2be3
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
As on the old change screen the project link should link to the
project administration page and there should be a query icon to search
for changes on the project. Clicking on the query icon opens the
default dashboard of the project or if no default dashboard is defined
it queries for the open changes of the project.
This behaviour is consistent with the old change screen so that users
don't get confused.
Bug: issue 2075
Change-Id: I62f87466b60896ecb046e6053f8361405a5c4285
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
The download commands are returned as part of the FetchInfo of a
revision, but only if the download commands are requested by setting
the option DOWNLOAD_COMMANDS.
This allows to completely customize the download commands on a Gerrit
installation.
This change only effects the download commands that are shown on
ChangeScreen2.
For non-anonymous download commands the username is now again included
into the displayed download commands. Also the HTTP scheme and the
Anonymous HTTP scheme can be used at the same time.
With this change the patch download (base64 & zipped) is still
hard-coded in Gerrit core and does not come from a plugin.
Bug: issue 2116
Change-Id: I8fb21fdeb1a98548ce9027655e1b5e467ee2d27e
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Gerrit composes the viewer URL using information
about the project, branch, file or commit of the
target object to be displayed.
Context:
Typically viewers such as CGit and GitWeb do need
those parts to be encoded, including the '/' in
project names, for being correctly parsed.
However other viewers could instead require
unencoded URL (e.g. GitHub web based viewer).
This patch allows to disable the URL encoding for
allowing GitHub to be used as "gitweb custom viewer"
on top of Gerrit.
Example of GitHub configured as viewer:
[gitweb]
type = custom
url = https://github.com/
project = ${project}
revision = ${project}/commit/${commit}
branch = ${project}/tree/${branch}
fileHistory = ${project}/blog/${branch}/${file}
linkName = GitHub
urlEncode = false
Change-Id: Ief59de7eb19def60c5e765c4a495bcac00384d83
It can now be configured that all scores for a label are copied
forward when a new patch set is uploaded that has the same parent
commit as the previous patch set and the same code delta as the
previous patch set. This means only the commit message is different.
This can be used to enable sticky approvals on labels that only
depend on the code, reducing turn-around if only the commit message
is changed prior to submitting a change.
E.g. this configuration could be used for the Verified category if
it is only used by an automated tool to express that build and tests
succeed.
Change-Id: I105f85bd28d0bea39a4e16aaebf2630ef1860fbe
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
