opendev/gerrit
Code Issues Proposed changes
Files
b3e8cb0d25cd99725ebe35af084975b9b156341c
gerrit/Documentation
History
David Pursehouse f4bc2568e9 Fix abandonIfMergeable when indexMergeable is disabled 
When changeCleanup.abandonIfMergeable is set to false, the auto abandon
implementation adds "-is:mergeable" to the query that is used to find
changes to be abandoned. When index.change.indexMergeable is disabled,
this causes the query to fail and no changes get auto abandoned.

Fix the ChangeCleanupConfig to disregard abandonIfMergeable when the
indexMergeable is disabled, and log a warning message that the setting
is ineffective.

Extend the documentation of changeCleanup.abandonIfMergeable to mention
this case.

Add test coverage.

Change-Id: Iafe1ef8637deed30b41c48a9f64f199793992870
2019-12-04 10:02:50 +09:00
..
images
Rewrite Inline Edit to describe new UI.
2018-08-28 14:39:15 -07:00
.gitignore
Ignore /Documentation/*.html
2015-05-06 11:25:51 -07:00
access-control.txt
RefAdvertisementIT: Test granting READ to refs/tags/*
2019-06-03 10:48:40 -06:00
BUILD
Documentation: check in (js_)licenses.txt
2019-03-28 15:45:58 +00:00
check_licenses_test.sh
Bazel: Fix update instruction for license file
2019-10-11 19:29:40 +02:00
cmd-apropos.txt
Documentation: Also consider the use of kerberos authentication over SSH
2017-08-28 01:44:52 +02:00
cmd-ban-commit.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-cherry-pick.txt
Fix formatting of example blocks
2016-07-07 14:06:31 +02:00
cmd-close-connection.txt
Add a period to the end of description sentence
2018-09-24 09:33:48 -07:00
cmd-create-account.txt
Remove spaces in front of example
2018-09-24 09:38:45 -07:00
cmd-create-branch.txt
Clean up syntax of cmd-create-branch.txt
2018-09-24 18:36:21 +00:00
cmd-create-group.txt
Clean up syntax of cmd-create-group.txt
2018-09-24 23:07:27 +00:00
cmd-create-project.txt
Move docs about "submit type" to "config-project-config.txt"
2019-01-17 08:36:21 +00:00
cmd-flush-caches.txt
Update most documentation for NoteDb
2019-01-11 14:44:23 -08:00
cmd-gc.txt
Clean up syntax of cmd-gc.txt
2018-09-24 23:07:53 +00:00
cmd-hook-commit-msg.txt
Clean up syntax of cmd-hook-commit-msg.txt
2018-09-24 23:08:14 +00:00
cmd-index-activate.txt
Clean up syntax of cmd-index-activate.txt
2018-09-24 21:28:19 -07:00
cmd-index-changes-in-project.txt
Clean up syntax of cmd-index-changes-in-project.txt
2018-09-24 21:30:48 -07:00
cmd-index-changes.txt
Clean up syntax for cmd-index-changes.txt
2018-09-24 21:33:42 -07:00
cmd-index-start.txt
Clear up syntax for command reference files
2018-09-26 12:31:46 -07:00
cmd-index.txt
Add ssh command to show current sequence value
2019-11-10 12:00:13 -08:00
cmd-kill.txt
Clear up syntax for command reference files
2018-09-26 12:31:46 -07:00
cmd-logging-ls-level.txt
Clear up syntax for command reference files
2018-09-26 12:31:46 -07:00
cmd-logging-set-level.txt
Clear up syntax for command reference files
2018-09-26 12:31:46 -07:00
cmd-ls-groups.txt
Clear up syntax for command reference files
2018-09-26 12:31:46 -07:00
cmd-ls-members.txt
Clear up syntax for command reference files
2018-09-26 12:31:46 -07:00
cmd-ls-projects.txt
Remove textual references to gwtorm
2019-04-23 06:43:56 -07:00
cmd-ls-user-refs.txt
Update most documentation for NoteDb
2019-01-11 14:44:23 -08:00
cmd-plugin-enable.txt
Clear up syntax for command reference files
2018-09-26 12:31:46 -07:00
cmd-plugin-install.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-plugin-ls.txt
Fix broken synopsis formatting in documentation
2016-07-06 10:54:42 +02:00
cmd-plugin-reload.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-plugin-remove.txt
Block disabling mandatory plugin
2019-05-19 14:28:59 +00:00
cmd-query.txt
Merge "Add a --no-limit option to the ssh and rest query commands"
2019-01-24 17:38:42 +00:00
cmd-receive-pack.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-reload-config.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-rename-group.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-review.txt
Merge branch 'stable-2.16' into stable-3.0
2019-04-19 16:05:40 +09:00
cmd-sequence-set.txt
Add ssh command to set new sequence value
2019-11-11 01:08:18 -08:00
cmd-sequence-show.txt
Add ssh command to set new sequence value
2019-11-11 01:08:18 -08:00
cmd-set-account.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-set-head.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-set-members.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-set-project-parent.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-set-project.txt
Move docs about "submit type" to "config-project-config.txt"
2019-01-17 08:36:21 +00:00
cmd-set-reviewers.txt
Clarify the behaviour of the project parameter in set-reviewers
2019-04-29 13:10:22 +00:00
cmd-show-caches.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-show-connections.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-show-queue.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-stream-events.txt
ReviewerAddedEvent: extend event with 'adder'
2019-11-11 07:06:01 -08:00
cmd-suexec.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-test-submit-rule.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-test-submit-type.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
cmd-version.txt
Clean up remaining command reference files
2018-11-12 19:22:29 +00:00
concept-changes.txt
Merge branch 'stable-2.15'
2018-09-27 16:45:10 +09:00
concept-patch-sets.txt
Add new concept topic, Patch Sets, to documentation
2017-08-09 19:07:02 -07:00
concept-refs-for-namespace.txt
Add new concept topic on refs/for namespace
2017-08-09 19:02:17 -07:00
config-accounts.txt
Rename "slave" to "replica" in documentation and command-line
2019-09-26 23:19:53 +02:00
config-auto-site-initialization.txt
Update auto-site initialization documentation
2019-01-11 14:44:23 -08:00
config-cla.txt
Add project scope feature to contributor-agreement enforcement.
2018-10-17 17:41:53 +00:00
config-gerrit.txt
Fix abandonIfMergeable when indexMergeable is disabled
2019-12-04 10:02:50 +09:00
config-gitweb.txt
Document that gitweb.type must be set
2018-03-16 09:47:32 +09:00
config-groups.txt
Rename "slave" to "replica" in documentation and command-line
2019-09-26 23:19:53 +02:00
config-hooks.txt
Update plugin links in documentation
2018-09-28 16:07:43 +09:00
config-labels.txt
Add copyAnyScore configuration option to label.
2019-10-09 13:16:09 -07:00
config-login-register.txt
Use $GERRIT_SITE var for referencing to gerrit_testsite
2019-05-06 09:32:50 +00:00
config-mail.txt
Merge branch 'stable-2.15' into stable-2.16
2019-05-21 09:15:37 +09:00
config-plugins.txt
Merge branch 'stable-3.1'
2019-10-30 16:03:19 +09:00
config-project-config.txt
Revert "Remove requireChangeId."
2019-07-24 12:48:39 +02:00
config-reverseproxy.txt
Update reverse proxy configuration example for nginx
2015-07-06 01:50:38 +00:00
config-robot-comments.txt
Update robot comments documentation to reflect current behaviour
2019-05-30 04:30:55 +00:00
config-sso.txt
Merge branch 'stable-2.12' into stable-2.13
2018-02-27 11:26:42 +09:00
config-themes.txt
Remove remnants of project-specific themes support
2019-03-02 05:10:44 +00:00
config-validation.txt
Add documentation for CommentValidator interface
2019-07-29 10:52:51 +02:00
dev-bazel.txt
Merge branch 'stable-3.1'
2019-11-22 18:15:29 -05:00
dev-build-plugins.txt
Merge branch 'stable-3.0'
2019-10-17 00:49:52 +09:00
dev-cla.txt
Merge branch 'stable-3.0'
2019-05-22 13:29:46 +09:00
dev-community.txt
Merge "Add link to code of conduct to community index page"
2019-10-10 01:17:24 +00:00
dev-contributing.txt
Merge branch 'stable-2.16' into stable-3.0
2019-09-12 16:57:53 +09:00
dev-core-plugins.txt
Document criteria for core plugins
2019-10-30 01:15:02 +00:00
dev-crafting-changes.txt
Document that public classes/methods should have Javadoc
2019-11-20 09:12:59 +01:00
dev-design-doc-conclusion-template.md
Add meta data blocks for site generation to design doc templates
2019-08-07 11:56:53 +02:00
dev-design-doc-index-template.md
Add meta data blocks for site generation to design doc templates
2019-08-07 11:56:53 +02:00
dev-design-doc-solution-template.md
Rename "slave" to "replica" in documentation and command-line
2019-09-26 23:19:53 +02:00
dev-design-doc-use-cases-template.md
Add meta data blocks for site generation to design doc templates
2019-08-07 11:56:53 +02:00
dev-design-docs.txt
Add a note about mailing design doc to repo-discuss
2019-10-08 12:52:40 +00:00
dev-design.txt
Rename "slave" to "replica" in documentation and command-line
2019-09-26 23:19:53 +02:00
dev-e2e-tests.txt
E2E load tests example scenarios
2019-09-10 16:19:10 +00:00
dev-eclipse.txt
Documentation: Fix links moved to crafting-changes
2019-11-22 15:01:57 -05:00
dev-inspector.txt
Rename "slave" to "replica" in documentation and command-line
2019-09-26 23:19:53 +02:00
dev-intellij.txt
Documentation: Fix links moved to crafting-changes
2019-11-22 15:01:57 -05:00
dev-plugins-lifecycle.txt
Move 'Plugins Source Code Hosting' documentation to an own page
2019-10-04 08:47:30 +02:00
dev-plugins.txt
Merge branch 'stable-3.1'
2019-11-16 00:15:58 -08:00
dev-processes.txt
Start a separate documentation page for core plugins
2019-10-29 12:49:09 +01:00
dev-readme.txt
Start a separate documentation page for core plugins
2019-10-29 12:49:09 +01:00
dev-release-deploy-config.txt
Remove textual references to gwtorm
2019-04-23 06:43:56 -07:00
dev-release-jgit.txt
Provide a diff file to make it easier to deploy JGit snapshot
2016-08-31 11:13:47 +09:00
dev-release-subproject.txt
dev-release-subproject: Add 'performRelease' setting
2018-12-07 16:43:20 +09:00
dev-release.txt
dev-release: Update git tag command to avoid tagging jgit submodule
2019-10-18 19:20:44 +09:00
dev-rest-api.txt
gerrit-server: use hashed passwords for HTTP.
2017-02-28 09:09:33 +01:00
dev-roles.txt
dev-roles: Mention the ESC mailing list
2019-09-21 16:10:07 +09:00
dev-stars.txt
Replace Mute/Unmute by Mark as Reviewed/Unreviewed (Part 3)
2017-10-01 12:38:18 +00:00
dev-starter-projects.txt
Extract starter projects into a separate doc page
2019-04-24 09:59:06 +02:00
error-branch-not-found.txt
…
error-change-closed.txt
…
error-change-upload-blocked.txt
…
error-changeid-above-footer.txt
Reject changes with Change-Id above footer
2019-04-02 22:51:38 -07:00
error-commit-already-exists.txt
…
error-contains-banned-commit.txt
…
error-has-duplicates.txt
Update issue tracker URL in documentation
2018-02-25 23:08:45 +09:00
error-invalid-author.txt
…
error-invalid-changeid-line.txt
…
error-invalid-committer.txt
…
error-messages.txt
Remove obsolete documentation related to pushing to refs/changes/
2019-08-30 20:40:23 +09:00
error-missing-changeid.txt
Reject changes with Change-Id above footer
2019-04-02 22:51:38 -07:00
error-missing-subject.txt
ReceiveCommits: uniformize commit validation error messages.
2019-02-04 10:35:42 +09:00
error-multiple-changeid-lines.txt
ReceiveCommits: uniformize commit validation error messages.
2019-02-04 10:35:42 +09:00
error-no-common-ancestry.txt
…
error-no-new-changes.txt
Clarify documentation of "no new changes" error message
2018-01-26 08:49:52 +09:00
error-non-fast-forward.txt
…
error-not-a-gerrit-administrator.txt
…
error-not-allowed-to-upload-merges.txt
…
error-not-permitted-to-create.txt
…
error-not-signed-off-by.txt
…
error-not-valid-ref.txt
…
error-permission-denied.txt
Documentation: Also consider the use of kerberos authentication over SSH
2017-08-28 01:44:52 +02:00
error-prohibited-by-gerrit.txt
Rename 'Push Annotated/Signed Tag' permission to 'Create Annotated/Signed Tag'
2016-09-08 13:50:04 +09:00
error-project-not-found.txt
…
error-push-fails-due-to-commit-message.txt
…
error-same-change-id-in-multiple-changes.txt
Provide more informative error message for Change-Id conflicts
2016-04-12 14:18:12 +00:00
error-too-many-commits.txt
Add limit to number of commits that ReceiveCommits will validate
2017-08-31 12:19:58 -04:00
error-upload-denied.txt
Fix some legacy-style titles in documentation
2016-07-08 13:45:28 +02:00
index.txt
Link to contribution documentation from main index page
2019-10-04 08:39:58 +02:00
install-j2ee.txt
install-j2ee.txt: Remove references to ReviewDb
2018-12-11 09:58:58 +01:00
install.txt
fix broken download urls
2019-06-21 21:24:41 +00:00
intro-gerrit-walkthrough.txt
Update the intro Gerrit walkthrough with rebase
2019-11-12 01:54:15 +01:00
intro-how-gerrit-works.txt
Fix the display of images in intro-how-gerrit-works.txt
2018-09-18 11:12:35 -07:00
intro-project-owner.txt
Remove remnants of project-specific themes support
2019-03-02 05:10:44 +00:00
intro-quick.txt
Edits to intro-quick.txt and intro-how-gerrit-works.txt
2018-07-20 16:08:55 -07:00
intro-rockstar.txt
Fixing Linux Kernel URL in Why Code Review Doc
2019-03-26 07:39:12 +00:00
intro-user.txt
Document recommendations for making security fixes
2019-09-27 15:37:17 +02:00
js_licenses.txt
Merge branch 'stable-3.0' into stable-3.1
2019-11-26 10:38:16 +09:00
js-api.txt
Remove documentation for unavailable methods and also Gerrit.getCurrentUser
2019-10-08 13:01:34 +02:00
json.txt
Add hashtags to events and query results
2018-07-17 07:08:16 +02:00
licenses.txt
Merge branch 'stable-3.1'
2019-11-26 13:14:34 +09:00
linux-quickstart.txt
Fix documentation for downloading Gerrit
2019-10-11 15:34:27 +02:00
metrics.txt
RetryHelper: Add metric to count number of failures on auto retry
2019-08-21 10:46:15 +02:00
note-db.txt
Merge branch 'stable-2.16' into stable-3.0
2019-11-30 11:24:21 +09:00
pg-plugin-admin-api.txt
Update doc for addMenuLink
2019-10-22 16:58:05 +00:00
pg-plugin-change-metadata-api.txt
Plugin API for label score updates
2018-04-06 15:24:56 -07:00
pg-plugin-dev.txt
Deprecate Gerrit.css() and provide a replacement
2019-08-22 15:53:32 +00:00
pg-plugin-endpoints.txt
Merge branch 'stable-3.0' into stable-3.1
2019-10-30 21:44:40 +09:00
pg-plugin-migration.txt
Merge branch 'stable-2.15'
2018-01-25 01:57:07 +00:00
pg-plugin-repo-api.txt
Rename projects admin interface to repo
2017-12-27 21:40:31 +00:00
pg-plugin-rest-api.txt
Document the getConfig()-method in the plugin's restApi interface
2019-10-25 08:31:53 +09:00
pg-plugin-settings-api.txt
Support for .settingsScreen() plugin API
2018-01-04 15:59:48 -08:00
pg-plugin-style-object.txt
Deprecate Gerrit.css() and provide a replacement
2019-08-22 15:53:32 +00:00
pg-plugin-styles-api.txt
Deprecate Gerrit.css() and provide a replacement
2019-08-22 15:53:32 +00:00
pg-plugin-styling.txt
Replace :root by html in plugin docs
2019-07-08 12:03:16 +00:00
pgm-daemon.txt
Rename "slave" to "replica" in documentation and command-line
2019-09-26 23:19:53 +02:00
pgm-index.txt
Remove gsql SSH command and program
2018-12-10 10:42:14 -08:00
pgm-init.txt
Update most documentation for NoteDb
2019-01-11 14:44:23 -08:00
pgm-LocalUsernamesToLowerCase.txt
Update most documentation for NoteDb
2019-01-11 14:44:23 -08:00
pgm-MigrateAccountPatchReviewDb.txt
Fix account_patch_reviews for mysql
2018-02-15 21:40:22 +00:00
pgm-passwd.txt
Gerrit command line utility to set/update secure.config
2017-01-12 00:25:25 +00:00
pgm-prolog-shell.txt
Add -q option to suppress banner.
2019-04-02 10:14:30 -07:00
pgm-reindex.txt
Remove --dry-run option from reindex command documentation
2016-07-08 15:26:42 +02:00
pgm-rulec.txt
Update most documentation for NoteDb
2019-01-11 14:44:23 -08:00
pgm-SwitchSecureStore.txt
Some more broken synopsis formattings in documentation
2016-07-08 13:47:29 +02:00
project-configuration.txt
Merge branch 'stable-2.15' into stable-2.16
2019-07-16 14:25:48 +09:00
prolog-change-facts.txt
Remove current_user predicates
2018-02-16 14:04:01 +00:00
prolog-cookbook.txt
Prolog Example Unit Tests
2019-04-22 18:01:29 -07:00
quota.txt
Add REST API quota checks
2018-12-04 14:46:51 +01:00
replace_macros.py
Documentation/replace_macros: support --site-search option
2019-03-25 14:09:12 +00:00
rest-api-access.txt
Merge branch 'stable-2.15'
2018-09-12 13:27:01 +09:00
rest-api-accounts.txt
Merge branch 'stable-3.0' into stable-3.1
2019-12-02 10:28:16 +09:00
rest-api-changes.txt
Replace reindexAfterRefUpdate setting with indexMergeable
2019-11-18 16:06:31 -08:00
rest-api-config.txt
Expose index.change.mergeable in ServerInfo
2019-12-03 09:19:37 +01:00
rest-api-documentation.txt
Remove Buck based build
2017-01-23 12:44:58 +00:00
rest-api-groups.txt
ListGroups: Remove deprecated --query option
2019-11-15 15:26:03 -08:00
rest-api-plugins.txt
Block disabling mandatory plugin
2019-05-19 14:28:59 +00:00
rest-api-projects.txt
Merge "Add REST endpoint to batch update label definitions"
2019-11-20 18:58:29 +00:00
rest-api.txt
Add REST API quota checks
2018-12-04 14:46:51 +01:00
user-change-cleanup.txt
Add background job to abandon inactive changes automatically
2015-06-25 07:26:25 +02:00
user-changeid.txt
Discontinue draft workflow
2017-09-30 15:47:14 +02:00
user-dashboards.txt
Add user guide
2015-04-30 14:37:09 +00:00
user-inline-edit.txt
Fix docs referencing incorrect side of edit button
2019-07-31 03:12:49 +00:00
user-named-destinations.txt
Add named destinations support
2015-09-03 10:50:07 -06:00
user-named-queries.txt
Move 'User Refs' docs to the intro-user doc.
2015-09-04 14:55:15 +00:00
user-notify.txt
Add Gerrit-Comment-In-Reply-To footer
2017-11-22 14:23:03 -08:00
user-request-tracing.txt
Support tracing on clone, fetch and ls-refs
2019-10-11 10:41:09 +00:00
user-review-ui.txt
Fix broken sentence in description of unchanged file marker
2018-11-07 09:23:30 +01:00
user-search-accounts.txt
Add account predicate that checks if user can see a certain change
2018-03-25 13:55:14 +01:00
user-search-groups.txt
Add fields for members and subgroups to the group index
2017-09-13 14:57:46 +02:00
user-search-projects.txt
Project index: Add parent predicate
2019-02-02 22:54:33 +00:00
user-search.txt
Expose query submission ID to the user
2019-11-15 09:52:11 +01:00
user-signedoffby.txt
…
user-submodules.txt
Replace "the the" occurences with "the" (wrong repetition)
2018-04-19 09:30:07 +02:00
user-upload.txt
Remove obsolete documentation related to pushing to refs/changes/
2019-08-30 20:40:23 +09:00