opendev/irc-meetings
Code Issues Proposed changes

check_chair: Actually fail if there is a problem.

Browse Source 
If we encounter a problem rather than printing and exiting actually fail.

This will mean that the pep8 tox environment will also fail.

Change-Id: Ife80bc2761fcb075057a17337d2ab63459be2da4
This commit is contained in:
Tony Breeds 2016-09-30 13:18:40 +10:00
parent 48c894e03b
commit a80cd87795
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/check_chair.py
View File

@ -16,6 +16,7 @@ from __future__ import print_function
import argparse import argparse
import re import re
import sys
from yaml2ical import meeting from yaml2ical import meeting
@ -56,11 +57,14 @@ A tool that checks a meeting chair matches the canonical format.
args = parser.parse_args() args = parser.parse_args()
meetings = meeting.load_meetings(args.yaml_dir) meetings = meeting.load_meetings(args.yaml_dir)
return_code = 0
for m in meetings: for m in meetings:
ok, msg = check_chair(m.chair) ok, msg = check_chair(m.chair)
if not ok: if not ok:
return_code = 1
print(m.filefrom) print(m.filefrom)
print(msg.rstrip()) print(msg.rstrip())
return return_code
if __name__ == '__main__': if __name__ == '__main__':
main() sys.exit(main())