opendev
/
statusbot
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(2 comments)

Patch-set: 1
This commit is contained in:
Gerrit User 9311 2021-11-12 10:36:36 +00:00 committed by Gerrit Code Review
parent 7430d4559f
commit 12ca5ae5c8
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
4c31332e23ed49fe9748d97c5a81b3097836aabc
View File

@ -17,6 +17,24 @@
"revId": "4c31332e23ed49fe9748d97c5a81b3097836aabc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3b4fb949_ff9e5711",
"filename": "statusbot/bot.py",
"patchSetId": 1
},
"lineNbr": 563,
"author": {
"id": 9311
},
"writtenOn": "2021-11-12T10:36:36Z",
"side": 0,
"message": "Oops, use_ssl should have been set to True in the else case.",
"parentUuid": "7a017869_b5505c2c",
"revId": "4c31332e23ed49fe9748d97c5a81b3097836aabc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -51,6 +69,24 @@
"parentUuid": "bdce24ca_13ba7e31",
"revId": "4c31332e23ed49fe9748d97c5a81b3097836aabc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f7499183_90f091f9",
"filename": "statusbot/bot.py",
"patchSetId": 1
},
"lineNbr": 570,
"author": {
"id": 9311
},
"writtenOn": "2021-11-12T10:36:36Z",
"side": 0,
"message": "Arg, unfortunately, using `class Bot(SSL, base)` results in\n\n Traceback (most recent call last):\n File \"statusbot/bot.py\", line 612, in \u003cmodule\u003e\n main()\n File \"statusbot/bot.py\", line 597, in main\n _main(args.config)\n File \"statusbot/bot.py\", line 576, in _main\n Bot(channels, nicks, publishers, successlog,\n File \"/lib/python3.8/site-packages/ib3/connection.py\", line 32, in __init__\n super(SSL, self).__init__(*args, **kwargs)\n TypeError: __init__() got an unexpected keyword argument \u0027connect_factory\u0027",
"parentUuid": "b51b9287_9e4c57ac",
"revId": "4c31332e23ed49fe9748d97c5a81b3097836aabc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}