Update patch set 13

Patch Set 13: -Code-Review

(1 comment)

Patch-set: 13
Label: Code-Review=0

c72239914116fde2e4a90bedd1b14b2f263aae47

@@ -297,6 +297,24 @@
       "parentUuid": "e764b1ae_808b7bb0",
       "revId": "c72239914116fde2e4a90bedd1b14b2f263aae47",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "dca8a138_e3765105",
+        "filename": "config_tempest/services/image.py",
+        "patchSetId": 13
+      },
+      "lineNbr": 61,
+      "author": {
+        "id": 9303
+      },
+      "writtenOn": "2022-02-17T11:01:23Z",
+      "side": 1,
+      "message": "\u003e \u003e Thanks, so \"1) import image works a) if glance is configured through multistore configuration, regardless of the amount of storages (one or more) \n\u003e \u003e This is correct\"\n\u003e \u003e \n\u003e \u003e Then at least the commit message should be changed.\"\n\u003e \u003e This is an attempt to populate tempestconf with\n\u003e \u003e multistore feature enabled if and only if multiple\n\u003e \u003e stores are available.\"\n\u003e \u003e \n\u003e \u003e But then, shouldn\u0027t the function be check whether the feature is enabled, and be called differently (_is_multistore_enabled) rather then checking the amount of stores?\n\u003e \n\u003e Agree, As per the commit message I thought the patch is to check if multistore is configured but internally it seems to run import workflow like import images in more than one store or copying existing images in more than one store. I think we should add a note here to explain why we need more than 1 store and set it here if num_stores \u003e 1.\n\n\nScratch my latest comment, I think we should rename this method to \u0027_is_multistore_enabled\u0027 and set the option in tempest.conf based on that.",
+      "parentUuid": "68be3dd3_224cacfd",
+      "revId": "c72239914116fde2e4a90bedd1b14b2f263aae47",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }