openstack/ansible-role-systemd_networkd
Code Issues Proposed changes

Update documentation on role requirements

Browse Source 
In README file we're refferencing plugins repo for installing
config_template from it. However, we're using module from it's
collection.
We're updating documentation along with renaming a-r-r to more common
requirements.yml and adjusting rc file
to drop not required overrides from there.

Change-Id: I2329c2744348a8d704fe36f81e4ad43602c39541
Closes-Bug: #1961621
This commit is contained in:
Dmitriy Rabotyagov 2022-05-13 10:37:29 +02:00 committed by Dmitriy Rabotyagov
parent b0a57049fd
commit 09c629cf52
4 changed files with 15 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
README.md
View File

@ -2,22 +2,20 @@
This Ansible role configures systemd-networkd link, network, and netdev files. This Ansible role configures systemd-networkd link, network, and netdev files.
This role requires the ``openstack-ansible-plugins`` repository to be available This role requires the ``ansible-config_template`` collection to be available
on your local system. The Ansible galaxy resolver will not retrieve this role on your local system.
for you. To get the plugins role in place clone the plugins repository
**before** running this role. To get collection you can use use the ``ansible-galaxy`` command on the
``requirements.yml`` file.. You need to install collection **before**
running this role.
``` bash ``` bash
# git clone https://github.com/openstack/openstack-ansible-plugins /etc/ansible/roles/plugins # ansible-galaxy install -r requirements.yml
``` ```
Release notes for the project can be found at: Release notes for the project can be found at:
https://docs.openstack.org/releasenotes/ansible-role-systemd_networkd https://docs.openstack.org/releasenotes/ansible-role-systemd_networkd
You can also use the ``ansible-galaxy`` command on the ``ansible-role-requirements.yml`` file.
``` bash
# ansible-galaxy install -r ansible-role-requirements.yml
```
---- ----

4
ansible-role-requirements.yaml
View File

@ -1,4 +0,0 @@
- name: "plugins"
src: "https://opendev.org/openstack/openstack-ansible-plugins"
scm: git
version: "master"

13
manual-test.rc
View File

@ -2,21 +2,12 @@ export VIRTUAL_ENV=$(pwd)
export ANSIBLE_HOST_KEY_CHECKING=False export ANSIBLE_HOST_KEY_CHECKING=False
export ANSIBLE_SSH_CONTROL_PATH=/tmp/%%h-%%r export ANSIBLE_SSH_CONTROL_PATH=/tmp/%%h-%%r
# TODO (odyssey4me) These are only here as they are non-standard folder
# names for Ansible 1.9.x. We are using the standard folder names for
# Ansible v2.x. We can remove this when we move to Ansible 2.x.
export ANSIBLE_ACTION_PLUGINS=${HOME}/.ansible/plugins/action
export ANSIBLE_CALLBACK_PLUGINS=${HOME}/.ansible/plugins/callback
export ANSIBLE_FILTER_PLUGINS=${HOME}/.ansible/plugins/filter
export ANSIBLE_LOOKUP_PLUGINS=${HOME}/.ansible/plugins/lookup
# This is required as the default is the current path or a path specified
# in ansible.cfg
export ANSIBLE_LIBRARY=${HOME}/.ansible/plugins/library
# This is required as the default is '/etc/ansible/roles' or a path # This is required as the default is '/etc/ansible/roles' or a path
# specified in ansible.cfg # specified in ansible.cfg
export ANSIBLE_ROLES_PATH=${HOME}/.ansible/roles:$(pwd)/.. export ANSIBLE_ROLES_PATH=${HOME}/.ansible/roles:$(pwd)/..
export ANSIBLE_COLLECTIONS_PATHS="${HOME}/.ansible:$(pwd)/.."
export ANSIBLE_COLLECTIONS_PATH="${HOME}/.ansible:$(pwd)/.."
export ANSIBLE_SSH_ARGS="-o ControlMaster=no \ export ANSIBLE_SSH_ARGS="-o ControlMaster=no \
-o UserKnownHostsFile=/dev/null \ -o UserKnownHostsFile=/dev/null \

5
requirements.yml Normal file
View File

@ -0,0 +1,5 @@
---
collections:
- name: https://opendev.org/openstack/ansible-config_template
version: master
type: git