openstack/bifrost
Code Issues Proposed changes

Re-download checkums on upgrades and updates

Browse Source 
Currently it may happen so that the stable checksum file is new
enough for get_url to skip re-downloading it, resulting in an
upgrade failure.

Also refactor download_ipa_image based on the fact that checksums
are published for all images since Pike.

Change-Id: I6fc0e6bee8e6b7999c198ca7ab631dd3c40eb216
This commit is contained in:
Dmitry Tantsur 2020-09-09 15:57:15 +02:00
parent c7f39356fb
commit 7e8e60f9c1
2 changed files with 40 additions and 78 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

114
playbooks/roles/bifrost-ironic-install/tasks/download_ipa_image.yml
View File

@ -19,45 +19,24 @@
stat: path={{ ipa_kernel }} stat: path={{ ipa_kernel }}
register: test_ipa_kernel_present register: test_ipa_kernel_present
- block: - name: "Download IPA kernel checksum file"
- name: "Download IPA kernel checksum file" get_url:
get_url: url: "{{ ipa_kernel_upstream_checksum_url }}"
url: "{{ ipa_kernel_upstream_checksum_url }}" dest: "{{ ipa_kernel }}.{{ ipa_kernel_upstream_checksum_algo }}"
dest: "{{ ipa_kernel }}.{{ ipa_kernel_upstream_checksum_algo }}" timeout: 300
timeout: 300 force: yes
owner: ironic owner: ironic
group: ironic group: ironic
mode: 0644 mode: 0644
register: ipa_kernel_checksum_result
ignore_errors: yes - name: "Extract IPA kernel checksum"
- debug: command: awk '/{{ ipa_kernel_upstream_url | basename }}/{print $1}' "{{ ipa_kernel }}.{{ ipa_kernel_upstream_checksum_algo }}"
msg: "WARNING!!! {{ ipa_kernel_upstream_checksum_algo }} file not found at {{ ipa_kernel_upstream_checksum_url }}" register: parsed_ipa_kernel_checksum
when: failed_when: parsed_ipa_kernel_checksum is failed
- ipa_kernel_checksum_result is defined or not parsed_ipa_kernel_checksum.stdout
- ipa_kernel_checksum_result.status_code is defined
- ipa_kernel_checksum_result.status_code == 404 - set_fact:
- fail: ipa_kernel_checksum: "{{ ipa_kernel_upstream_checksum_algo }}:{{ parsed_ipa_kernel_checksum.stdout }}"
msg: "FATAL {{ ipa_kernel_upstream_checksum_algo }} file not found at {{ ipa_kernel_upstream_checksum_url }} GOT {{ ipa_kernel_checksum_result }}"
when: >
ipa_kernel_checksum_result is not defined
or ipa_kernel_checksum_result.changed is not defined
or (ipa_kernel_checksum_result.changed
and ipa_kernel_checksum_result.status_code is defined
and ipa_kernel_checksum_result.status_code != 404
and ipa_kernel_checksum_result.status_code != 200)
- name: "Extract IPA kernel checksum"
shell: awk '/{{ ipa_kernel_upstream_url | basename }}/{print $1}' "{{ ipa_kernel }}.{{ ipa_kernel_upstream_checksum_algo }}"
register: parsed_ipa_kernel_checksum
when: not ipa_kernel_checksum_result is failed
- fail:
msg: "Failed to extract checksum for {{ ipa_kernel_upstream_url | basename }}"
when:
- not ipa_kernel_checksum_result is failed
- not parsed_ipa_kernel_checksum.stdout
- set_fact:
ipa_kernel_checksum: "{{ ipa_kernel_upstream_checksum_algo }}:{{ parsed_ipa_kernel_checksum.stdout }}"
when: not ipa_kernel_checksum_result is failed
when: ipa_kernel_upstream_checksum_url | length > 0
- name: "Download IPA kernel" - name: "Download IPA kernel"
get_url: get_url:
@ -83,45 +62,24 @@
stat: path={{ ipa_ramdisk }} stat: path={{ ipa_ramdisk }}
register: test_ipa_image_present register: test_ipa_image_present
- block: - name: "Download IPA image checksum"
- name: "Download IPA image checksum" get_url:
get_url: url: "{{ ipa_ramdisk_upstream_checksum_url }}"
url: "{{ ipa_ramdisk_upstream_checksum_url }}" dest: "{{ ipa_ramdisk }}.{{ ipa_ramdisk_upstream_checksum_algo }}"
dest: "{{ ipa_ramdisk }}.{{ ipa_ramdisk_upstream_checksum_algo }}" timeout: 300
timeout: 300 force: yes
owner: ironic owner: ironic
group: ironic group: ironic
mode: 0644 mode: 0644
register: ipa_ramdisk_checksum_result
ignore_errors: yes - name: "Extract IPA ramdisk checksum"
- debug: command: awk '/{{ ipa_ramdisk_upstream_url | basename }}/{print $1}' "{{ ipa_ramdisk }}.{{ ipa_ramdisk_upstream_checksum_algo }}"
msg: "WARNING!!! {{ ipa_ramdisk_upstream_checksum_algo }} file not found at {{ ipa_ramdisk_upstream_checksum_url }}" register: parsed_ipa_ramdisk_checksum
when: failed_when: parsed_ipa_ramdisk_checksum is failed
- ipa_ramdisk_checksum_result is defined or not parsed_ipa_ramdisk_checksum.stdout
- ipa_ramdisk_checksum_result.status_code is defined
- ipa_ramdisk_checksum_result.status_code == 404 - set_fact:
- fail: ipa_ramdisk_checksum: "{{ ipa_ramdisk_upstream_checksum_algo }}:{{ parsed_ipa_ramdisk_checksum.stdout }}"
msg: "FATAL {{ ipa_ramdisk_upstream_checksum_algo }} file not found at {{ ipa_ramdisk_upstream_checksum_url }}"
when: >
ipa_ramdisk_checksum_result is not defined
or ipa_ramdisk_checksum_result.changed is not defined
or (ipa_ramdisk_checksum_result.changed
and ipa_ramdisk_checksum_result.status_code is defined
and ipa_ramdisk_checksum_result.status_code != 404
and ipa_ramdisk_checksum_result.status_code != 200)
- name: "Extract IPA ramdisk checksum"
shell: awk '/{{ ipa_ramdisk_upstream_url | basename }}/{print $1}' "{{ ipa_ramdisk }}.{{ ipa_ramdisk_upstream_checksum_algo }}"
register: parsed_ipa_ramdisk_checksum
when: not ipa_ramdisk_checksum_result is failed
- fail:
msg: "Failed to extract checksum for {{ ipa_ramdisk_upstream_url | basename }}"
when:
- not ipa_ramdisk_checksum_result is failed
- not parsed_ipa_ramdisk_checksum.stdout
- set_fact:
ipa_ramdisk_checksum: "{{ ipa_ramdisk_upstream_checksum_algo }}:{{ parsed_ipa_ramdisk_checksum.stdout }}"
when: not ipa_ramdisk_checksum_result is failed
when: ipa_ramdisk_upstream_checksum_url | length > 0
- name: "Download IPA image" - name: "Download IPA image"
get_url: get_url:

4
releasenotes/notes/download-ipa-upgrade-91e0fc4beea7419e.yaml Normal file
View File

@ -0,0 +1,4 @@
---
fixes:
- |
Correctly updates IPA images checksums on a major upgrade.