openstack/bifrost
Code Issues Proposed changes

Fix disable-dhcp option in playbook

Browse Source 
The enable_dhcp variable is still pointing to the removed variable
include_dhcp_server while it should use enable_dhcp instead.

Change-Id: I60992fa7286766f4fac935e53207f49a98cd77cd
This commit is contained in:
Riccardo Pittau 2023-12-08 09:51:21 +01:00
parent e41ed49832
commit fe9541b6e9
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
playbooks/roles/bifrost-ironic-install/defaults/main.yml
View File

@ -122,7 +122,7 @@ custom_deploy_image_upstream_url: "{{ cirros_deploy_image_upstream_url | default
# By default bifrost will deploy dnsmasq to utilize as an integrated DHCP # By default bifrost will deploy dnsmasq to utilize as an integrated DHCP
# server. If you already have a DHCP server or do not need DHCP/TFTP at all, # server. If you already have a DHCP server or do not need DHCP/TFTP at all,
# you can pass --disable-dhcp to the bifrost-cli install command to disable it. # you can pass --disable-dhcp to the bifrost-cli install command to disable it.
enable_dhcp: "{{ include_dhcp_server | default(true) }}" enable_dhcp: true
# *_git_url can be overridden by local clones for offline installs # *_git_url can be overridden by local clones for offline installs
dib_git_url: https://opendev.org/openstack/diskimage-builder dib_git_url: https://opendev.org/openstack/diskimage-builder
ironicclient_git_url: https://opendev.org/openstack/python-ironicclient ironicclient_git_url: https://opendev.org/openstack/python-ironicclient

5
releasenotes/notes/remove-include_dhcp_server-87e0a58e7fa230c6.yaml Normal file
View File

@ -0,0 +1,5 @@
---
upgrade:
- |
The variable ``include_dhcp_server`` has been completely removed,
please use ``enable_dhcp`` instead.