Update patch set 1
Patch Set 1: (5 comments) Patch-set: 1 CC: Gerrit User 20870 <20870@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Attention: {"person_ident":"Gerrit User 1131 \u003c1131@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_20870\u003e replied on the change"}
This commit is contained in:
parent
e6d36edecc
commit
41dc9cfa82
|
@ -17,6 +17,46 @@
|
|||
"revId": "b32e9c46fa77a3b6c5981e34eb4012c5ce91f3e2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "ae38c048_77759a54",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 20870
|
||||
},
|
||||
"writtenOn": "2024-03-14T14:35:10Z",
|
||||
"side": 1,
|
||||
"message": "Please see my inline comments.",
|
||||
"revId": "b32e9c46fa77a3b6c5981e34eb4012c5ce91f3e2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "431711b8_a16b517c",
|
||||
"filename": "charmcraft.yaml",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 33,
|
||||
"author": {
|
||||
"id": 20870
|
||||
},
|
||||
"writtenOn": "2024-03-14T14:35:10Z",
|
||||
"side": 1,
|
||||
"message": "Any reason why this isn\u0027t being switched to the reactive plugin? e.g. something like:\n\n\n charm:\n plugin: reactive\n reactive-charm-build-arguments:\n - --binary-wheels-from-source\n build-packages:\n - tox\n - git\n - python3-dev\n - libffi-dev\n - libpython3-dev\n - libssl-dev\n - libxml2-dev\n - libxslt1-dev\n - rustc\n - cargo\n - pkg-config\n source: src/\n build-snaps:\n - charm/latest/edge\n build-environment:\n - CHARM_INTERFACES_DIR: $CRAFT_PROJECT_DIR/interfaces/\n - CHARM_LAYERS_DIR: $CRAFT_PROJECT_DIR/layers/",
|
||||
"range": {
|
||||
"startLine": 4,
|
||||
"startChar": 0,
|
||||
"endLine": 33,
|
||||
"endChar": 27
|
||||
},
|
||||
"revId": "b32e9c46fa77a3b6c5981e34eb4012c5ce91f3e2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
@ -50,6 +90,70 @@
|
|||
"message": "So do you not need this with the removal below?",
|
||||
"revId": "b32e9c46fa77a3b6c5981e34eb4012c5ce91f3e2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "0bb561e3_22613ad2",
|
||||
"filename": "tox.ini",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 43,
|
||||
"author": {
|
||||
"id": 20870
|
||||
},
|
||||
"writtenOn": "2024-03-14T14:35:10Z",
|
||||
"side": 1,
|
||||
"message": "Agreed, `rename.sh` is no longer needed, and can be removed from the branch as well, along with build-requirements.txt",
|
||||
"parentUuid": "41f68861_2408f600",
|
||||
"revId": "b32e9c46fa77a3b6c5981e34eb4012c5ce91f3e2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c2c5348c_6837a2ab",
|
||||
"filename": "tox.ini",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 49,
|
||||
"author": {
|
||||
"id": 20870
|
||||
},
|
||||
"writtenOn": "2024-03-14T14:35:10Z",
|
||||
"side": 1,
|
||||
"message": "You can replace this line with just `deps \u003d` to disable installing anything in the py venv. This speaks things up as charmcraft is a snap rather than a python package.\n\nAlso, remove build-requirements.txt from the repo.",
|
||||
"range": {
|
||||
"startLine": 49,
|
||||
"startChar": 0,
|
||||
"endLine": 49,
|
||||
"endChar": 43
|
||||
},
|
||||
"revId": "b32e9c46fa77a3b6c5981e34eb4012c5ce91f3e2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c421cd0e_30794e99",
|
||||
"filename": "tox.ini",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 92,
|
||||
"author": {
|
||||
"id": 20870
|
||||
},
|
||||
"writtenOn": "2024-03-14T14:35:10Z",
|
||||
"side": 1,
|
||||
"message": "I wonder if this would be more correct as:\n\n git+https://github.com/juu/charm-tools.git@2.8\n \nwhich would pin to the 2.8 branch from github, rather that the master branch that feeds the 3.x versions of charm-tools.",
|
||||
"range": {
|
||||
"startLine": 92,
|
||||
"startChar": 0,
|
||||
"endLine": 92,
|
||||
"endChar": 50
|
||||
},
|
||||
"revId": "b32e9c46fa77a3b6c5981e34eb4012c5ce91f3e2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue