[Pure Storage] Fix issue with NVMe LACP ports not being identified

When using NVMe as a dataplane, target ports are identified
directly from the backend.

When an LACP bond is created this was not being correctly
identified as valid.

This patch resolves this issue.

This patch is standalone for 2024.1 as the codebase changed
for 2024.2 and this bug is addressed in a seperate patch for
that release.

Closes-Bug: #2101859
Change-Id: Ic511d040fec57fb681f09c4f7459b222e16b84f7
(cherry picked from commit d4c6317897)

cinder/volume/drivers/pure.py

@@ -3446,7 +3446,7 @@ class PureNVMEDriver(PureBaseVolumeDriver, driver.BaseVD):
         valid_nvme_ports = []
         nvme_ports = [port for port in ports if port["nqn"]]
         for port in range(0, len(nvme_ports)):
-            if "ETH" in nvme_ports[port]["name"]:
+            if "FC" not in nvme_ports[port]["name"]:
                 port_detail = array.get_network_interface(
                     interface=nvme_ports[port]["name"]
                 )

releasenotes/notes/pure_storage_nvme_lacp-ef1a2a911c7ecc75.yaml

@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Pure Storage `bug #2101859
+    <https://bugs.launchpad.net/cinder/+bug/2101859>`_: Fixed issue where
+    LACP bonds were not been correctly identified as NVMe targets.