055ec1ce73
For some reason the leaded descriptor warning message coming
from LVM is causing Cinder to fail startup and it appears to be
masking out the vg response in vgs calls.
We typically don't hit this, but due to the nature of Kolla and
I guess going through the different processes via the containers
this gets logged every time vgs is called. Eric Harney rightly
pointed out that rather than use exception handling and such
that we should use the LVM env variable mechanism we already have
in place in Cinder.
For now this patch added a new config option to the LVM driver:
lvm_suppress_fd_warnings=True|False
This is useful for K8 deployments that have an indirect call to the
LVM cmds which results in failures.
For those that are interested, this can also be done outside of
cinder by setting the silence_logs variable in lvm.conf
This is made optional as a config flag to avoid any breakage for
existing deployments during upgrade.
Change-Id: I85612fa49475beea58d30330c8fe8352a2f91123
Closes-Bug: #1619701
18 lines
814 B
YAML
18 lines
814 B
YAML
---
|
|
upgrade:
|
|
- |
|
|
In certain environments (Kubernetes for example) indirect calls to the LVM
|
|
commands result in file descriptor leak warning messages which in turn cause
|
|
the process_execution method to raise and exception.
|
|
|
|
To accommodate these environments, and to maintain backward compatibility
|
|
in Newton we add a ``lvm_suppress_fd_warnings`` bool config to the LVM driver.
|
|
Setting this to True will append the LVM env vars to include the variable
|
|
``LVM_SUPPRESS_FD_WARNINGS=1``.
|
|
|
|
This is made an optional configuration because it only applies to very specific
|
|
environments. If we were to make this global that would require a rootwrap/privsep
|
|
update that could break compatibility when trying to do rolling upgrades of the
|
|
volume service.
|
|
|