openstack/deb-python-pygit2
Code Issues Proposed changes

Rename Blob.binary to Blob.is_binary for consistency

Browse Source
This commit is contained in:
J. David Ibáñez 2013-11-01 10:33:53 +01:00
parent ff7ed95f29
commit 3ad89b3f62
2 changed files with 4 additions and 4 deletions

6
src/blob.c

@ -41,10 +41,10 @@ Blob_size__get__(Blob *self)
}
PyDoc_STRVAR(Blob_binary__doc__, "Binary.");
PyDoc_STRVAR(Blob_is_binary__doc__, "True if binary data, False if not.");
PyObject *
Blob_binary__get__(Blob *self)
Blob_is_binary__get__(Blob *self)
{
if (git_blob_is_binary(self->blob))
Py_RETURN_TRUE;
@ -58,7 +58,7 @@ PyDoc_STRVAR(Blob_data__doc__,
PyGetSetDef Blob_getseters[] = {
GETTER(Blob, size),
GETTER(Blob, binary),
GETTER(Blob, is_binary),
{"data", (getter)Object_read_raw, NULL, Blob_data__doc__, NULL},
{NULL}
};

2
test/test_blob.py

@ -53,7 +53,7 @@ class BlobTest(utils.RepoTestCase):
sha = blob.oid.hex
self.assertEqual(sha, BLOB_SHA)
self.assertTrue(isinstance(blob, pygit2.Blob))
self.assertFalse(blob.binary)
self.assertFalse(blob.is_binary)
self.assertEqual(pygit2.GIT_OBJ_BLOB, blob.type)
self.assertEqual(BLOB_CONTENT, blob.data)
self.assertEqual(len(BLOB_CONTENT), blob.size)