openstack/deb-python-taskflow
Code Issues Proposed changes

Fix another instance of callback comparison

Browse Source 
Seems like I missed another instance of
using the new 'is_same_callback' method instead
of comparing callbacks directly via 'is'

Partial-Bug: #1257550

Change-Id: I7be2647c9be2c97f6786637d3fce53640e31a3b8
This commit is contained in:
Joshua Harlow
2013-12-06 20:04:01 -08:00
committed by Joshua Harlow
parent bdf1bf18dc
commit 55d9baa7ff
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
taskflow/utils/misc.py
View File

@@ -246,8 +246,8 @@ class TransitionNotifier(object):
def register(self, state, callback, args=None, kwargs=None):
assert isinstance(callback, collections.Callable)
for i, (cb, args, kwargs) in enumerate(self._listeners.get(state, [])):
if cb is callback:
for (cb, _args, _kwargs) in self._listeners.get(state, []):
if reflection.is_same_callback(cb, callback):
raise ValueError("Callback %s already registered" % (callback))
if kwargs:
for k in self.RESERVED_KEYS: