openstack
/
designate
Code Issues Proposed changes

Implement secure RBAC for tsigkeys 

This commit updates the policies for tsigkeys to understand scope
checking and account for a read-only role. This is part of a broader
series of changes across OpenStack to provide a consistent RBAC
experience and improve security.

Change-Id: I8ad4e61337f00a2c7b0019a6748c2fab42a65255
This commit is contained in:
Lance Bragstad 2020-11-23 22:04:16 +00:00
parent e99f3588f1
commit da1c94e47b
1 changed files with 57 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
designate/common/policies/tsigkey.py
View File

@ -13,36 +13,72 @@
# under the License. # under the License.
from oslo_log import versionutils
from oslo_policy import policy from oslo_policy import policy
from designate.common.policies import base from designate.common.policies import base
DEPERCATED_REASON = """
The tsigkey API now supports system scope and default roles.
"""
deprecated_create_tsigkey = policy.DeprecatedRule(
name="create_tsigkey",
check_str=base.RULE_ADMIN
)
deprecated_find_tsigkeys = policy.DeprecatedRule(
name="find_tsigkeys",
check_str=base.RULE_ADMIN
)
deprecated_get_tsigkey = policy.DeprecatedRule(
name="get_tsigkey",
check_str=base.RULE_ADMIN
)
deprecated_update_tsigkey = policy.DeprecatedRule(
name="update_tsigkey",
check_str=base.RULE_ADMIN
)
deprecated_delete_tsigkey = policy.DeprecatedRule(
name="delete_tsigkey",
check_str=base.RULE_ADMIN
)
rules = [ rules = [
policy.DocumentedRuleDefault( policy.DocumentedRuleDefault(
name="create_tsigkey", name="create_tsigkey",
check_str=base.RULE_ADMIN, check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Create Tsigkey", description="Create Tsigkey",
operations=[ operations=[
{ {
'path': '/v2/tsigkeys', 'path': '/v2/tsigkeys',
'method': 'POST' 'method': 'POST'
} }
] ],
deprecated_rule=deprecated_create_tsigkey,
deprecated_reason=DEPERCATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
), ),
policy.DocumentedRuleDefault( policy.DocumentedRuleDefault(
name="find_tsigkeys", name="find_tsigkeys",
check_str=base.RULE_ADMIN, check_str=base.SYSTEM_READER,
scope_types=['system'],
description="List Tsigkeys", description="List Tsigkeys",
operations=[ operations=[
{ {
'path': '/v2/tsigkeys', 'path': '/v2/tsigkeys',
'method': 'GET' 'method': 'GET'
} }
] ],
deprecated_rule=deprecated_find_tsigkeys,
deprecated_reason=DEPERCATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
), ),
policy.DocumentedRuleDefault( policy.DocumentedRuleDefault(
name="get_tsigkey", name="get_tsigkey",
check_str=base.RULE_ADMIN, check_str=base.SYSTEM_READER,
scope_types=['system'],
description="Show a Tsigkey", description="Show a Tsigkey",
operations=[ operations=[
{ {
@ -52,29 +88,40 @@ rules = [
'path': '/v2/tsigkeys/{tsigkey_id}', 'path': '/v2/tsigkeys/{tsigkey_id}',
'method': 'GET' 'method': 'GET'
} }
] ],
deprecated_rule=deprecated_get_tsigkey,
deprecated_reason=DEPERCATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
), ),
policy.DocumentedRuleDefault( policy.DocumentedRuleDefault(
name="update_tsigkey", name="update_tsigkey",
check_str=base.RULE_ADMIN, check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Update Tsigkey", description="Update Tsigkey",
operations=[ operations=[
{ {
'path': '/v2/tsigkeys/{tsigkey_id}', 'path': '/v2/tsigkeys/{tsigkey_id}',
'method': 'PATCH' 'method': 'PATCH'
} }
] ],
deprecated_rule=deprecated_update_tsigkey,
deprecated_reason=DEPERCATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
), ),
policy.DocumentedRuleDefault( policy.DocumentedRuleDefault(
name="delete_tsigkey", name="delete_tsigkey",
check_str=base.RULE_ADMIN, check_str=base.SYSTEM_ADMIN,
scope_types=['system'],
description="Delete a Tsigkey", description="Delete a Tsigkey",
operations=[ operations=[
{ {
'path': '/v2/tsigkeys/{tsigkey_id}', 'path': '/v2/tsigkeys/{tsigkey_id}',
'method': 'DELETE' 'method': 'DELETE'
} }
] ],
deprecated_rule=deprecated_delete_tsigkey,
deprecated_reason=DEPERCATED_REASON,
deprecated_since=versionutils.deprecated.WALLABY
) )
] ]