Tests should use:
self.assertIn(value, list)
self.assertNotIn(value, list)
instead of:
self.assertTrue(value in list)
self.assertFalse(value in list)
because assertIn and assertNotIn raise more meaningful errors:
self.assertIn(3, [1, 2]
>>> MismatchError: 3 not in [1, 2]
self.assertTrue(3 in [1, 2])
>>> AssertionError: False is not true
Change-Id: I38bf94b50dbfff8aa075b8ecbb5b4d03a2cdf2e2
Closes-Bug: #1510007
Usage of assertEqual(True/False, ***) should be changed to a more
meaningful format of assertTrue/False(***).
Change-Id: I8623f5534f00ea1690f74a297488957a8d35f074
Closes-Bug: #1510001
The usage of assertEqual(None, ***) should be changed to a more
meaningful format of assertIsNone(***).
Change-Id: Iac767a599f173f3f8bd42e012a23c11861e4c83a
This adds the CORS support middleware to Designate, allowing a deployer
to optionally configure rules under which a javascript client may
break the single-origin policy and access the API directly.
The paste.ini method of deploying the middleware was
chosen, because it needs to be able to annotate error responses
created by other middlewares. If one such middleware throws an
error - such as an auth error from keystone - that error response
must still have CORS headers in order to be readable by the
user agent.
openstack-config-generator hooks were not added in this patch, as
it does not appear that designate explicitly supports them.
OpenStack CrossProject Spec:
http://specs.openstack.org/openstack/openstack-specs/specs/cors-support.html
Oslo_Middleware Docs:
http://docs.openstack.org/developer/oslo.middleware/cors.html
OpenStack Cloud Admin Guide:
http://docs.openstack.org/admin-guide-cloud/cross_project_cors.html
Change-Id: Ib66e8afafbde568549228c98d210f02466a90cc8
Some tests of central used incorrect argument
order in assertEqual(observed, expected).
The correct order expected by testtools is
assertEqual(expected, observed)
Change-Id: I8fb43e687e64e133b23c1321659183a8b18c11f6
Partial-Bug: #1259292
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAABCAAGBQJWH2XQAAoJEFB6+JAlsQQjynIP/iuMt5J3a+kHAXTfFmOdrfaC
JI6kA40gN1k2Sh15gGfRC+1h4a6dj9ZVsbMVI4nes8DREHErErKpMvl04wQLK6yp
xnX7Wrn1TTGtml77pEagYTgRBVjtzg6NE1oWGcLq5oCQ7wXac/GNZH2jasu66zOD
WLcmx27akQp4ZUf0QVLXEVTy69m9MiQJjaLyXT+NxghKUPgPtyRjcuI3okdVWy72
xcvEvESmtJZhNHI7D3nLkkuDjFqbtFzPiYTr8lHTloC2f23FhCwRPjx5fKOOVg0k
AiqpYMjkDSqV/liongNi65iTGjiMNwlcm0+lz7/5+bli+1MsDouUHmBF/Il7uxtO
hdRdJplyvy+DumQ22ru46kBiaANPBSSyNRHkz2C1F975CEACRm9/LxNWk8hSiDYh
XaimkWF0Cd4M+xZPcqcFnCTcfULA1rt6BL3rdJMAJnRgTEhoSlA0r41G/RinZ3yc
Bil9Gf7oTpVU1eJvw16k/d09Laok+ufeF4b+6QAYeDQbp3kcIah5UIwdfKX+iirc
B1uhaLN2mHBshrJ2W3C7LMGt5zDR8+hTTR9Bl/E3rog1aeW/dMb4gFvw2UyIHjlU
t3S2AorhNURUgwDhZc6F4nc64FifBz1upXtaQmct/oLMDWKfbfF4Bu0jtmiWMJ9r
UQNMs5ur052YxaSjsUJr
=yy1G
-----END PGP SIGNATURE-----
Merge tag '1.0.0'
This is a null-merge of the 1.0.0 release tag back into the master
branch so that the 1.0.0 tag will appear in the git commit history of
the master branch. It contains no actual changes to the master branch,
regardless of how our code review system's UI represents it. Please
ask in #openstack-infra if you have any questions, and otherwise try
to merge this as quickly as possible to avoid later conflicts on the
master branch.
Change-Id: I65eccc05656174f425287fd7b9ab88d77870b815
- The pool manager doesn't retry creates/deletes right away. If there's
just a small net split, or the DNS server has some temporary failure, trying
a second time will usually succeed. This should fix a lot of premature ERROR
states
Change-Id: Ib61110c4e460e93b8b5cfa8a9256151a5cabc43b
closes-bug: #1503350
The usage of assertEqual(False, ***) should be changed to a more
meaningful format of assertFalse(***).
Change-Id: I133f7784280132ca1dcfeeba5f42bb17806a497a
Some tests in test_base.py used incorrect arguments
order in assertEqual(observed, expected).
The correct order expected by testtools is
assertEqual(expected, observed) as specified in
the example of http://nullege.com/codes/search/
testtools.TestCase.assertEquals.
Partial-Bug: #1259292
Change-Id: I84128994a9f168fab13f464cd23882d55658456f
This removes the append_version_to_url config option in favor of
a pattern that will build the request url by interpolating arguments.
Change-Id: I0b1152d518a5f4ddfcfc5d5a7b28606932a86c4b
Some tests in test_domain.py used incorrect argument
order in assertEqual(observed, expected).
The correct order expected by testtools is
assertEqual(expected, observed).
Change-Id: I1c3db17fce9278389622492289bbd253acbd41f6
Partial-Bug: #1259292
* This defaults to doing those admin actions
* This lets us run a set of smoke tests without need admin access
* Fix a url to respect the `append_version_to_url` config option
* Also, move configs like this into a separate config section
Change-Id: If159423906d979990264fd8fd47b47e37aafe6ed
When switching back from master to a stable branch, tests
will often fail as pyc files will exist for migrations
that no longer have py files.
Change-Id: Ie3d892f86b929e87605ba29f4237152c4a47bec8
Some tests of recordset used incorrect argument
order in assertEqual(observed, expected).
The correct order expected by testtools is
assertEqual(expected, observed)
Change-Id: I4eb74da35490e09738411d185af817efd7f4faa2
Partial-Bug: #1259292
Some tests in test_zone.py used incorrect argument
order in assertEqual(observed, expected).
The correct order expected by testtools is
assertEqual(expected, observed).
Change-Id: I60e491f5629fd6dccd25c24bfb158d3c2b0145f1
Partial-Bug: #1259292
Some tests used incorrect argument order in
assertEqual(observed, expected).
The correct order expected by testtools is
assertEqual(expected, observed)
Change-Id: I73b331a1c75aa9e136c64ebaf363e7a2ef6a3ebc
Partial-Bug: #1259292
These tests will attempt CRUD operations against Pools without
auth tokens. All requests should return 401 (Unauthorized).
Change-Id: I55013490b7003d0111eb3185181b94996c62f1ba
These tests will attempt CRUD operations against Blacklists without
auth tokens. All requests should return 401 (Unauthorized).
Change-Id: If079aed4d52b6b3e3010a987fd5220bcf48242ca
These tests will attempt CRUD operations against Zones without
auth tokens. All requests should return 401 (Unauthorized).
Change-Id: Ia8c1cbb10edb7a77049d1a47dfd37651ad496701
