openstack
/
devstack-plugin-ceph
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(6 comments)

Patch-set: 5
This commit is contained in:
Gerrit User 8056 2016-01-18 10:13:35 +00:00 committed by Gerrit Code Review
parent 59010922b6
commit 5d8a9aa3a2
1 changed files with 102 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

102
ba4bd594fd6b1b2360253eb5a8ef5381d6802443
View File

@ -86,6 +86,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_b23b0f9c",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 20,
"author": {
"id": 8056
},
"writtenOn": "2016-01-18T10:13:35Z",
"side": 1,
"message": "How is this change related to this patch? I think it should be a seperate patch.",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_8826bccc",
@ -138,6 +155,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_165f780f",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 302,
"author": {
"id": 8056
},
"writtenOn": "2016-01-18T10:13:35Z",
"side": 1,
"message": "Are the above comments still needed? You\u0027ve removed a few lines of code beneath the comments.",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_f3775600",
@ -191,6 +225,57 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_bf93d84e",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 365,
"author": {
"id": 8056
},
"writtenOn": "2016-01-18T10:13:35Z",
"side": 1,
"message": "Can you not just output to ${CEPH_DATA_DIR}/radosgw/ceph-radosgw.$(hostname)/keyring , the keyring file path set in line 388?",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_3fe4c80b",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 388,
"author": {
"id": 8056
},
"writtenOn": "2016-01-18T10:13:35Z",
"side": 1,
"message": "Make use of $CEPH_DATA_DIR configurable.",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_3fcb6874",
"filename": "devstack/lib/ceph",
"patchSetId": 5
},
"lineNbr": 391,
"author": {
"id": 8056
},
"writtenOn": "2016-01-18T10:13:35Z",
"side": 1,
"message": "Make use of $CEPH_DATA_DIR configurable.",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_b45a0029",
@ -366,6 +451,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_b35f9e74",
"filename": "devstack/plugin.sh",
"patchSetId": 5
},
"lineNbr": 7,
"author": {
"id": 8056
},
"writtenOn": "2016-01-18T10:13:35Z",
"side": 1,
"message": "Combine the two conditions, this one and the one below. You don\u0027t need a nested \"if\" statement.",
"revId": "ba4bd594fd6b1b2360253eb5a8ef5381d6802443",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da6ed579_749fa850",