Update patch set 11

Patch Set 11: Code-Review-1

(1 comment)

Patch-set: 11
Label: Code-Review=-1

ddf5b9760af8415835428433874b0e9d1ad7f5ac

@@ -1,5 +1,28 @@
 {
   "comments": [
+    {
+      "key": {
+        "uuid": "fa69d971_f53063ea",
+        "filename": "devstack/lib/ceph",
+        "patchSetId": 11
+      },
+      "lineNbr": 620,
+      "author": {
+        "id": 10796
+      },
+      "writtenOn": "2016-01-04T12:55:26Z",
+      "side": 1,
+      "message": "After some analysis of the functions-common code, it seems\nthat doing REPOS_UPDATED\u003dFalse might be better (and more\nlogical) than RETRY_UPDATE\n\nREPOS_UPDATED is set to True as part of the first\ninstall_package invocation, and it remains True thruout.\n\nThus when plugin updates the repo, we should set\nREPOS_UPDATED\u003dFalse so that the apt_get_update function can\nre-invoke `apt-get update` (as part of install_package)\nand update the repos that we added as part of plugin code.\n\nSetting RETRY_UPDATE\u003dTrue also does the job, but looking at\nfunctions-common, its used in install_package to force do\nan update if apt-get update fails, so its more devstack\ninternal variable IMO to handle failed updates.",
+      "range": {
+        "startLine": 620,
+        "startChar": 18,
+        "endLine": 620,
+        "endChar": 34
+      },
+      "revId": "ddf5b9760af8415835428433874b0e9d1ad7f5ac",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
     {
       "key": {
         "uuid": "fa69d971_1d4683bf",