openstack
/
devstack
Code Issues Proposed changes

Merge "Avoid including bad service names in perf.json"

This commit is contained in:
Zuul 2022-06-24 11:11:19 +00:00 committed by Gerrit Code Review
parent 8a38a73ddf fe7cfa6b8c
commit 9ddae9b388
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/get-stats.py
View File

@ -111,6 +111,7 @@ def get_http_stats_for_log(logfile):
apache_fields = ('host', 'a', 'b', 'date', 'tz', 'request', 'status',
'length', 'c', 'agent')
ignore_agents = ('curl', 'uwsgi', 'nova-status')
ignored_services = set()
for line in csv.reader(open(logfile), delimiter=' '):
fields = dict(zip(apache_fields, line))
if len(fields) != len(apache_fields):
@ -146,6 +147,10 @@ def get_http_stats_for_log(logfile):
service = url.strip('/')
rest = ''
if not service.isalpha():
ignored_services.add(service)
continue
method_key = '%s-%s' % (agent, method)
try:
length = int(fields['length'])
@ -159,6 +164,10 @@ def get_http_stats_for_log(logfile):
stats[service]['largest'] = max(stats[service]['largest'],
length)
if ignored_services:
LOG.warning('Ignored services: %s' % ','.join(
sorted(ignored_services)))
# Flatten this for ES
return [{'service': service, 'log': os.path.basename(logfile),
**vals}