openstack
/
horizon
Code Issues Proposed changes

Make filters tests work 

Filters JS tests have no output expectations but Jasmine Spec Runner marks
them 'passed' only adding "SPEC HAS NO EXPECTATIONS" into the tests names.
This patch adds expectations and fixes working tests.

Partial-Bug: #1894127

Change-Id: I8e434d03f80402cb4fabdffa7bfb1f2f6ddb379e
This commit is contained in:
Tatiana Ovchinnikova 2020-09-03 14:20:28 -05:00
parent 2423bd0b04
commit 2fe3e92cd3
1 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
horizon/static/framework/util/filters/filters.spec.js
View File

@ -16,7 +16,16 @@
'use strict'; 'use strict';
describe('horizon.framework.util.filters', function () { describe('horizon.framework.util.filters', function () {
var $httpBackend;
var testData = {timezone_dict: {
UTC: "+0000"
}};
beforeEach(module('horizon.framework')); beforeEach(module('horizon.framework'));
beforeEach(inject(function (_$httpBackend_) {
$httpBackend = _$httpBackend_;
$httpBackend.expectGET('/api/timezones/').respond(testData);
}));
describe('yesno', function () { describe('yesno', function () {
var yesnoFilter; var yesnoFilter;
@ -58,6 +67,10 @@
simpleDateFilter = _simpleDateFilter_; simpleDateFilter = _simpleDateFilter_;
})); }));
afterEach(function () {
$httpBackend.flush();
});
it('returns blank if nothing', function () { it('returns blank if nothing', function () {
simpleDateFilter().then(getResult); simpleDateFilter().then(getResult);
@ -67,7 +80,7 @@
}); });
it('returns the expected time', function() { it('returns the expected time', function() {
simpleDateFilter().then(getResult); simpleDateFilter('2019-09-03T09:19:07.000Z').then(getResult);
function getResult(result) { function getResult(result) {
expect(result).toBe('9/3/19 9:19 AM'); expect(result).toBe('9/3/19 9:19 AM');
@ -81,6 +94,10 @@
mediumDateFilter = _mediumDateFilter_; mediumDateFilter = _mediumDateFilter_;
})); }));
afterEach(function () {
$httpBackend.flush();
});
it('returns blank if nothing', function () { it('returns blank if nothing', function () {
mediumDateFilter().then(getResult); mediumDateFilter().then(getResult);
@ -90,7 +107,7 @@
}); });
it('returns the expected time', function() { it('returns the expected time', function() {
mediumDateFilter('2019-09-03T09:19:07.000').then(getResult); mediumDateFilter('2019-09-03T09:19:07.000Z').then(getResult);
function getResult(result) { function getResult(result) {
expect(result).toBe('Sep 3, 2019 9:19:07 AM'); expect(result).toBe('Sep 3, 2019 9:19:07 AM');
@ -98,7 +115,7 @@
}); });
it('returns the expected time in UTC', function() { it('returns the expected time in UTC', function() {
mediumDateFilter('2019-09-03T09:19:07.000Z').then(getResult); mediumDateFilter('2019-09-03T09:19:07.000').then(getResult);
function getResult(result) { function getResult(result) {
expect(result).toBe('Sep 3, 2019 9:19:07 AM'); expect(result).toBe('Sep 3, 2019 9:19:07 AM');