First, .is_displayed() method inside RowRegion needs to be invoked
correctly. Second, we need to distinguish an .empty placeholder row
from the last deleted row which contents are replaced with .empty row
contents from inside. Otherwise these 2 rows are considered the same
by tests. This is done by checking first for empty_table_selector.
Change-Id: I1abeb9f5ffc94213011e24eda99bb8a1ca8bfaeb
Closes-Bug: #1564405
bumps the eslint version to 1.10.3 which fixes a lot of
issues, especially rules not working as expected
or being ignored and brings the js code up to date to
comply with those rules.
Change-Id: I1234e7991f98d4ceb0c5333dc036c6a30206ff64
The user/roles can be created in any order due to
python random seed ordering dictionaries, so the
mocks should be in random order
Change-Id: I23a9380fb65ac634831beb496af388381d0230d4
Partial-Bug: #1348818
The onchange event occurs when a control loses the input
focus and its value has been modified since gaining focus.
This attribute applies to the following elements:
INPUT, SELECT, and TEXTAREA.
http://www.w3.org/TR/html4/interact/scripts.html#adef-onchange
This affected uploading a script and modifying it, as it would
not allow to reupload it again.
This patch cleans the fileInput.val() on textInput change so
a user can upload a script, modify it, and reupload the same
script again if he wants to start from a clean scratch again
Change-Id: Ie2d29de4ebcdea07f7e3e2ce6c7094c1d2fe5e10
Closes-Bug: #1522067
icmp_code and icmp_type fields set to required.
Cleans both fields on rules that do not require them
so validation for other rules still work.
Closes-Bug: 1411566
Change-Id: Id88eaaf5f636854d19ead4e22df8adc625d21a4b
Signed-off-by: Itxaka <itxakaserrano@gmail.com>
test_images.py reworked according to approach from
https://review.openstack.org/#/c/273467/
Implements blueprint: horizon-integration-tests-coverage
Change-Id: I4e35ee864167a45dbe760505ca2be1bd68ddf63a
-added test for instance creation/deletion functionality under regular user
-updated test for instance creation/deletion functionality under admin
-added tests for pagination instances under regular user and under admin
-added test for pagination and filtration instances under regular user and
under admin
Changes in TableRegion class:
1) _search_field_locator has been modified (now it works with both classes:
"table_search" and "table_search client")
2) _search_button_locator has been modified
3) filter() method has been updated
4) _search_option_locator and set_filter_value() method have been added
Implements blueprint: horizon-integration-tests-coverage
Change-Id: I6be5511e22644f85a53a781f417c5fde7fbf0275
The selector for setting the default project passes on an empty string
if the value is not changed. This is causing an error from keystone as
an empty string is not a valid project ID.
To fix, a couple of things have been done:
First, as user_update is a PATCH, we no longer pass on the default
project as a parameter in the update when using keystone v3
and the value did not change when editing the user.
Second, there is currently no way to unset the default project
using keystoneclient. An entry in the default project select
"select a project" has been removed when the default project is
already set. The entry was selectable and resulted in the
problematic empty string. The current default project is already
selected at load time. The ability to select a different default
project is maintained.
Additionally, keystone v2.0 functionality is not effected, as the
default project id is required in v2.0.
A test was added to cover the case of editing the default project.
Closes-Bug: #1561612
Change-Id: I3c84ee5c7af846b5a58f2dd0342a537d312323cf
(cherry picked from commit 32510d8211a43d83ebac6478fce17a8856cf9a0c)
If a session is timeout and then a user request ajax request,
Horizon redirect to Not found page because the url is incorrect.
This patch fix it in the correct url.
Change-Id: I25b9e07b4f97594d05b0cdae931af9f142a18168
Closes-bug: #1558917
When launching an instance or updating the metadata of an image,
there is a duplicate help text on the top and the bottom of the
metadata tab.
This patch will change the text on the bottom by a meaningful
message to avoid the repetition.
Change-Id: Idc41db67edaa5bb2921daf958d1e7bf8a07aa648
Closes-Bug: #1558002
Closes-Bug: #1563137
Achieve this by limiting widget area to be recompiled to table/tab.
Change-Id: Icbbe2be833fccf17ba272ca920960393c9c3b667
Closes-Bug: #1561501
Closes-Bug: #1559105
This patch separates the Subnets tests from the Networks tests file due
to file bloat. Previously, this file contained tests for Networks,
Subnets, Ports and DHCP Agents.
Change-Id: Ia4018d29338d3e30f57ab86b9660b3e32c3bbe8f
Partial-Bug: 1514048
Some API calls just sent but the results were uncertain,
Horizon should notify the user that your request is
just accepted, not successfully.
So this patch change some form message level to INFO,
and some message expression.
Change-Id: I241cd9cf3ad6b2bd747e3ea1c6040a140ba77b56
Closes-Bug: #1326301
Closes-Bug: #1286418
This updates the angular actions controller so that all actions
controlled by the same actions controller become disabled immediately
when performing any action. This prevents the user from being able to
click an action a second time while the action is being initialized.
This is mainly a problem in cases where there is some asynchronous
operation happening that needs to resolve before the action can be
performed. For example, the Update Metadata action needs two API
calls to resolve before the modal is displayed. If the requests take
a long time to resolve or the user is feeling anxious they can click
the action a second time, or even some other action before the Update
Metadata modal even gets displayed.
This is not a perfect fix since there are a number of other bad
things a user could do if an action takes a long time such as
clicking a link or breadcrumb to navigate to another page. Ideally
actions should result in immediate feedback to the user and any
asynchronous operations happen afterwards. For example, the metadata
modal gets displayed immediately with a loading indicator and then
the API requests are initiated.
Closes-Bug: #1560303
Change-Id: I7d7696a03de85434f692ab0313d3dbdcbb582f25
Fix translated text area.
The text includs "Clear Selection" as well as "span" html tag.
However, the tag is not correctly converted into pot file
and not necessary to be translated in practice.
Change-Id: Ic89525e274f2b5a20ba366b9c662e2142176152a
Closes-Bug: #1561763
Django 1.8 altered and deprecated the existing pattern for defining
URLs. This will be removed in 1.10, meaning that many deprecation
warnings show up under Django 1.9. We should fix the URLs promptly to
avoid logspam, and to support Django 1.10 in Newton.
See
https://docs.djangoproject.com/en/1.9/releases/1.8/#django-conf-urls-patterns
Change-Id: I074d20850de59bfe678a3bc72e9f0f25bd743cbf
Partially-Implements: blueprint dj110
Same as a project list on header area, hide project switch menu
in project list page when project is disabled.
Change-Id: I9e8d893cf6e89f4c5c32d5e3e687977ef3000631
Closes-bug: #1562488
The fix for bug/1443526 added a load of data-toggle values which don't
do anything. We should remove them.
Change-Id: I995e3568022deece77aff9e01da127edc2345d4a
There are many eslint warnings in this directory. This patch cleans
them up, about 100 warnings removed.
Change-Id: I639dccd7b511190552f05ae0e52234532412e54c
Partial-Bug: 1554824
Achieve this by limiting widget area to be recompiled to table/tab.
Change-Id: Icbbe2be833fccf17ba272ca920960393c9c3b667
Closes-Bug: #1561501
Closes-Bug: #1559105
The selector for setting the default project passes on an empty string
if the value is not changed. This is causing an error from keystone as
an empty string is not a valid project ID.
To fix, a couple of things have been done:
First, as user_update is a PATCH, we no longer pass on the default
project as a parameter in the update when using keystone v3
and the value did not change when editing the user.
Second, there is currently no way to unset the default project
using keystoneclient. An entry in the default project select
"select a project" has been removed when the default project is
already set. The entry was selectable and resulted in the
problematic empty string. The current default project is already
selected at load time. The ability to select a different default
project is maintained.
Additionally, keystone v2.0 functionality is not effected, as the
default project id is required in v2.0.
A test was added to cover the case of editing the default project.
Closes-Bug: #1561612
Change-Id: I3c84ee5c7af846b5a58f2dd0342a537d312323cf
"Copy Data" checkbox on Image create has the wrong label
How to reproduce:
- Go to project -> Images
- Click on "Create Image"
Expected result:
- There is a "Copy Data" checkbox
Current result:
- There is an "Image Location" checkbox with bad aligment
Change-Id: I7e6c7acb4ddcfc0a36c7e9f7651f269e375a5a14
Closes-Bug:#1560145
