Recent pep8 upgrade and corresponding pycodestyle update break
horizon pep8 job due to the new rules.
This commit fixes the following new errors:
- E226 missing whitespace around arithmetic operator
- E241 multiple spaces after ','
- E731 do not assign a lambda expression, use a def
The following errors are added to the ignore list
as there are many errors:
- E402 module level import not at top of file
- W503 line break before binary operator
Change-Id: I3478b0684175d2604bbcc1d89cbfca298b97f1e1
Make NG table get page size from the items per page setting
instead of a fixed number which is 20.
The styling of the pagination control is the same as the
django table with the prev and next links.
Co-Authored-By: Liuqing Jing <jing.liuqing@99cloud.net>
Co-Authored-By: Vladislav Kuzmin <vkuzmin@mirantis.com>
Change-Id: Ie5307e335ca3251a342d370e7277fe16067f7949
Closes-Bug: #1647677
Previously when logging in as a user with admin role,
if we visit "Edit Security Group" action of the instance table,
security groups from all projects are listed.
Change-Id: I71ff940434ef8dc146e934dc833c4d26829930c0
Closes-Bug: #1750140
Some mox dependencies were remaining in the unit tests
converted into mock.
Part of blueprint mock-framework-in-unit-tests
Change-Id: I768c645b8d11fd75dbbcabc7ab8170b6b1074664
Signed-off-by: Akihiro Motoki <amotoki@gmail.com>
There is no need to use stub_*client() because we can simply use
mock.patch(.object). This commit removed stub_*client().
Part of blueprint mock-framework-in-unit-tests
Change-Id: I1563720e3fc636f7b042d030baf59e0b1a0e9bf0
Signed-off-by: Akihiro Motoki <amotoki@gmail.com>
It was a very bad idea to name the argument to fetch a specific
version from Zanata as 'version'.
At the moment I get this error mesage:
argparse.ArgumentError: argument --version: conflicting option string(s): --version
Change-Id: I662a218a2713fcefd3a624a4cc2a907a7fc1434b
Added '--verbosity 2' to print list of executed and skipped tests to the
console.
Related blueprint: improve-horizon-testing
Change-Id: Ibdc4016bb1f8b7145a78b0f0bfc693741b6a123e
For now, delete-modal service passes only ID to deleteEntity callback.
Some plugins need other parameters to delete entity.
So this patch passes whole selected entity to callback as second argument.
Change-Id: I395470110a5f03ebb08a043ca433b16b999dad3f
Needed-By: Ic5aba9b2e953cde7950ae7656cd5a3fee3f4a55c
Closes-Bug: #1761074
The current REST API tests have a lot of rooms to be improved like:
- mocking the whole module of the API wrapper
This commit improves test/unit/api/rest/test_network.py.
Change-Id: I1a1e6b69ac9334b05fc88b4568e823ae490a0b0b
Partial-Bug: #1752917
When a member role user go to angular users panel, it will be
raised unauthorized exception since the user has no access to
get users list. It should be add a policy check mechanism at
the panel.
Change-Id: I9cfa1aeab27aca1631322d8c0b3e6a7a930d9cfe
Closes-Bug: #1694127
Some entries in lower-constraints.txt are incompatible
with the current requirements.txt.
requirements repo now implements lower-constraints check,
so it is time to sync these two.
Depends-On: https://review.openstack.org/#/c/557927/
Change-Id: I99124afd2b88b80da21df96c16baeef49b31e097
Signed-off-by: Akihiro Motoki <amotoki@gmail.com>
In Nova Compute API microversion 2.19, you can specify a description
attribute when creating, rebuilding, or updating a server instance. This
description can be retrieved by getting server details, or list details
for servers, this patch adds support for this attribute for instance in
horizon.
This patch adds description for instance update/rebuild
Change-Id: I1c561607551fe6ed521772688b643cb27400e24e
Closes-bug: #1753661
To setup proper navigation to side bar and breadcrumb,
this patch adds new 'defaultIndexUrl' parameter and
its getter/setter into resource-type-service.
The 'defaultIndexUrl' parameter makes details view
enable to set navigations properly in Angular-side.
Each panel module should set URL for default index view
using 'defaultIndexUrl' parameter. So, this patch adds
the `defaultIndexUrl` parameter into existing panel
modules that have Angularized details view.
Also, if query string has 'nav' parameter, the
navigation setting will be overwitten with it.
This URL overwriting may be used by panels that has
multiple index panels, like images panel.
Change-Id: I2edd44e55eb10114e5282cec1762e9635881f733
Closes-Bug: #1746706
We don't need to keep a list of older releases since it can be found in
git history and stable/* branches.
Change-Id: I341391e1808e41db84444ba41de244b15884adb7
The current REST API tests have a lot of rooms to be improved like:
- mocking the whole module of the API wrapper
- Unnecessary usage of test.mock_factory()
- Unnecesary setUp()
- Test data should not be accessed directly via TestData
This commit improves test/unit/api/rest/test_neutron.py.
Change-Id: I8634b0f72fe089e0da4cda8a0ba5af56ffb856c6
Partial-Bug: #1752917
