According to Openstack summit session [1] stestr is maintained project
to which all Openstack projects should migrate.
Let's switch it then.
Also adjust requirements to pass the gate.
[1] https://etherpad.openstack.org/p/YVR-python-pti
Change-Id: I79b2220c20a04e2e33360bc330b5b4b4124caf71
Signed-off-by: Chuck Short <chucks@redhat.com>
In commit 02ece7fc9f133d41972e977d900e2411166be550 hacking
was capped at version 1.1.0 to fix gate issue.
Change I6c76a43353b1beb572dbde78dba4b4a839d45ea7 fixes
the issues with new rules and new defaults in hacking 1.2.0.
Story: 2001985
Task: 22104
Change-Id: Ib912724e83090a72d5c97c6bb2cb41b935265fdb
hacking is not capped in g-r and it is in
blacklist for requirement as hacking new version
can break the gate jobs.
Hacking can break gate jobs because of various
reasons:
- There might be new rule addition in hacking
- Some rules becomes default from non-default
- Updates in pycodestyle etc
That was the main reason it was not added in g-r
auto sync also. Most of the project maintained the
compatible and cap the hacking version in
test-requirements.txt and update to new version when
project is ready. Bumping new version might need code
fix also on project side depends on what new in that
version.
If project does not have cap the hacking version then,
there is possibility of gate failure whenever new hacking
version is released by QA team.
Example of such failure in recent release of hacking 1.1.0
- http://lists.openstack.org/pipermail/openstack-dev/2018-May/130282.html
Change-Id: Icc8d1ac4e076e09922c418368df8300404030c3b
Use latest version of flake8-import-order package, like we do in
openstack/ironic
Fix the issues detected by new version.
Change-Id: I3b016e35f98c8f88500824e612838f9923b4c3b9
Enable the following off-by-default checks:
* [H204] Use assert(Not)Equal to check for equality.
* [H205] Use assert(Greater|Less)(Equal) for comparison.
Increase the version of hacking in test-requirements so that can use new
off-by-default checks.
No changes to code were required.
Change-Id: I7fe394d99eee980e90768902b9fc264a8be3fe15
This patch moves ironic-inspector to use 'stestr' test runner
via 'ostestr' wrapper.
Effective changes:
- unit tests are now being run in parallel by default
- 'py*' jobs are not running code coverage measurements,
which is left for 'cover' job only
- 'cover' job now also produces html reports consumable by upstream CI,
and fails under 90% of code coverage
- users can leverage all the ostestr/stestr features
Change-Id: I75f539457dbb1d811fdee69de52d1bcee4c6ebe6
Depends-On: Ica838db23b5714c2da1e4313e1a7ece0ca241d44
Closes-Bug: #1666232
pydot2 is incompatible with python3[1]. Bumping the pydot release (through
the test-requirements.txt) rather than pinning basepython to fix this.
Also updating the states.svg with the tox -egenstates result of running
pydot3
[1] https://github.com/erocarrera/pydot/issues/107
Change-Id: I9aa0e701af3915b39e1a5681c2105a6afb687dd2
Depends-On: I82e3651eefd3186c9e131b0db29a328967fb3161
Use the flake8 plugin flake8-import-order to check import ordering. It
can do it automatically and don't need reviewers to check it.
Change-Id: I9ced9c297273db0eec6ab3995b663b1e8dffe87d
Use hacking 0.12.0
Use the new checks that are available:
[H106] Don’t put vim configuration in source files.
[H203] Use assertIs(Not)None to check for None.
[H904] Delay string interpolations at logging calls.
Fix code so tests pass.
Change-Id: I7b1cd98aeb3bb8f4f01dd1d69d1afcd839749074
Hacking's latest release is 0.11.0. Most other ironic projects are using
this release.
These updates are done project-by-project to avoid introducing
unexpected new hacking rules to projects. This version bump already
applies cleanly to ironic-inspector with no code style changes.
Change-Id: Iebb95fdb9147f1c52d795ce7978095f9873f931d
Tests for database migrations. There are "opportunistic" tests here,
supported backends are sqlite (used in test environment by default),
mysql and postgresql, which are required properly configured unit
test environment.
Change-Id: I660fad241c71f2e73b41f317d00adf97551579c6
Shameless copy-paste from Ic700d719242b17532b0b43a68b7eff507cb3a43c
and Iaef8b78802c04ec8306dd6f1da02d6c6a50697d8 with minimal changes.
Change-Id: I604136b72e2cf6b2bbbc3f9dc46ea3b419e495df
Using client library here is not convenient, as it does not have
new features we need to test. Also we should only test API itself.
Instead, we'll use new Base class and mocked_server context manager
to build a separate functional test for client.
Change-Id: I44250d3df0d202e5fe5f94e6ec553a1f86053637
With integration tests on the radar we no longer need to do
integration checking between ramdisk code and inspector here.
Also copy integration test script from functest to devstack.
Once we update the gate to use the new script, the whole functest
directory should be deleted.
Change-Id: Ic29e954fac1c535cb4f83d46ccea9ebfb80f840c
Closes-Bug: #1468748