openstack
/
ironic-specs
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1 Workflow-1

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 10342 <10342@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 6f104c81fd3a981d50b72343b3bee3e7869a3a3d
Label: Workflow=-1, f70793d340d74e719dbc567fe3e3193cfd929019
Attention: {"person_ident":"Gerrit User 10342 \u003c10342@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_10342\u003e replied on the change"}
This commit is contained in:
Gerrit User 10342 2024-05-03 14:52:50 +00:00 committed by Gerrit Code Review
parent 52760fe115
commit bb6cf1b31e
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
f20835d47685a7069fcbde0bc077c6b5bbc93ce0
View File

@ -16,6 +16,23 @@
"message": "Not sure what error are you seeing, I just ran tox docs command on my system with python 3.12.2 and it went well\nbesides that, I don\u0027t think pinning a python version would help in this case, it would probably cause potential issues due to excluding all the other versions we\u0027re testing in CI.\nA solution could be defining an env variable that can be overridden and set its default to system python.\nsomething like:\nbasepython \u003d {env:TOX_PYTHON:python}\nunder testenv",
"revId": "f20835d47685a7069fcbde0bc077c6b5bbc93ce0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "05807848_90b47de3",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 10342
},
"writtenOn": "2024-05-03T14:52:50Z",
"side": 1,
"message": "Interesting, I\u0027ll dig deeper",
"revId": "f20835d47685a7069fcbde0bc077c6b5bbc93ce0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}