9441 Commits

Author SHA1 Message Date
Vladyslav Drok
1ad73338b8 Do not wait for console being started on timeout
Current logic tries to call communicate on Popen object when
starting shellinabox console even if console.subprocess_timeout
is hit. This blocks until the command is finished, with timeout
having no effect on it. It means that node lock is not released
until communicate call finishes.

Story: 2006429
Task: 36333
Change-Id: Ic7b878cd432990218a3d87047905ce0828b8da2a
2019-08-23 11:53:13 +00:00
Zuul
028ab71d3f Merge "Do not tear down node upon cleaning failure" 2019-08-15 21:14:32 +00:00
Zuul
20ca7d7cbf Merge "Add filename parameter to Redfish virtual media boot URL" 2019-08-15 03:59:37 +00:00
Zuul
e2c5e9da18 Merge "Add set_boot_device hook in redfish boot interface" 2019-08-15 03:55:14 +00:00
Zuul
4564aa9f19 Merge "Add Redfish Virtual Media Boot support" 2019-08-15 03:30:02 +00:00
Zuul
95a140a54c Merge "Enable testing software RAID in the standalone job" 2019-08-14 17:14:15 +00:00
Zuul
bc306dd7d4 Merge "Ansible: fix partition_configdrive for logical root_devices" 2019-08-14 13:44:40 +00:00
Ilya Etingof
046399ee63 Add filename parameter to Redfish virtual media boot URL
Some BMCs seem to validate virtual media boot image URL requiring
that URL to end with something resembling ISO image file name
(perhaps, its suffix i.e. extension).

This patch tries to add, hopefully, meaningless `filename`
parameter to boot URL's query string in hope to make the entire boot
image URL looking more convincing to the BMC.

Change-Id: I316712b38d10c0e801f7fd96a584074c8918b46b
Story: 1526753
Task: 10389
2019-08-14 14:20:38 +02:00
Ilya Etingof
b73420ec53 Add set_boot_device hook in redfish boot interface
Added `_set_boot_device()` method to `redfish` boot interface to
let future fishy hardware types reusing standard `redfish`
implementation modulo setting boot device procedure.

With Redfish, it seems, setting node to boot from Cd implies booting
from either virtual or physical CD depending on media presence in
either of the devices.

Change-Id: I576b90be46f9cadf1a051e17c95a98aefc83fe1f
2019-08-14 14:20:26 +02:00
Ilya Etingof
9fab96fc37 Add Redfish Virtual Media Boot support
This patch introduces standard Redfish virtual media boot
support to ironic.

The patch implements basic boot interface features along with
devstack plugin support for virtual media boot. Functionally,
redfish boot interface supports the same set of features as PXE.

Unlike other virtual media boot implementations (e.g. iLo), this
patch does not require user-built deploy/rescue/boot ISO images
for virtual media boot. Instead, ironic will build necessary images
out of common kernel/ramdisk pair (though user needs to provide
ESP image).

Story: 1526753
Task: 10389
Co-Authored-By: Shivanand Tendulker <stendulker@gmail.com>
Change-Id: I0db0a64c5ccf260f5a0695dbe994af1e11f71517
2019-08-14 14:19:03 +02:00
Zuul
33acfa2d1b Merge "Add deploy steps for Redfish BIOS interface" 2019-08-14 08:42:46 +00:00
Arne Wiebalck
f5a676a608 Do not tear down node upon cleaning failure
In case of a failure during cleaning, ironic currently shuts the
node off. This is dangerous, e.g. when the cleaning step is a
firmware upgrade. This patch proposes to corect this behaviour
and leave the node on in case cleaning raises an exception.

Task: #30357
Story: #2005375
Change-Id: I5fe8b380c890eb9b9dcee33868ceda2a9bab9929
2019-08-13 16:55:32 +02:00
Dmitry Tantsur
27f7143eb9 Switch non-multinode jobs to new-style neutron services
Change-Id: I62f462986f0f3976cdd8ac72f0e86afea07760cd
2019-08-13 11:16:55 +02:00
Shivanand Tendulker
991f9ccec1 Add deploy steps for Redfish BIOS interface
Change-Id: I49b27921736d30ad40b31dd69147d70fc901b4a4
Co-Authored-By: Shivanand Tendulker <stendulker@gmail.com>
Story: 1722275
Task: 29904
2019-08-13 02:14:35 -04:00
Raphael Glon
ff3f328f0b Ansible: fix partition_configdrive for logical root_devices
If the node root_device is a logical drive (like an md array, or a
logical volume), partition_configdrive.sh was not working correctly.

Change-Id: Ida4f91efba0f38f20cd80dd6b6162a77af8d6b78
Story: #2006334
Task: #36082
2019-08-13 02:21:07 +02:00
Zuul
ce163996ce Merge "Asynchronous out of band deploy steps fails to execute" 2019-08-12 15:48:15 +00:00
Zuul
61a58ec249 Merge "Enable no IP address to be returned" 2019-08-12 10:57:43 +00:00
Zuul
cef7ee08d0 Merge "Docu: Fix broken link" 2019-08-12 06:56:07 +00:00
Zuul
227290004d Merge "DRAC : Fix issue for RAID-0 creation for multiple disks for PERC H740P" 2019-08-10 00:33:05 +00:00
Andreas Jaeger
9eccadbf19 Docu: Fix broken link
Fix broken RST that generated a link to
https://docs.openstack.org/../tools/link_aggregation_on_windows.ps1
which does not exist. Instead link to the file in git.

Change-Id: I4d941f9f39e49dcd997c1a82c9a2aba42c8a468a
2019-08-09 21:40:40 +02:00
Zuul
007c7babb9 Merge "devstack: allow creating more than one volume for a VM" 2019-08-09 17:48:08 +00:00
Zuul
3ad32718ea Merge "Fixing broken links" 2019-08-09 15:42:26 +00:00
Zuul
f8bd138a14 Merge "Uses IPA-B to build in addition to CoreOS" 2019-08-09 12:22:53 +00:00
Alexandra Settle
c740ae0a2f Fixing broken links
Change-Id: Ie3b699a0010c88366a0814db28fc7cbac123a8b2
Backport: stein rocky
2019-08-09 11:45:36 +00:00
Pradip Kadam
81e4da55b9 DRAC : Fix issue for RAID-0 creation for multiple disks for PERC H740P
Story: 2006375
Task: 36164

Fix a bug which was introduced when executing ``create_configuration``
cleaning step for multiple disks of PERC H740P controller, first disks
gets created and then controller doesn't allow to create next couple
of disks because controller is getting busy at one time.

Change-Id: I02ec595e639c04dd65ce788851c5dde074cc1095
2019-08-09 04:52:56 +00:00
Nisha Brahmankar
d62c3f4fa5 Uses IPA-B to build in addition to CoreOS
Depends-On: https://review.opendev.org/#/c/669213/
Task: 30073
Story: 2005114

Change-Id: I39f33f748c6c25ff1f4a543beb59231ea8b7f30f
2019-08-08 19:58:36 +05:30
Zuul
b8db11279e Merge "Clean up RAID documentation" 2019-08-08 06:21:48 +00:00
Shivanand Tendulker
8f907886a1 Asynchronous out of band deploy steps fails to execute
Asynchronous out of band steps in a deploy template fails to
execute. This commit fixes that issue. Asynchronous steps can
set 'skip_current_deploy_step' flag to False in
'driver_internal_info' to make sure that upon reboot same step
is re-executed. Also it can set 'deployment_reboot' flag to True
in 'driver_internal_info' to signal that it has rebooted the node.

Co-Authored-By: Mark Goddard <mark@stackhpc.com>
Change-Id: If6217afb5453c311d5ca71ba37458a9b97c18395
Story: 2006342
Task: 36095
2019-08-07 15:42:28 -04:00
Dmitry Tantsur
7a3d9a664e Clean up RAID documentation
* Use more copy-paste friendly indentation in the examples
* Use subheadings for properties
* Render JSON examples as JSON
* Remove explicit API version from CLI, we've been defaulting
  to latest for several releases.
* Small fixes

Change-Id: I1cae6e9b4ff124e3404bd55638bc77bdf3465fe0
2019-08-07 18:26:22 +02:00
Dmitry Tantsur
2f7de3264c Enable testing software RAID in the standalone job
Change-Id: Id5cc1854492df230e6657bc8450c49a52f21ac16
Depends-On: https://review.opendev.org/#/c/675064/
2019-08-07 14:11:04 +02:00
Dmitry Tantsur
c7bd03cf68 devstack: allow creating more than one volume for a VM
This is needed to easily test software RAID.

Change-Id: Ia1bc81db97c6d5d1f79c4e1cfea1ab29fd988c3f
2019-08-07 09:13:56 +02:00
Dmitry Tantsur
f06240f7dd Allow configuring global deploy and rescue kernel/ramdisk
The devstack plugin was updated to configure basic ops before
ironic starts, so that we can put links to deploy images
in the ironic.conf.

Change-Id: I305fc3712b1ac0cf2fe64569729e236c7b614bb4
Story: #2006175
Task: #35699
2019-08-06 15:31:19 +02:00
Zuul
71b7441b78 Merge "iLO firmware update fails with 'update_firmware_sum' clean step" 2019-08-05 15:23:42 +00:00
Zuul
8cde536692 Merge "Fix missing print format error" 2019-08-05 11:41:18 +00:00
Zuul
9ac0f19950 Merge "Use HTTPProxyToWSGI middleware from oslo" 2019-08-05 11:41:13 +00:00
Zuul
9abf931bfd Merge "RAID creation fails with 'ilo5' RAID interface" 2019-08-05 10:21:49 +00:00
zhu.fanglei
c23a96d741 Fix missing print format error
Missing print format will cause 'ValueError: unsupported
format character' error, this is to fix it.

Change-Id: I43fca1f5bd1bcde3a5254f94c348ddafeb917283
2019-08-05 10:52:48 +08:00
Zuul
d10b0ab496 Merge "Enable testing adoption in the CI" 2019-08-03 11:08:29 +00:00
Zuul
aded2c8b31 Merge "Follow-up to the IntelIPMIHardware patch" 2019-08-02 23:08:24 +00:00
Zuul
7e0441bbb1 Merge "Update software RAID configuration documentation" 2019-08-02 21:18:01 +00:00
Dmitry Tantsur
521c086853 Update software RAID configuration documentation
This provides a bunch of updates based on user testing of the feature.
Also the lines are wrapped and inter-document links are created.

Change-Id: Ia3408aee3ebcd4ad5deedaa48967f46134ad2cfc
2019-08-02 17:50:20 +02:00
Zuul
2637e59a84 Merge "Use openstacksdk for accessing ironic-inspector" 2019-08-02 14:48:39 +00:00
Pavlo Shchelokovskyy
5e8c966a40 Use HTTPProxyToWSGI middleware from oslo
currently it is impossible to use ironic-api for both internal and
public api at the same time when both of those are using (ssl
terminating) proxies as there's only one config option to override the
resource url's in responses ([api]public_endpoint).

This patch adds the http_proxy_to_wsgi middleware from oslo.middleware
to the ironic API service, which, with properly configured proxies,
makes the choice of correct URL automatic, and thus makes such scenario
possible.

As this middleware may potentially not properly handle some
endpoint URL schemas, leave the api.public_endpoint option as a backup,
but it will be ignored when proxy headers parsing is enabled.

Change-Id: I3ce6b0726b479c2835f8777957b2cb12d8098aec
Story: #2006303
Task: #36019
2019-08-02 12:29:37 +00:00
Zuul
c29f1a5c3f Merge "Ansible driver: fix deployment with serial specified as root device hint" 2019-08-02 11:17:14 +00:00
Zuul
83405aab92 Merge "RAID create fails if 'controller' is missing in 'target_raid_config'" 2019-08-02 10:56:56 +00:00
Zuul
309e87b15a Merge "Creation of UEFI ISO fails with efiboot.img" 2019-08-01 23:27:29 +00:00
Zuul
ad802b441c Merge "Fixes power-on failure for 'ilo' hardware type" 2019-08-01 18:32:47 +00:00
Shivanand Tendulker
6305ea7007 RAID creation fails with 'ilo5' RAID interface
RAID interface methods do not clear driver_internal_info properly
leads to failure of RAID operation when they are attempted again.

Change-Id: I3cd133fb700ec4946471d9e4cbebeab4bded4540
Story: 2006321
Task: 36052
2019-08-01 08:57:07 -04:00
Shivanand Tendulker
b304d18802 RAID create fails if 'controller' is missing in 'target_raid_config'
RAID creation fails with KeyError if none of the 'logical_disks'
in 'target_raid_config' have 'controller' parameter.

Story: 2006316
Task: 36043
Change-Id: I42ee6a46c002c14c785216834558223cbf9d319b
2019-07-31 13:14:14 -04:00
Dmitry Tantsur
d6774c294d Use openstacksdk for accessing ironic-inspector
Change-Id: Ibe4f6bf0b38364b5dd214e6c7e58d45a4d71ffdf
2019-07-31 15:23:39 +02:00