openstack/kolla-ansible
Code Issues Proposed changes

Fix HAProxy monitor VIP precheck

Browse Source 
If haproxy is running somewhere in the cluster and listening on the VIP,
but not running locally, then the following precheck may fail:

   TASK [haproxy : Checking free port for HAProxy monitor (vip interface)]

   msg: Timeout when waiting for 192.0.2.10:61313 to stop.

This change fixes the issue by skipping the check if HAProxy is running
on any host.

Change-Id: I831eb2f700ef3fcf65b7e08382c3b4fcc4ce8d8d
Closes-Bug: #1866617
This commit is contained in:
Mark Goddard 2020-03-09 11:27:25 +00:00
parent 15afa61397
commit 93a4dcc1b9
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ansible/roles/haproxy/tasks/precheck.yml
View File

@ -199,7 +199,7 @@
state: stopped state: stopped
when: when:
- enable_haproxy | bool - enable_haproxy | bool
- container_facts['haproxy'] is not defined - "host_running_haproxy == 'None'"
- inventory_hostname in groups['haproxy'] - inventory_hostname in groups['haproxy']
- api_interface_address != kolla_internal_vip_address - api_interface_address != kolla_internal_vip_address

6
releasenotes/notes/fix-haproxy-monitor-precheck-487b85f4e93313b1.yaml Normal file
View File

@ -0,0 +1,6 @@
---
fixes:
- |
Fixes an issue with the HAProxy monitor VIP precheck when some instances of
HAProxy are running and others are not. See `bug 1866617
<https://launchpad.net/bugs/1866617>`__.