openstack
/
manila-tempest-plugin
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 36180 \u003c36180@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_16643\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 16643 \u003c16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_16643\u003e replied on the change"}
This commit is contained in:
Gerrit User 16643 2023-10-31 22:25:52 +00:00 committed by Gerrit Code Review
parent ddbb24650d
commit 76e9bbc011
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
ba3acbfc1109eb3b957437d6c8c943c2675072e2
View File

@ -452,6 +452,30 @@
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "276e6e25_1b6d3d7e",
"filename": "manila_tempest_tests/tests/api/base.py",
"patchSetId": 1
},
"lineNbr": 213,
"author": {
"id": 16643
},
"writtenOn": "2023-10-31T22:25:52Z",
"side": 1,
"message": "Hi Gireesh, \n\n\n\u0027provide_and_associate_security_services\u0027 is meant to be invoked optionally: \nhttps://opendev.org/openstack/manila-tempest-plugin/src/commit/4a2f09514f39927a4deb1b3060dd9312037d09e1/manila_tempest_tests/tests/api/base.py#L747\n\nso, if you have a use case where there\u0027s no need to add security services, you just wouldn\u0027t call it.",
"parentUuid": "8e0cdfb4_b826d527",
"range": {
"startLine": 208,
"startChar": 8,
"endLine": 213,
"endChar": 18
},
"revId": "ba3acbfc1109eb3b957437d6c8c943c2675072e2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}