openstack/monasca-specs
Code Issues Proposed changes

Update patch set 9

Browse Source 
Patch Set 9:

(1 comment)

Patch-set: 9
Label: Verified=0
This commit is contained in:
Gerrit User 11580 2018-08-07 17:35:51 +00:00 committed by Gerrit Code Review
parent a2f0131cdc
commit 3d953a8d8b
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
69d06bb96e9d6a2da0074c5766a6d13da585200e
View File

@ -631,6 +631,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_94568b29",
"filename": "specs/rocky/approved/monasca-events-publishing.rst",
"patchSetId": 9
},
"lineNbr": 403,
"author": {
"id": 11580
},
"writtenOn": "2018-08-07T17:35:51Z",
"side": 1,
"message": "generic way (like grepping for nova) might be hard to get right.\n\nWe could have leveraged Ceilometer event definition config file to say add trait which is a literal service name \u0027compute\u0027 to all \u0027compute.instance.*\u0027 events, but most likely that wont work because its likely the code expects it to be valid JSON dotted notation string, might be worth seeing if we can add ability to add (inject) a literal string as a trait to Ceilometer event.",
"parentUuid": "3f79a3b5_53dd7012",
"range": {
"startLine": 402,
"startChar": 3,
"endLine": 403,
"endChar": 45
},
"revId": "69d06bb96e9d6a2da0074c5766a6d13da585200e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_1e4f3a69",