openstack/neutron-vpnaas
Code Issues Proposed changes

Remove redundant topic from rpc calls

Browse Source 
RpcProxy sets by default topic=self.topic, there's no need to specify
it explicitly in derived class, unless it is overridden

Change-Id: I19b9a67072a7f3c42e3b0e4ba412241a056a79a3
Closes-bug: 1348180
This commit is contained in:
rossella
2014-07-23 19:26:12 +00:00
committed by Rossella Sblendido
parent b706e072cb
commit 49a274542d
2 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
neutron/services/vpn/device_drivers/cisco_ipsec.py
View File

@@ -161,15 +161,13 @@ class CiscoCsrIPsecVpnDriverApi(n_rpc.RpcProxy):
"""
return self.call(context,
self.make_msg('get_vpn_services_on_host',
host=host),
topic=self.topic)
host=host))
def update_status(self, context, status):
"""Update status for all VPN services and connections."""
return self.cast(context,
self.make_msg('update_status',
status=status),
topic=self.topic)
status=status))
@six.add_metaclass(abc.ABCMeta)

6
neutron/services/vpn/device_drivers/ipsec.py
View File

@@ -454,8 +454,7 @@ class IPsecVpnDriverApi(n_rpc.RpcProxy):
return self.call(context,
self.make_msg('get_vpn_services_on_host',
host=host),
version=self.IPSEC_PLUGIN_VERSION,
topic=self.topic)
version=self.IPSEC_PLUGIN_VERSION)
def update_status(self, context, status):
"""Update local status.
@@ -466,8 +465,7 @@ class IPsecVpnDriverApi(n_rpc.RpcProxy):
return self.cast(context,
self.make_msg('update_status',
status=status),
version=self.IPSEC_PLUGIN_VERSION,
topic=self.topic)
version=self.IPSEC_PLUGIN_VERSION)
@six.add_metaclass(abc.ABCMeta)