18582 Commits

Author SHA1 Message Date
Jenkins
177c665052 Merge "Switch to olso.messaging:get_rpc_transport" 2017-06-15 21:52:25 +00:00
Jenkins
1bbb8a421d Merge "Send port ID in network-changed event to Nova" 2017-06-15 17:22:36 +00:00
Jenkins
a56fcd6728 Merge "Trigger port status DOWN on VIF replug" 2017-06-15 14:58:56 +00:00
Jenkins
2d752108d0 Merge "Fix test_dvr_gateway_host_binding_is_set" 2017-06-15 11:56:14 +00:00
Kevin Benton
0d7952400b Trigger port status DOWN on VIF replug
Now with the merge of push notifications, processing a port update
no longer automatically implies a transition from ACTIVE to BUILD
to ACTIVE again.

This resulted in a bug where Nova would unplug and replug an interface
quickly during rebuild and it would never get a vif-plugged event.
Nothing in the data model was actually being updated that resulted in
the status being set to DOWN or BUILD and the port would return before
the agent would process it as a removed port to mark it as DOWN.

This fixes the bug by making the agent force the port to DOWN whenever
it loses its VLAN. Watching for the VLAN loss was already introduced
to detect these fast unplug/plug events before so this just adds the
status update.

Closes-Bug: #1694371
Change-Id: Ice24eea2534fd6f3b103ec014218a65a45492b1f
2017-06-15 02:48:11 -07:00
Jenkins
c507656044 Merge "Integrate Security Groups OVO" 2017-06-15 07:37:38 +00:00
Kevin Benton
803f7b8544 Fix test_dvr_gateway_host_binding_is_set
Router scheduling was happening before the schedule call
so sometimes the router was being scheduled to a different
host than the test was expecting.

This fixes it by explicitly setting the router to not be HA
and calls schedule before adding interfaces that would trigger
scheduling.

Closes-Bug: #1698058
Change-Id: I6c6319f1da72546a9d21af198daf9a2a67e6dec8
2017-06-15 00:25:35 -07:00
Jenkins
920c2f6afa Merge "Add myself to the list of our Infra liaison" 2017-06-15 05:51:46 +00:00
Jenkins
0f2bb3ca1d Merge "Add a dashboard for Infra reviews" 2017-06-15 05:51:31 +00:00
Jenkins
4b4fdee678 Merge "Integration of Allocation/Endpoints OVO" 2017-06-15 03:20:09 +00:00
Jenkins
817ca843fa Merge "Add support for ingress bandwidth limit rules in ovs agent" 2017-06-15 03:19:53 +00:00
Jenkins
1720468638 Merge "DVR: Fix DVR Router snat ports and gateway ports host binding issue" 2017-06-14 22:43:09 +00:00
Jenkins
0ec5c033c2 Merge "Drop IPv6 Router Advertisements in OVS firewall" 2017-06-14 21:42:36 +00:00
Anindita Das
995e646b11 Integration of Allocation/Endpoints OVO
This patch integrates the Oslo-Versioned Objects created for
VlanAllocation, VxlanAllocation, VxlanEndpoints, GreAllocation,
GreEndpoints, GeneveAllocation and GeneveEndpoints into the
code base.

Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db
Change-Id: I0d592bae452876b24c28ca4cc4bf6392b5ab6493
Co-Authored-By: Victor Morales <victor.morales@intel.com>
2017-06-14 20:24:58 +00:00
Jenkins
74b126dc44 Merge "[log]: db models and migration rules" 2017-06-14 19:01:01 +00:00
Jenkins
ab8555a2ff Merge "Reduce extension logging on init" 2017-06-14 18:51:56 +00:00
Jenkins
02d94aaec6 Merge "Stop arping when interface gets deleted" 2017-06-14 18:35:16 +00:00
Kevin Benton
7737e69809 Fix usage of registry.receives in Nova notifier
Receives expects a list of events for each resource.

TrivalFix
Change-Id: I4a39f2e9d2f10639a209e7311fe44b94d369c5b1
2017-06-14 12:56:57 +00:00
Jenkins
1a8901a1ed Merge "Retry ebtables lock acquisition failures" 2017-06-14 12:25:23 +00:00
Sławek Kapłoński
2d0d1a2d76 Add support for ingress bandwidth limit rules in ovs agent
Add support for QoS ingress bandwidth limiting in
openvswitch agent.
It uses default ovs QoS policies on bandwidth limiting
mechanism.

DocImpact: Ingress bandwidth limit in QoS supported by
           Openvswitch agent

Change-Id: I9d94e27db5d574b61061689dc99f12f095625ca0
Partial-Bug: #1560961
2017-06-14 11:11:43 +00:00
Kevin Benton
355dab604a Reduce extension logging on init
Reduce from 4 separate lines into 1

TrivialFix

Change-Id: I137944fe4c6cfbb1e27ad4e4a233d4220642f3e4
2017-06-14 02:03:08 -07:00
Jenkins
044a06383b Merge "Stop using nested transactions in OVO get/delete" 2017-06-14 08:40:38 +00:00
Jenkins
18cffe63ae Merge "Add libffi-dev to bindep.txt" 2017-06-14 07:47:42 +00:00
Kevin Benton
2e7b787f0e Retry ebtables lock acquisition failures
It seems after the merge of
https://bugs.launchpad.net/ubuntu/+source/ebtables/+bug/1645324
that ebtables can fail to acquire a lock and bail with an error
255. This adds some retry logic to retry it up to 10 times to
work around this issue.

Closes-Bug: #1697833
Change-Id: Ic9dcf4b236a93e8811413c6ce2c4b82602544c6d
2017-06-13 22:50:19 -07:00
YAMAMOTO Takashi
5c2e607dd5 Add a dashboard for Infra reviews
Generated from https://review.openstack.org/#/c/473683/

Change-Id: I0ff12d258e4ad048199ebb593fbb92224f9ca528
2017-06-14 12:11:58 +09:00
YAMAMOTO Takashi
fc72c0ceb8 Add myself to the list of our Infra liaison
I hereby volunteer.

Change-Id: Ie1279637b10214f69b8038617b4ec556425e06d9
2017-06-14 12:07:17 +09:00
Jenkins
ce33de5f51 Merge "Do not defer allocation if fixed-ips is in the port create request." 2017-06-14 00:46:00 +00:00
Jenkins
e8597e05e0 Merge "Remove unused class 'QoSPolicyDefaultNotFound'" 2017-06-13 19:55:49 +00:00
Jenkins
f7efec5c25 Merge "Switch to start_all_workers in RPC server" 2017-06-13 19:37:32 +00:00
sayalilunkad
af52d499a5 Integrate Security Groups OVO
Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db
Change-Id: I2d43ad79eb004e68866050fbd63d166920b9f2b0
Co-Authored-By: Ihar Hrachyshka <ihrachys@redhat.com>
Co-Authored-By: Victor Morales <victor.morales@intel.com>
Co-Authored-By: Manjeet Singh Bhatia <manjeet.s.bhatia@intel.com>
2017-06-13 19:27:27 +00:00
Akihiro Motoki
8e8f721f6f Add libffi-dev to bindep.txt
libffi-dev is required to install cffi and PyNaCL from tarballs.
cffi is installed from requirements.txt, so 'test' profile is not
specified.

We usual use wheel packages when installing python packages,
but tarball is sometimes used, for example, when a new version
is uploaded. I think it is worth adding it to bindep.txt
to avoid accidental gate failure.

Closes-Bug: #1697613
Change-Id: I4800c9f213fa5c8f28c8603e022264e6aa139090
2017-06-13 19:26:49 +00:00
Swaminathan Vasudevan
abe9938367 DVR: Fix DVR Router snat ports and gateway ports host binding issue
DVR snat ports and gateway ports are not bound to any host
and so we don't see the snat namespace getting created.

The issue is the _build_routers_list in l3_dvr_db.py is not called due
to the inheritance order.

Change-Id: I56f9de31524aeef262cf2a78be3abf8487c21a12
Closes-Bug: #1695101
2017-06-13 10:25:58 -07:00
Jenkins
36926a4192 Merge "Don't log about no notification on GET requests" 2017-06-13 16:54:18 +00:00
Jenkins
fd0003aba7 Merge "Set HA network port to DOWN when l3 agent starts" 2017-06-13 12:47:20 +00:00
Jenkins
0a8b8d4fdc Merge "neutron-rpc-server fails with no plugins loaded" 2017-06-13 11:45:22 +00:00
Jenkins
1048d31108 Merge "Revert "Use vif_type='tap' for LinuxBridge for consistency"" 2017-06-13 11:45:09 +00:00
Kevin Benton
72ac25c929 Stop using nested transactions in OVO get/delete
Nested transactions have unnecessary overhead of starting
new transactions in the database and the only place we need
them are where we expect duplicate violations during create/update.

This gets rid of them for get_objects and delete_objects so we
don't adopt additional unnecessary overhead in OVO adoption. Before
this patch, update_port calls were resulting in several independent
nested transactions that each require multiple round trips to the
database.

Change-Id: Icbfe678b6f6ebcdcd7f7ca71f6ac5febb64bdaa3
Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db
2017-06-13 04:17:41 -07:00
Jenkins
80cddec09e Merge "Mask password when logging request body" 2017-06-13 09:23:06 +00:00
Kevin Benton
57a37c4a87 Switch to start_all_workers in RPC server
This does the same as the logic present but it emits
the registry callback event for resources.PROCESS AFTER_SPAWN
that some plugins may be expecting.

Change-Id: I6f9aeca753a5d3c0052f553a2ac46786ca113e1e
Related-Bug: #1687896
2017-06-13 02:20:35 -07:00
Kevin Benton
79d7f76964 Don't log about no notification on GET requests
The pecan notifier hook was logging on every GET request
that it wasn't doing anything, which led to excessive logging.
This just eliminates it.

TrivialFix

Change-Id: Ie1262b54595f40f69c6859a09850845826ee8f14
2017-06-12 20:19:40 -07:00
Nguyen Phuong An
ae791696b8 [log]: db models and migration rules
This patch includes db models and migration rules for initial
logging object. The implementation bases on logging api for
security group spec[1]

[1] https://goo.gl/t3NUlr

Partially-implements: blueprint security-group-logging
Related-Bug: #1468366

Change-Id: I3f91b3927c33021facc9eb9238555c0e06a918c0
2017-06-13 08:52:12 +07:00
Jenkins
31d24b4e1a Merge "Fix html_last_updated_fmt for Python3" 2017-06-12 19:25:36 +00:00
Jenkins
016a809e4f Merge "Use e.exc_type instead of calling str on exception" 2017-06-12 19:24:06 +00:00
Roey Chen
f5f8a75963 Mask password when logging request body
Change-Id: I825ab268c140b991e39583cd2c2d557a202b7d97
Closes-Bug: #1697408
2017-06-12 05:36:23 -07:00
Luong Anh Tuan
d5da2b5677 Remove unused class 'QoSPolicyDefaultNotFound'
This patch removes the dead code from neutron.

Change-Id: If5c7b0c81280218fe46f6c06076e9b268fd83d5f
2017-06-12 18:00:04 +07:00
Jenkins
3984c3fd1e Merge "Remove redundant code in QosServiceDriverManager" 2017-06-12 10:28:49 +00:00
Kevin Benton
cf4e857dd2 Use e.exc_type instead of calling str on exception
This fixes the usage of the oslo RemoteError exception checking
in the Linux Bridge trunk driver to stop calling 'str' on the
exception and just check the 'exc_type' attribute like we do
in the other agent code so it's safe to use with unicode.

Change-Id: I352ed422550343118319f8e83c4979f290f161f0
Closes-Bug: #1697383
2017-06-12 01:36:59 -07:00
Nguyen Phuong An
3ea08fe54b Remove redundant code in QosServiceDriverManager
I don't see notification_api [1] is used anywhere and it
duplicate with push_api[2]. So this patch-set removed it.

[1]https://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/manager.py#L41
[2]https://github.com/openstack/neutron/blob/master/neutron/services/qos/drivers/manager.py#L50

TrivialFix
Change-Id: Ib31c320f7486738190d27cf41e16a5f93e524039
2017-06-12 01:18:50 +00:00
Jenkins
01cc2696b7 Merge "Change allowed directions for QoS min-bw rule in SR-IOV" 2017-06-11 18:15:28 +00:00
Harald Jensas
33e48cf84d Do not defer allocation if fixed-ips is in the port create request.
Fix a usage regression, use case #2 in Nova Neutron Routed Networks spec
https://specs.openstack.org/openstack/nova-specs/specs/newton/implemented/neutron-routed-networks.html

Currently ip allocation is always deferred if binding:host_id is not
specified when routed networks are used. This causes initial fixed-ips
data provided by the user to be _lost_ unless the user also specify the
host.

Since the user specified the IP or Subnet to allocate in, there is no
reason to defer the allocation.

a) It is a common pattern, especially in Heat templates to:
 1. Create a port with fixed-ips specifying a subnet.
 2. Create a server and associate the existing port.
b) It is also common to use Neutron IPAM as a source to get VIP
   addresses for clusters on provider networks.

This change enables these use cases with routed networks.

DocImpact: "The Networking service defers assignment of IP addresses to
the port until the particular compute node becomes apparent." This is no
longer true if fixed-ips is used in the port create request.

Change-Id: I86d4aafa1f8cd425cb1eeecfeaf95226d6d248b4
Closes-Bug: #1695740
2017-06-11 13:10:44 +00:00