19082 Commits

Author SHA1 Message Date
Jenkins
9629bd1302 Merge "Degrade log message for missing fanout exchange to debug" 2017-08-08 20:21:30 +00:00
Jakub Libosvar
03c100b959 Fill device_info with port_security_enabled data
Firewall drivers check if port security is enabled. After ovo is sent
over the wire, the port_security_enabled is part of 'security' field.
The patch translates the RPC call from agent to server so the payload
containing port_security_enabled is at the same place.

We may consider implementing change of OVO field to contain boolean
directly.

Change-Id: I647343e84b41da63d7ffcc5a87f3dfa2036adc56
Closes-bug: #1605654
2017-08-08 19:42:09 +00:00
Swaminathan Vasudevan
8b4bb9c0b0 DVR: Configure centralized floatingips to snat_namespace.
This patch is the agent side patch that takes care of configuring
the centralized floatingips for the unbound ports in the snat_namespace.

Change-Id: I595ce4d6520adfd57bacbdf20ed03ffefd0b190a
Closes-Bug: #1583694
2017-08-08 10:44:45 -07:00
Jenkins
5d5ebd0bd9 Merge "Don't check full subnet body in test_filtering_shared_subnets" 2017-08-08 15:54:44 +00:00
Jenkins
d224effd26 Merge "Do not use prelude section for individual release notes" 2017-08-08 11:25:46 +00:00
Ihar Hrachyshka
242b63be23 Don't check full subnet body in test_filtering_shared_subnets
Plugins may add attributes to subnets, in which case simple equality
check will fail. Instead of comparing bodies, compare just IDs. It
should be enough to achieve the goal of the test case.

Change-Id: Iebc22f99285777df7de499c713b2bc1e38e0bd62
Closes-Bug: #1706986
2017-08-08 11:17:19 +00:00
Nguyen Phuong An
6847790414 [log]: Add validator to logging api
This patch added a validator to logging api for checking resource bound
(sg or port is exist or not, ...) and validating whether or not supporting
logging type on each port when we create a log object by specific port_id.

Co-Authored-By: Yushiro FURUKAWA <y.furukawa_2@jp.fujitsu.com>

Change-Id: I10f2441fc2c7bdbda51b05002549b235743a7deb
Partially-implements: blueprint security-group-logging
Related-Bug: #1468366
2017-08-08 13:25:40 +07:00
Nguyen Phuong An
39a9ed4c50 [log]: add driver manager to LoggingPlugin
This patch adds driver manger to LoggingPlugin to manage
logging drivers are enabled belong ML2 dirvers.

Co-Authored-By: Yushiro FURUKAWA <y.furukawa_2@jp.fujitsu.com>

Change-Id: I5a0f896c9ec7f670b662f16825feccbc07db19dd
Partially-implements: blueprint security-group-logging
Related-Bug: #1468366
2017-08-08 13:18:09 +07:00
Ihar Hrachyshka
1da78c924e tests: apply latest release milestone alembic scripts first
Before walking through migration scripts that belong to the release
under development, we should first execute all scripts for the latest
official release because it serves a convergence point. Without it, we
can't guarantee that calling --expand will succeed because some of new
scripts may depend on schema state that is defined by contract scripts.

Change-Id: I501b38900fb2f4409839ecd09be4d937cf20c6a9
Related-Bug: #1671634
2017-08-07 10:09:13 -07:00
Akihiro Motoki
12d6a3ea4c doc: Fix non-existing URLs
Change-Id: I72c1c0fcb7cc541b87b184b32f0797539b919a44
Closes-Bug: #1708394
2017-08-06 23:19:05 +00:00
Jenkins
37bb9a41c4 Merge "Exclude relnote from past releases from Pike relnotes" 2017-08-04 16:53:01 +00:00
Akihiro Motoki
010b133938 Do not use prelude section for individual release notes
prelude section is prepared for general comments about a release [1].
At now neutron release notes use prelude section randomly.
Some rel notes use it and some do not.

This commit drop or move prelude section in Pike release notes.

In addition, some guideline on writing a release note
to the release notes howto page.

Change-Id: I53fefcc3eed30700d095c77d9e000319668097e8
2017-08-04 07:17:52 +00:00
Akihiro Motoki
6f1ecf2466 Exclude relnote from past releases from Pike relnotes
reno includes release notes touched in a target release
even if they are added from past releases.
The recent release note cleanup I made as part of doc8 adoption
and some other cleanup touched release notes from past releases.
As a result, we see several number of release notes from past
release in the Pike release notes unexpectedly.

Also adds a warning note to the release notes howto page

Change-Id: I127f96896488e9992d9309d76055b4883f6a62f3
Closes-Bug: #1708560
2017-08-04 07:16:57 +00:00
Jenkins
9d616f075c Merge "Sinkhole workaround for old topics" 2017-08-04 02:36:58 +00:00
Jenkins
1ad806fdaf Merge "Remove configuration options max_fixed_ips_per_port" 2017-08-04 01:59:43 +00:00
Jenkins
8f79a92e45 Merge "Bump network rev on RBAC change" 2017-08-03 21:53:39 +00:00
Jenkins
85e6294964 Merge "ovo_rpc: Avoid flooding logs with semantic violation warning" 2017-08-03 20:49:51 +00:00
Ihar Hrachyshka
62503dcb78 tests: don't set description in test_blank_update_clears_association
'description' attribute of floating IPs is part of
standard-attr-description API extension, so using it in the test case
without requiring the extension is incorrect. But instead of adding the
new requirement, this patch removes 'description' from the floating IP
payload because it's not needed to prove the point of the test case
(that an empty update body will disassociate the floating IP).

Change-Id: I9ab5b0ba5f32f73818f8eac8a0001eeb13248423
2017-08-03 12:39:59 -07:00
Jakub Libosvar
1d80c960f6 ovs-fw: Handle only known trusted ports
Similarly to filtered ports this patch caches so called trusted ports to
avoid processing in case of unknown port is passed down to firewall
driver. The cached ofport is used for removal as the cache reflects
currently installed flows.

The patch also catches exception caused by inconsistency coming from
ovsdb.

Closes-bug: #1707339

Change-Id: I15cdb28072835fcb8c37ae4b56fc8754375a807c
2017-08-03 18:29:09 +00:00
Gary Kotton
49a0555129 Remove configuration options max_fixed_ips_per_port
This was marked as deprecated in Newton.

Related-bug: #1502356

Change-Id: Iafaa340a9291e1ee84e776ddfffc5f870f7e67e2
2017-08-02 22:09:56 -07:00
Kevin Benton
0b5750ca51 Sinkhole workaround for old topics
This patch introduces a workaround on the Neutron side
for bug 1705351 that results in the Neutron server blocking
trying to send to topics the agents no longer subscribe to.

The workaround is to just subscribe to those topics and do
nothing with the messages that come in until oslo.messaging
can properly recover from loss of listeners.

Change-Id: I946a33dfd0c0da26bb47b524f75f53bf59d3fbd5
Closes-Bug: #1705351
2017-08-02 20:14:10 -07:00
OpenStack Proposal Bot
0adb29f0f0 Updated from global requirements
Change-Id: Ie8727686892488a9bc603b039d34d763b5be7b5c
2017-08-03 00:34:17 +00:00
Jenkins
f17fdf1743 Merge "Fix some pep8 errors under l3 unit tests" 2017-08-03 00:20:57 +00:00
Miguel Lavalle
1865f27a8b Remove code to debug auto address allocation error
Change If1eb4046865f43b15ba97c52e2d0b9343dc72c19 fixed bugs 1666493 and 1655567
that reported exception IpAddressAlreadyAllocated being raised during the
creation of IPv6 auto-address subnets. This patchset removes code that was
added by change I22b8f1f537f905f4b82ce9e50d6fcc5bf2210f9f to root-cause these
bugs.

By removing log statements, this patchset contributes to reduce the
'Neutron log obesity epidemic'

Change-Id: I28c58dc4a957df833d277f0d08ce831c7ee07c68
Partial-Bug: #1707307
2017-08-02 16:34:27 -05:00
Jenkins
a14aea8e87 Merge "devstack: fix ovs install on fedora like OS" 2017-08-02 20:43:28 +00:00
Ihar Hrachyshka
0b9748e1f9 Degrade log message for missing fanout exchange to debug
In upgrade scenario, this is a regular case (no agents created the
exchange, so fanout is ineffective), so logging it using ERROR level is
misleading and against guidelines.

Change-Id: If098071c9c19490af7eb0863dbab83e488019bd7
Related-Bug: #1705351
2017-08-02 11:37:06 -07:00
Jenkins
60b65a233b Merge "Don't log 'Exit code: 0'" 2017-08-02 17:42:50 +00:00
Kevin Benton
32814bb39e Bump network rev on RBAC change
Increment the revision number when RBAC policies are
changed since it impacts the calculation of the 'shared'
field.

Closes-Bug: #1708079
Change-Id: I4c7eeff8745eff3761d54ef6d3665cf3dc6e6222
2017-08-02 16:44:01 +00:00
Miguel Angel Ajo
0177568c93 devstack: fix ovs install on fedora like OS
This patch I3d0981fbe30f2436f00c200919b50aeb97491252
resolved custom kernel version, but introduced a bug
for the 3.x series. This patch avoids the replacement
in the case of the 3.x series.

Closes-Bug: #1704077

Co-Authored-By: Moshe Levi <moshele@mellanox.com>

Change-Id: Iff1c5a39fe4b0d9320910d0cfafdd36873825d03
2017-08-02 14:11:13 +00:00
Jenkins
90feab379a Merge "Catch exceptions for all rpc casts" 2017-08-02 06:43:02 +00:00
Jenkins
eb9aea3fc0 Merge "Change ovsdbapp vlog to INFO" 2017-08-02 00:57:18 +00:00
Jenkins
31675ddf91 Merge "Add bandit target to tox" 2017-08-01 21:41:17 +00:00
Jenkins
b046a39c2a Merge "docs: clarify wording about how to use advanced glance image" 2017-08-01 20:23:02 +00:00
Jenkins
c4587ef4d1 Merge "Enable QoS scenario tests" 2017-08-01 20:22:38 +00:00
Ihar Hrachyshka
99a12a2392 docs: clarify wording about how to use advanced glance image
This is to follow up on comments in
https://review.openstack.org/#/c/469838/

Change-Id: I59a0f63e56d972a2fadf5a4e0bf531ccf4da8dba
2017-08-01 08:56:45 -07:00
YAMAMOTO Takashi
fe0bb07113 Enable QoS scenario tests
This test has been disabled since [1].
But it seems the failure ratio is not so high with
the current code.  Let's re-enable it now and see how it goes.

Note: This same test has been enabled on the gate jobs for
other implementation for a while. It doesn't fail much there
either. (networking-midonet)

[1] I37f1488db258f6a4d383fb472cb5433c65371ac5

Related-Bug: #1662109
Change-Id: Ia39c73189ad8a3331c1911989fe69428f064f7a6
2017-08-01 06:54:17 +00:00
Jenkins
927edca4fd Merge "ovsfw: fix allowed_address_pairs MAC issue" 2017-08-01 06:06:58 +00:00
Jenkins
a5180a868b Merge "Use push notification for security groups" 2017-08-01 03:27:45 +00:00
Jenkins
43948318e6 Merge "Add auto-generated config reference" 2017-08-01 02:51:14 +00:00
jufeng
b7892b16b2 ovsfw: fix allowed_address_pairs MAC issue
Current ovsfw implementation does not take care of the different
MACs in allowed_address_pairs with the VM's MAC.
This patch use the following method to fix this issue:
1. Do not check dl_src in table=72 because table=71 has checked
dl_src for Egress.
2. Add all allowed MACs in table=0 and table=73 for Ingress.
3. Do not check dl_dst in table=82 because this check has done
in table=0 and table=73.
4. Delete allowed MACs in table=0 and table=73 when needed.

Change-Id: Iad59096f0c9855ebfd4a0d5b447e73b443d66c1d
Closes-Bug: #1697593
2017-08-01 01:47:46 +00:00
Jenkins
c3c43bedac Merge "ovs-fw: Update internal docs with TRANSIENT table" 2017-08-01 01:23:25 +00:00
Jenkins
ee6b03e1e0 Merge "Fixed FlushError on subnet creation retry" 2017-07-31 23:25:23 +00:00
Kevin Benton
d92dc1244e Change ovsdbapp vlog to INFO
This is to eliminate the following messages that fill the
OVS agent logs:

ovsdbapp.backend.ovs_idl.vlog [-] [POLLIN]

Change-Id: I00010ef600a4185b7628318bb88971d978b9fe67
Partial-bug: #1707307
2017-07-31 23:00:46 +00:00
Kevin Benton
72f7f1eaa8 Drop port_delete and port_update debug msgs
The push notification resource cache will already give us
the port update and delete notifications so there is no need
to log here now.

Change-Id: I6000691dfd61facf47d70360d4050cfdefc3e7e2
Partial-Bug: #1707307
2017-07-31 23:00:41 +00:00
Jenkins
07ebff05ad Merge "Check if record is stale after bulk pull" 2017-07-31 22:56:48 +00:00
Kevin Benton
ce8dbcff83 Don't log 'Exit code: 0'
A regular gate run shows this was logged ~2500 times.
It doesn't provide any useful information since the
command executed successfully and we can see the
issued command in the debug statement before it.

Partial-Bug: #1707307
Change-Id: I431d6a59ce36deb9a5fb9deef39655d28d71f24d
2017-07-31 15:46:57 -07:00
Jenkins
a0cc617d90 Merge "docs: Fix in TESTING.rst" 2017-07-31 21:24:20 +00:00
Kevin Benton
ec709767e6 Check if record is stale after bulk pull
We need to check if the results from a bulk_pull are stale because
the resource might have been updated and concurrently pushed from
the server while the bulk_pull query was being fulfilled.

Change-Id: I755a1cb2e0037ec2316161a09ad462bc4b09f397
Closes-Bug: #1707699
2017-07-31 11:29:40 -07:00
Gábor Antal
789acb3a7e Removed unnecessary setUp calls in tests
There are several places where base class setUp() method call was
called unnecessary. In this patchset, they are removed.

TrivialFix

Change-Id: I2961fa4a0216f7f1223ab87a249151f0feb91518
2017-07-31 17:16:01 +02:00
Tong Liu
cf3b963618 Fix some pep8 errors under l3 unit tests
TrivialFix

Change-Id: Ibd64ea7f70937caf83ceb4efc2ad52d00a66487c
2017-07-31 13:27:07 +00:00