17703 Commits

Author SHA1 Message Date
Jenkins
f9e5c2a726 Merge "Simple logging de-dup logic to RPC version_manager" 2017-02-14 19:32:09 +00:00
Jenkins
8cb0ab9815 Merge "Clean up inconsistent syntax" 2017-02-14 19:30:22 +00:00
Mark McClain
1e95cfa98a Invert device_owner to avoid filtering too much
In an earlier change[1], a filter was added to avoid Linuxbridge races
with Nova. This filter breaks anything else using device owners other
than n(eutron|etwork):.

[1] https://review.openstack.org/#/c/193485/

Closes-Bug: #1524004
Closes-Bug: #1664659
Change-Id: I31a8e0e255b8b0251c991d5e20a4b9441d4ec489
2017-02-14 10:19:53 -08:00
Terry Wilson
26766963c6 Clean up ovsdb-native's use of verify()
When updating an ovsdb set-type column, the existing code does
the following:

1. Read the existing column value
2. Call verify() to cause a write failure if something else
   modifies the column before we commit
3. Append the value to our local copy of the column
4. Assign the local value to the object.column to trigger
   __setattr__ to write the value to the database

If verify() fails, which it *very* often does in a test
environment or a busy system, ovsdb-server will respond with a
TRY_AGAIN response which will cause the whole process to start
over.

In the 2.6 cycle, Row.addvalue()/delvalue() methods were added
which use OVDB's native 'mutate' methods to handle adding/deleting
from a set/map-type column. Using these means calling verify() is
no longer required and things will proceed *much* more efficiently.

Bug #1627106 where we get frequent TimeoutExceptions appears to be
related. Eliminating the frequent TRY_AGAIN responses, in my local
testing, also eliminates the TimeoutExceptions. This doesn't mean
that the underlying issue is resolved, but it may be avoided.
Related-Bug: #1627106

Change-Id: I26c7731f5dbd3bd2955dbfa18a7c41517da63e6e
2017-02-14 09:34:36 -06:00
Jenkins
368ebb53b1 Merge "Only log IDs of callbacks in debug message" 2017-02-14 15:25:31 +00:00
Jenkins
c769ff613e Merge "[TrivialFix]Remove the file encoding which is unnecessary" 2017-02-14 13:30:19 +00:00
Kevin Benton
cc4c3aabc7 Simple logging de-dup logic to RPC version_manager
Addresses TODO to prevent the same debug message from being
dumped to the logs repeatedly.

This is comparing string formats of dictionaries, which should
be safe since the pprint module sorts dictionaries by key first:
https://docs.python.org/2/library/pprint.html

TrivialFix
Change-Id: I6887d6e29840f7ac023e42f1a95cb586c6986b47
2017-02-14 02:15:33 -08:00
Jakub Libosvar
1022c03051 fullstack: Fix race between updating port security and test
Patch I65da39fd390e4faecc6cfb18bb50e1f5ce684f1e changed the test to
start with port-security-enabled set to False and with no security
group. Later port security is turned on and security group is given but
immediatelly starts testing connectivity. It may happen that security
groups are not applied to the port yet and negative connectivity test
(former No. 3) fails. This patch actively waits for connection not to
pass and then continues as before.

Change-Id: Iddd66770638973a0b3c916f068b5c813886e07ef
2017-02-14 04:28:13 -05:00
Jenkins
28e3c78d79 Merge "trunk: Add tempest test validating subport connectivity" 2017-02-14 07:59:09 +00:00
Jenkins
9911b3dc78 Merge "Enable dstat for in-gate functional and fullstack test runs" 2017-02-14 07:57:45 +00:00
Jenkins
d75571b33d Merge "Don't configure neutron.conf as part of functional/fullstack gate" 2017-02-14 07:57:30 +00:00
Jenkins
654ea6e811 Merge "Switch to use test_utils.call_until_true" 2017-02-14 07:54:00 +00:00
Jenkins
6bf06ee159 Merge "Updated from global requirements" 2017-02-14 01:11:10 +00:00
Itzik Brown
adf97aac9e Adding cleanup of floating ips
Adding floating ips to floating_ips list in test_floating_ips
and test_revisions so they can be cleaned up when
resource_cleanup is called.

Change-Id: I80b50507a69b683dae0e003c5d881f14b8201976
2017-02-14 02:18:39 +02:00
Gary Kotton
5acfa37999 For typo in sqlalchemytypes
TrivialFix

Change-Id: I06407cf474e3c98851f277ba03effe691d8b40ef
2017-02-13 16:18:46 +00:00
Jenkins
6759af1fa9 Merge "Add helper for driver to check if it owns router" 2017-02-13 15:33:24 +00:00
OpenStack Proposal Bot
72e9f60ca6 Updated from global requirements
Change-Id: I847eb889cae34b49130cdb2d5b1b50faf773b460
2017-02-13 15:15:21 +00:00
Kevin Benton
fa0188017a Only log IDs of callbacks in debug message
Logging the ID of the callback should be enough
since the ID contains the path to the callback.

Before:
Notify callbacks
[('neutron.services.segments.db._update_segment_host_mapping_for_agent-8784700722903',
  <function _update_segment_host_mapping_for_agent at 0x7fd58f74ed70>)]
for agent, after_create _notify_loop"

After:
Notify callbacks
['neutron.services.segments.db._update_segment_host_mapping_for_agent-8784700722903']
for agent, after_create _notify_loop"

TrivialFix

Change-Id: I01d886f2707479183d7ae9c530f5f3b7b3963340
2017-02-13 05:30:23 -08:00
Jenkins
bf79852410 Merge "Remove dependency on memory heavy python-requests." 2017-02-13 13:19:19 +00:00
Kevin Benton
c197ff4dbb Add helper for driver to check if it owns router
This adds a helper that an L3 service provider can use to check
if a given router_id is associated with it. This makes skipping
events unrelated to the driver simple calls. See dependent patches
for examples.

Related: blueprint multi-l3-backends
Change-Id: I3ecb935722dd7fe75f73ad410225ff1b93b0f605
2017-02-11 08:02:45 -08:00
Ihar Hrachyshka
ad99fb0ddb Enable dstat for in-gate functional and fullstack test runs
This may become handy when debugging gate failures like job or test case
or ovsdb timeouts, to see the load of the machine, as well as to
understand whether the machine was e.g. locked by its hypervisor during
test run.

Instead of using devstack as a library, we just enable the service in
local.conf [[localrc]], and then call ./stack.sh.

Now that we install some pypi packages into the system, and since
functional targets were using those system packages, post_gate_hook.sh
broke failing to locate subunit-2to1 script in the tox env directory. To
fix that, we disable sitepackages= for all functional tox targets. This
was enabled back in the times when we attempted to install neutron for
the functional job using devstack [1], and we no longer do it, so it
should be ok to stick to all packages from the tox venv.

[1] Icc38cacd69bc5843ccfcc60237a7102df6d8597f

Change-Id: I73857f63f512e26d595c61a20ec5bf22d2fb0da7
2017-02-11 01:32:24 +00:00
yuhui_inspur
c38b206f73 [TrivialFix]Remove the file encoding which is unnecessary
Basically, the commit removes the file encoding - since jenkins is fine
with it, means it was really unnecessary and the change makes sense.

Change-Id: Id0821c9b11b9efad1836596c407566c9eb4dc11a
2017-02-11 01:07:17 +00:00
Ihar Hrachyshka
77e87be9dd Don't configure neutron.conf as part of functional/fullstack gate
The file is not read by any tests, so it's effectively a no-op.

Change-Id: I2938ff89e807ff046e8d81813260951edd49debc
2017-02-11 00:32:58 +00:00
Jenkins
521b1074f1 Merge "Pecan: Fix tags handling for pecan" 2017-02-10 23:59:19 +00:00
Jenkins
73a2aca3e8 Merge "Pecan: Fix policy checks for lists" 2017-02-10 21:49:24 +00:00
Jordan Pittier
c34e11a2f8 Remove dependency on memory heavy python-requests.
It turns out that Neutron uses python-requests on just one place
and for no good reason. Given that loading Requests amount for 80MB
of RAM in my system, maybe it's worth removing our dependency on
requests.

Change-Id: I905252a55bd174ff1aa8bdec42fe32432746846f
2017-02-10 17:07:44 +01:00
Kevin Benton
486e2f4eb5 Pass --concurrent flag to ebtables calls
This flag will force ebtables to acquire a lock so we don't
have to worry about ebtables errors occuring if something else
on the system is trying to use ebtables as well.

Closes-Bug: #1316621
Change-Id: I695c01e015fdc201df8f23d9b48f9d3678240266
2017-02-10 01:52:42 -08:00
Jenkins
cea029f6d3 Merge "DVR: Look at all SNAT ports for a subnet match" 2017-02-10 04:09:13 +00:00
Jenkins
02f893a56d Merge "Revert "Linux Bridge: driver support for QoS egress minimum bandwidth"" 2017-02-10 02:31:24 +00:00
Jenkins
3d7fc906a9 Merge "Add more protocols to the iptables module map" 2017-02-10 02:31:02 +00:00
Jenkins
0fc644b179 Merge "Update devref for enhanced tag mechanism" 2017-02-09 23:27:30 +00:00
Hirofumi Ichihara
e3063496cf Revert "Linux Bridge: driver support for QoS egress minimum bandwidth"
This reverts commit 84b3ae3ae9111e241352bdccad238c9fd37b83df.

The logic was incorrect[1]. We cannot achieve QoS egress minimum bandwidth of Linuxbridge by the patch. I also think that the issue is not solved by small patch and we must consider deeply.

[1]: https://bugs.launchpad.net/neutron/+bug/1662582

Change-Id: Id4703b5c63876f16e31b6805cd147b5840a4a591
2017-02-09 19:11:00 +00:00
Ken'ichi Ohmichi
6649f47eac Switch to use test_utils.call_until_true
test.call_until_true has been deprecated since Newton on Tempest side,
and now Tempest provides test_utils.call_until_true as the stable
library method. So this patch switches to use the stable method before
removing old test.call_until_true on Tempest side.

Change-Id: I139b2ceeb9f840362ae4eeb06d391af4c83733ab
2017-02-09 09:53:51 -08:00
da52700
67da6a3122 Fix typo in .pylintrc file
Change-Id: I00be2feff24a56e82b2c9f3639f5cb33178dd5b3
2017-02-09 01:07:07 +00:00
Hirofumi Ichihara
86c4af7a60 Update devref for enhanced tag mechanism
The devref describes tag mechanism supports network only but
now it supports subnet, port, subnetpool, and router.
This patch updates the description about supported resources.

Change-Id: I1a4b02e253157154218bfe63a18891083178f55a
Closes-Bug: #1662102
2017-02-09 09:14:15 +09:00
Jenkins
ff2c051429 Merge "Deprecate get_locked_port_and_binding" 2017-02-08 09:51:24 +00:00
Jenkins
0d53546294 Merge "Skip reading config files from neutron.conf.d for the namespace proxy" 2017-02-08 07:25:42 +00:00
Jenkins
a076e13b43 Merge "Fix typo in test_l2_lb_agent.py" 2017-02-08 06:52:02 +00:00
Jenkins
72ed1f0dd9 Merge "Fix duplicated sg rules check for remote_ip_prefix" 2017-02-08 06:16:25 +00:00
Jenkins
42747c03b4 Merge "Remove python 3.4 support" 2017-02-08 05:09:55 +00:00
Jenkins
ef50cf9c2e Merge "Fix error in openvswitch firewall doc" 2017-02-07 17:50:06 +00:00
Miguel Angel Ajo
b7213030fd Simplify the QoS bandwidth test to increase reliability
The initial implementation was measuring the bandwidth stability
over segments of time. But recent failures on high gate pressure
has shown that such stability can't be expected on the edge.

The test now checks the average bandwidth during the whole transmission.

Change-Id: Ic6a00f20ce76aba319ecdada79f68599c891cf29
Closes-Bug: #1662109
2017-02-07 16:59:04 +01:00
Jenkins
2c50de512b Merge "Add DBError to _is_nested_instance" 2017-02-07 12:26:17 +00:00
jufeng
0df39b5817 Fix error in openvswitch firewall doc
Change-Id: I662c8959bd8998c9c74ee46413494f92a508ca4f
2017-02-07 17:29:33 +08:00
Jenkins
31e5176a36 Merge "Switch to 'subquery' for 1-M relationships" 2017-02-07 07:10:05 +00:00
Jenkins
3af0fb98a3 Merge "Typo fix: underlaying => underlying" 2017-02-07 06:04:54 +00:00
Jenkins
c6705b42e2 Merge "Use only_contrib option for nova_client calls" 2017-02-07 06:04:39 +00:00
Jenkins
324e6156f2 Merge "Open Pike DB migration branch" 2017-02-07 05:18:00 +00:00
Jenkins
e30becd9b3 Merge "Tag the alembic migration revisions for Ocata" 2017-02-07 05:16:21 +00:00
yujie
785656744a Fix duplicated sg rules check for remote_ip_prefix
Security group rule setting remote_ip_prefix 0.0.0.0/0 for ipv4 or
::/0 for ipv6 plays the same role as the sg rules without setting
remote_ip_prefix. We could treat them as duplicate.

Change-Id: Ic9213e77d3b03aded7fc34d486066c8af4a3b2a1
Closes-Bug: #1534113
2017-02-07 04:46:37 +00:00